September 2017 - git-lng-odp - lists.linaro.org

[COMMIT] branch master updated. v1.15.0.0-219-gf025da71

by git＠git-us.linaro.org

This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "". The branch, master has been updated via f025da7131d921a4207b31bd5af4490da9b0ef24 (commit) from fdc44dd4322f624c2a5d8c0be5306f7c45364520 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit f025da7131d921a4207b31bd5af4490da9b0ef24 Author: Maxim Uvarov <maxim.uvarov(a)linaro.org> Date: Mon Sep 25 22:33:31 2017 +0300 linux-gen: _fdserver return code cleanup somewhere we have return (-1) somewhere -1, let's make it common. Signed-off-by: Maxim Uvarov <maxim.uvarov(a)linaro.org> Reviewed-by: Bill Fischofer <bill.fischofer(a)linaro.org> diff --git a/platform/linux-generic/_fdserver.c b/platform/linux-generic/_fdserver.c index d15ddbec..60bb9139 100644 --- a/platform/linux-generic/_fdserver.c +++ b/platform/linux-generic/_fdserver.c @@ -160,7 +160,7 @@ static int send_fdserver_msg(int sock, int command, res = sendmsg(sock, &socket_message, 0); if (res < 0) { ODP_ERR("send_fdserver_msg: %s\n", strerror(errno)); - return(-1); + return -1; } return 0; @@ -206,7 +206,7 @@ static int recv_fdserver_msg(int sock, int *command, /* receive the message */ if (recvmsg(sock, &socket_message, MSG_CMSG_CLOEXEC) < 0) { ODP_ERR("recv_fdserver_msg: %s\n", strerror(errno)); - return(-1); + return -1; } *command = msg.command; @@ -251,7 +251,7 @@ static int get_socket(void) s_sock = socket(AF_UNIX, SOCK_STREAM, 0); if (s_sock == -1) { ODP_ERR("cannot connect to server: %s\n", strerror(errno)); - return(-1); + return -1; } remote.sun_family = AF_UNIX; @@ -260,7 +260,7 @@ static int get_socket(void) if (connect(s_sock, (struct sockaddr *)&remote, len) == -1) { ODP_ERR("cannot connect to server: %s\n", strerror(errno)); close(s_sock); - return(-1); + return -1; } return s_sock; @@ -286,7 +286,7 @@ int _odp_fdserver_register_fd(fd_server_context_e context, uint64_t key, s_sock = get_socket(); if (s_sock < 0) { odp_spinlock_unlock(client_lock); - return(-1); + return -1; } res = send_fdserver_msg(s_sock, FD_REGISTER_REQ, context, key, @@ -332,7 +332,7 @@ int _odp_fdserver_deregister_fd(fd_server_context_e context, uint64_t key) s_sock = get_socket(); if (s_sock < 0) { odp_spinlock_unlock(client_lock); - return(-1); + return -1; } res = send_fdserver_msg(s_sock, FD_DEREGISTER_REQ, context, key, -1); @@ -375,7 +375,7 @@ int _odp_fdserver_lookup_fd(fd_server_context_e context, uint64_t key) s_sock = get_socket(); if (s_sock < 0) { odp_spinlock_unlock(client_lock); - return(-1); + return -1; } res = send_fdserver_msg(s_sock, FD_LOOKUP_REQ, context, key, -1); @@ -418,7 +418,7 @@ static int stop_server(void) s_sock = get_socket(); if (s_sock < 0) { odp_spinlock_unlock(client_lock); - return(-1); + return -1; } res = send_fdserver_msg(s_sock, FD_SERVERSTOP_REQ, 0, 0, -1); @@ -604,7 +604,7 @@ int _odp_fdserver_init_global(void) sock = socket(AF_UNIX, SOCK_STREAM, 0); if (sock == -1) { ODP_ERR("_odp_fdserver_init_global: %s\n", strerror(errno)); - return(-1); + return -1; } /* remove previous named socket if it already exists: */ @@ -617,14 +617,14 @@ int _odp_fdserver_init_global(void) if (res == -1) { ODP_ERR("_odp_fdserver_init_global: %s\n", strerror(errno)); close(sock); - return(-1); + return -1; } /* listen for incoming conections: */ if (listen(sock, FDSERVER_BACKLOG) == -1) { ODP_ERR("_odp_fdserver_init_global: %s\n", strerror(errno)); close(sock); - return(-1); + return -1; } /* fork a server process: */ @@ -632,7 +632,7 @@ int _odp_fdserver_init_global(void) if (server_pid == -1) { ODP_ERR("Could not fork!\n"); close(sock); - return(-1); + return -1; } if (server_pid == 0) { /*child */ ----------------------------------------------------------------------- Summary of changes: platform/linux-generic/_fdserver.c | 24 ++++++++++++------------ 1 file changed, 12 insertions(+), 12 deletions(-) hooks/post-receive --

6 years, 6 months

1
0
0 0

[COMMIT] branch master updated. v1.15.0.0-218-gfdc44dd4

by git＠git-us.linaro.org

This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "". The branch, master has been updated via fdc44dd4322f624c2a5d8c0be5306f7c45364520 (commit) from 614399faccde551f7ee473e3763254bce96e3444 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit fdc44dd4322f624c2a5d8c0be5306f7c45364520 Author: Dmitry Eremin-Solenikov <dmitry.ereminsolenikov(a)linaro.org> Date: Tue Sep 26 03:09:48 2017 +0300 linux-gen: drop unused _odp_packet_cmp_data() function This is to fix https://bugs.linaro.org/show_bug.cgi?id=3241 Signed-off-by: Dmitry Eremin-Solenikov <dmitry.ereminsolenikov(a)linaro.org> Reviewed-by: Bill Fischofer <bill.fischofer(a)linaro.org> Signed-off-by: Maxim Uvarov <maxim.uvarov(a)linaro.org> diff --git a/platform/linux-generic/include/odp_packet_internal.h b/platform/linux-generic/include/odp_packet_internal.h index d76d7bf0..15cb53f4 100644 --- a/platform/linux-generic/include/odp_packet_internal.h +++ b/platform/linux-generic/include/odp_packet_internal.h @@ -321,9 +321,6 @@ int _odp_cls_parse(odp_packet_hdr_t *pkt_hdr, const uint8_t *parseptr); int _odp_packet_set_data(odp_packet_t pkt, uint32_t offset, uint8_t c, uint32_t len); -int _odp_packet_cmp_data(odp_packet_t pkt, uint32_t offset, - const void *s, uint32_t len); - #ifdef __cplusplus } #endif diff --git a/platform/linux-generic/odp_packet.c b/platform/linux-generic/odp_packet.c index f4a0e0ec..fff01ad9 100644 --- a/platform/linux-generic/odp_packet.c +++ b/platform/linux-generic/odp_packet.c @@ -1642,32 +1642,6 @@ int _odp_packet_set_data(odp_packet_t pkt, uint32_t offset, return 0; } -int _odp_packet_cmp_data(odp_packet_t pkt, uint32_t offset, - const void *s, uint32_t len) -{ - const uint8_t *ptr = s; - void *mapaddr; - uint32_t seglen = 0; /* GCC */ - uint32_t cmplen; - int ret; - odp_packet_hdr_t *pkt_hdr = packet_hdr(pkt); - - ODP_ASSERT(offset + len <= pkt_hdr->frame_len); - - while (len > 0) { - mapaddr = packet_map(pkt_hdr, offset, &seglen, NULL); - cmplen = len > seglen ? seglen : len; - ret = memcmp(mapaddr, ptr, cmplen); - if (ret != 0) - return ret; - offset += cmplen; - len -= cmplen; - ptr += cmplen; - } - - return 0; -} - /* * * Debugging ----------------------------------------------------------------------- Summary of changes: .../linux-generic/include/odp_packet_internal.h | 3 --- platform/linux-generic/odp_packet.c | 26 ---------------------- 2 files changed, 29 deletions(-) hooks/post-receive --

6 years, 6 months

1
0
0 0

[COMMIT] branch api-next updated. v1.15.0.0-709-ge04e5f90

by git＠git-us.linaro.org

This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "". The branch, api-next has been updated via e04e5f90df69e3031622b77fb5273b85d47eb966 (commit) via a9f4c8dd372b1846390ceae6f3f7c8e7578ad743 (commit) via 614399faccde551f7ee473e3763254bce96e3444 (commit) via 13f091e6e0e5fff0552abd1d54b3559b4fc6158f (commit) via f710dd9c76b8a7683f07574afdfc5896f8e4db7a (commit) via 3794fb4eddebf95579fa176d27ef1b82ad16dfdd (commit) via 886e54149d3ee64e56c422a0d3dd7c536e2b4b7d (commit) via ec7353be201b526ade8819d9668dec111a9211d7 (commit) via c2ed3f71a8d61449c5e35ce201f020a74a8ea244 (commit) from 13322ca632f8ffba292bec058e597719bc54142d (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit e04e5f90df69e3031622b77fb5273b85d47eb966 Author: Dmitry Eremin-Solenikov <dmitry.ereminsolenikov(a)linaro.org> Date: Mon Sep 25 21:04:26 2017 +0300 api: ipsec: document restrictions for odp_ipsec_config() Signed-off-by: Dmitry Eremin-Solenikov <dmitry.ereminsolenikov(a)linaro.org> Reviewed-by: Petri Savolainen <petri.savolainen(a)nokia.com> Signed-off-by: Maxim Uvarov <maxim.uvarov(a)linaro.org> diff --git a/include/odp/api/spec/ipsec.h b/include/odp/api/spec/ipsec.h index 5631989f..3bd80b26 100644 --- a/include/odp/api/spec/ipsec.h +++ b/include/odp/api/spec/ipsec.h @@ -791,7 +791,9 @@ void odp_ipsec_config_init(odp_ipsec_config_t *config); * * Initialize and configure IPSEC offload with global configuration options. * This must be called before any SAs are created. Use odp_ipsec_capability() - * to examine which features and modes are supported. + * to examine which features and modes are supported. This function must be + * called before creating the first SA with odp_ipsec_sa_create(). Calling this + * function multiple times results in undefined behaviour. * * @param config Pointer to IPSEC configuration structure * commit a9f4c8dd372b1846390ceae6f3f7c8e7578ad743 Merge: 13322ca6 614399fa Author: Maxim Uvarov <maxim.uvarov(a)linaro.org> Date: Tue Sep 26 21:02:06 2017 +0300 Merge branch 'master' into api-next ----------------------------------------------------------------------- Summary of changes: .travis.yml | 10 ++++++++-- include/odp/api/spec/ipsec.h | 4 +++- platform/linux-generic/include/odp/api/plat/packet_inlines.h | 1 + platform/linux-generic/odp_barrier.c | 4 ++-- 4 files changed, 14 insertions(+), 5 deletions(-) hooks/post-receive --

6 years, 6 months

1
0
0 0

[COMMIT] branch master updated. v1.15.0.0-217-g614399fa

by git＠git-us.linaro.org

This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "". The branch, master has been updated via 614399faccde551f7ee473e3763254bce96e3444 (commit) via 13f091e6e0e5fff0552abd1d54b3559b4fc6158f (commit) from f710dd9c76b8a7683f07574afdfc5896f8e4db7a (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 614399faccde551f7ee473e3763254bce96e3444 Author: Maxim Uvarov <maxim.uvarov(a)linaro.org> Date: Tue Sep 26 20:52:32 2017 +0300 Revert "test: make odp_pktio_perf more scalable" This reverts: commit 3794fb4eddeb ("test: make odp_pktio_perf more scalable") Signed-off-by: Maxim Uvarov <maxim.uvarov(a)linaro.org> diff --git a/test/common_plat/performance/odp_pktio_perf.c b/test/common_plat/performance/odp_pktio_perf.c index 210a833f..a170e128 100644 --- a/test/common_plat/performance/odp_pktio_perf.c +++ b/test/common_plat/performance/odp_pktio_perf.c @@ -167,13 +167,14 @@ static test_globals_t *gbl_args; /* * Generate a single test packet for transmission. */ -static odp_packet_t pktio_create_packet(uint32_t seq) +static odp_packet_t pktio_create_packet(void) { odp_packet_t pkt; odph_ethhdr_t *eth; odph_ipv4hdr_t *ip; odph_udphdr_t *udp; char *buf; + uint16_t seq; uint32_t offset; pkt_head_t pkt_hdr; size_t payload_len; @@ -208,6 +209,7 @@ static odp_packet_t pktio_create_packet(uint32_t seq) ODPH_IPV4HDR_LEN); ip->ttl = 128; ip->proto = ODPH_IPPROTO_UDP; + seq = odp_atomic_fetch_inc_u32(&ip_seq); ip->id = odp_cpu_to_be_16(seq); ip->chksum = 0; odph_ipv4_csum_update(pkt); @@ -261,11 +263,9 @@ static int pktio_pkt_has_magic(odp_packet_t pkt) static int alloc_packets(odp_packet_t *pkt_tbl, int num_pkts) { int n; - uint16_t seq; - seq = odp_atomic_fetch_add_u32(&ip_seq, num_pkts); for (n = 0; n < num_pkts; ++n) { - pkt_tbl[n] = pktio_create_packet(seq + n); + pkt_tbl[n] = pktio_create_packet(); if (pkt_tbl[n] == ODP_PACKET_INVALID) break; } commit 13f091e6e0e5fff0552abd1d54b3559b4fc6158f Author: Maxim Uvarov <maxim.uvarov(a)linaro.org> Date: Tue Sep 26 20:51:56 2017 +0300 Revert "test: disable packet parsing in odp_pktio_perf" This reverts: commit f710dd9c76b8 ("test: disable packet parsing in odp_pktio_perf") Signed-off-by: Maxim Uvarov <maxim.uvarov(a)linaro.org> diff --git a/test/common_plat/performance/odp_pktio_perf.c b/test/common_plat/performance/odp_pktio_perf.c index 01c2eae1..210a833f 100644 --- a/test/common_plat/performance/odp_pktio_perf.c +++ b/test/common_plat/performance/odp_pktio_perf.c @@ -739,7 +739,6 @@ static int test_init(void) odp_pool_param_t params; const char *iface; int schedule; - odp_pktio_config_t cfg; odp_pool_param_init(&params); params.pkt.len = PKT_HDR_LEN + gbl_args->args.pkt_len; @@ -789,13 +788,6 @@ static int test_init(void) return -1; } - /* Disable packet parsing as this is done in the driver where it - * affects scalability. - */ - odp_pktio_config_init(&cfg); - cfg.parser.layer = ODP_PKTIO_PARSER_LAYER_NONE; - odp_pktio_config(gbl_args->pktio_rx, &cfg); - if (gbl_args->args.num_ifaces > 1) { if (odp_pktout_queue_config(gbl_args->pktio_rx, NULL)) { LOG_ERR("failed to configure pktio_rx queue\n"); ----------------------------------------------------------------------- Summary of changes: test/common_plat/performance/odp_pktio_perf.c | 16 ++++------------ 1 file changed, 4 insertions(+), 12 deletions(-) hooks/post-receive --

6 years, 6 months

1
0
0 0

[COMMIT] branch master updated. v1.15.0.0-215-gf710dd9c

by git＠git-us.linaro.org

This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "". The branch, master has been updated via f710dd9c76b8a7683f07574afdfc5896f8e4db7a (commit) via 3794fb4eddebf95579fa176d27ef1b82ad16dfdd (commit) from 886e54149d3ee64e56c422a0d3dd7c536e2b4b7d (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit f710dd9c76b8a7683f07574afdfc5896f8e4db7a Author: Ola Liljedahl <ola.liljedahl(a)arm.com> Date: Tue May 30 22:35:59 2017 +0200 test: disable packet parsing in odp_pktio_perf Disable packet parsing as it is done in the driver where it affects scalability of the application. This especially problematic for e.g. the loopback pktio which has only one RX queue. Signed-off-by: Ola Liljedahl <ola.liljedahl(a)arm.com> Reviewed-by: Brian Brooks <brian.brooks(a)arm.com> Reviewed-by: Bill Fischofer <bill.fischofer(a)linaro.org> Signed-off-by: Maxim Uvarov <maxim.uvarov(a)linaro.org> diff --git a/test/common_plat/performance/odp_pktio_perf.c b/test/common_plat/performance/odp_pktio_perf.c index 210a833f..01c2eae1 100644 --- a/test/common_plat/performance/odp_pktio_perf.c +++ b/test/common_plat/performance/odp_pktio_perf.c @@ -739,6 +739,7 @@ static int test_init(void) odp_pool_param_t params; const char *iface; int schedule; + odp_pktio_config_t cfg; odp_pool_param_init(&params); params.pkt.len = PKT_HDR_LEN + gbl_args->args.pkt_len; @@ -788,6 +789,13 @@ static int test_init(void) return -1; } + /* Disable packet parsing as this is done in the driver where it + * affects scalability. + */ + odp_pktio_config_init(&cfg); + cfg.parser.layer = ODP_PKTIO_PARSER_LAYER_NONE; + odp_pktio_config(gbl_args->pktio_rx, &cfg); + if (gbl_args->args.num_ifaces > 1) { if (odp_pktout_queue_config(gbl_args->pktio_rx, NULL)) { LOG_ERR("failed to configure pktio_rx queue\n"); commit 3794fb4eddebf95579fa176d27ef1b82ad16dfdd Author: Ola Liljedahl <ola.liljedahl(a)arm.com> Date: Tue May 30 22:15:01 2017 +0200 test: make odp_pktio_perf more scalable Amortise overhead of atomic increment over multiple packets so to minimise this scalability bottleneck. Signed-off-by: Ola Liljedahl <ola.liljedahl(a)arm.com> Reviewed-by: Brian Brooks <brian.brooks(a)arm.com> Reviewed-by: Bill Fischofer <bill.fischofer(a)linaro.org> Signed-off-by: Maxim Uvarov <maxim.uvarov(a)linaro.org> diff --git a/test/common_plat/performance/odp_pktio_perf.c b/test/common_plat/performance/odp_pktio_perf.c index a170e128..210a833f 100644 --- a/test/common_plat/performance/odp_pktio_perf.c +++ b/test/common_plat/performance/odp_pktio_perf.c @@ -167,14 +167,13 @@ static test_globals_t *gbl_args; /* * Generate a single test packet for transmission. */ -static odp_packet_t pktio_create_packet(void) +static odp_packet_t pktio_create_packet(uint32_t seq) { odp_packet_t pkt; odph_ethhdr_t *eth; odph_ipv4hdr_t *ip; odph_udphdr_t *udp; char *buf; - uint16_t seq; uint32_t offset; pkt_head_t pkt_hdr; size_t payload_len; @@ -209,7 +208,6 @@ static odp_packet_t pktio_create_packet(void) ODPH_IPV4HDR_LEN); ip->ttl = 128; ip->proto = ODPH_IPPROTO_UDP; - seq = odp_atomic_fetch_inc_u32(&ip_seq); ip->id = odp_cpu_to_be_16(seq); ip->chksum = 0; odph_ipv4_csum_update(pkt); @@ -263,9 +261,11 @@ static int pktio_pkt_has_magic(odp_packet_t pkt) static int alloc_packets(odp_packet_t *pkt_tbl, int num_pkts) { int n; + uint16_t seq; + seq = odp_atomic_fetch_add_u32(&ip_seq, num_pkts); for (n = 0; n < num_pkts; ++n) { - pkt_tbl[n] = pktio_create_packet(); + pkt_tbl[n] = pktio_create_packet(seq + n); if (pkt_tbl[n] == ODP_PACKET_INVALID) break; } ----------------------------------------------------------------------- Summary of changes: test/common_plat/performance/odp_pktio_perf.c | 16 ++++++++++++---- 1 file changed, 12 insertions(+), 4 deletions(-) hooks/post-receive --

6 years, 6 months

1
0
0 0

[COMMIT] branch master updated. v1.15.0.0-213-g886e5414

by git＠git-us.linaro.org

This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "". The branch, master has been updated via 886e54149d3ee64e56c422a0d3dd7c536e2b4b7d (commit) via ec7353be201b526ade8819d9668dec111a9211d7 (commit) from c2ed3f71a8d61449c5e35ce201f020a74a8ea244 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 886e54149d3ee64e56c422a0d3dd7c536e2b4b7d Author: Bill Fischofer <bill.fischofer(a)linaro.org> Date: Fri Sep 22 08:41:19 2017 -0500 linux-generic: packet: add missing doxygen from inline func Add missing doxygen for internal function packet_to_buffer to avoid warnings under latest doxygen. This fixes Bug https://bugs.linaro.org/show_bug.cgi?id=3262 Signed-off-by: Bill Fischofer <bill.fischofer(a)linaro.org> Signed-off-by: Maxim Uvarov <maxim.uvarov(a)linaro.org> diff --git a/platform/linux-generic/include/odp/api/plat/packet_inlines.h b/platform/linux-generic/include/odp/api/plat/packet_inlines.h index be7e18ec..1804fa6f 100644 --- a/platform/linux-generic/include/odp/api/plat/packet_inlines.h +++ b/platform/linux-generic/include/odp/api/plat/packet_inlines.h @@ -157,6 +157,7 @@ static inline void _odp_packet_prefetch(odp_packet_t pkt, uint32_t offset, (void)pkt; (void)offset; (void)len; } +/** @internal Inline function @param pkt @return */ static inline odp_buffer_t packet_to_buffer(odp_packet_t pkt) { return (odp_buffer_t)pkt; commit ec7353be201b526ade8819d9668dec111a9211d7 Author: Maxim Uvarov <maxim.uvarov(a)linaro.org> Date: Mon Sep 25 21:18:29 2017 +0300 travis: correct doxygen warning capture use if else bash syntax for grep warnings from log. Signed-off-by: Maxim Uvarov <maxim.uvarov(a)linaro.org> Reviewed-by: Bill Fischofer <bill.fischofer(a)linaro.org> diff --git a/.travis.yml b/.travis.yml index a9ae219d..395feb0e 100644 --- a/.travis.yml +++ b/.travis.yml @@ -249,11 +249,17 @@ jobs: fi - export PATH=$HOME/doxygen-install/bin:$PATH - # doxygen does not trap on warnings, check for them here. - ./bootstrap - ./configure + # doxygen does not trap on warnings, check for them here. - make doxygen-doc 2>&1 |tee doxygen.log - - fgrep -rq warning ./doxygen.log && false + - | + fgrep -rq warning ./test.log + if [ $? -eq 0 ]; then + false + else + true + fi - stage: test env: TEST=checkpatch compiler: gcc ----------------------------------------------------------------------- Summary of changes: .travis.yml | 10 ++++++++-- platform/linux-generic/include/odp/api/plat/packet_inlines.h | 1 + 2 files changed, 9 insertions(+), 2 deletions(-) hooks/post-receive --

6 years, 6 months

1
0
0 0

[COMMIT] branch master updated. v1.15.0.0-211-gc2ed3f71

by git＠git-us.linaro.org

This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "". The branch, master has been updated via c2ed3f71a8d61449c5e35ce201f020a74a8ea244 (commit) from cbb7f52e28d2e1c20c8eac662aa6135242d072e8 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit c2ed3f71a8d61449c5e35ce201f020a74a8ea244 Author: Brian Brooks <brian.brooks(a)arm.com> Date: Sat Aug 26 00:40:08 2017 -0500 linux-gen: barrier: Use correct memory ordering Memory accesses that happen-before, in program order, a call to odp_barrier_wait() cannot be reordered to after the call. Similarly, memory accesses that happen-after, in program order, a call to odp_barrier_wait() cannot be reordered to before the call. The current implementation of barriers uses sequentially consistent fences on either side of odp_barrier_wait(). The correct memory ordering for barriers is release upon entering odp_barrier_wait(), to prevent reordering to after the barrier, and acquire upon exiting odp_barrier_wait(), to prevent reordering to before the barrier. The measurable performance difference is negligible on weakly ordered architectures such as ARM, so the highlight of this change is correctness. Signed-off-by: Brian Brooks <brian.brooks(a)arm.com> Reviewed-by: Bill Fischofer <bill.fischofer(a)linaro.org> Signed-off-by: Maxim Uvarov <maxim.uvarov(a)linaro.org> diff --git a/platform/linux-generic/odp_barrier.c b/platform/linux-generic/odp_barrier.c index 5eb354de..f70bdbf8 100644 --- a/platform/linux-generic/odp_barrier.c +++ b/platform/linux-generic/odp_barrier.c @@ -34,7 +34,7 @@ void odp_barrier_wait(odp_barrier_t *barrier) uint32_t count; int wasless; - odp_mb_full(); + odp_mb_release(); count = odp_atomic_fetch_inc_u32(&barrier->bar); wasless = count < barrier->count; @@ -48,5 +48,5 @@ void odp_barrier_wait(odp_barrier_t *barrier) odp_cpu_pause(); } - odp_mb_full(); + odp_mb_acquire(); } ----------------------------------------------------------------------- Summary of changes: platform/linux-generic/odp_barrier.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) hooks/post-receive --

6 years, 6 months

1
0
0 0

[COMMIT] branch api-next updated. v1.15.0.0-700-g13322ca6

by git＠git-us.linaro.org

This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "". The branch, api-next has been updated via 13322ca632f8ffba292bec058e597719bc54142d (commit) via cbb7f52e28d2e1c20c8eac662aa6135242d072e8 (commit) via 49093654e6faa652387bc192c17b5006af0fc0b4 (commit) via f6f317fc47a0314f1077af2477fc169302953e5c (commit) via d091f2176a28b09503aef6aabbbe7d2433e3b69b (commit) from bfbe4f50a2e8a2532fdcb4d2c16d42a477183c07 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 13322ca632f8ffba292bec058e597719bc54142d Merge: bfbe4f50 cbb7f52e Author: Maxim Uvarov <maxim.uvarov(a)linaro.org> Date: Thu Sep 21 15:51:06 2017 +0300 Merge branch 'master' into api-next diff --cc .travis.yml index 8cf6ed22,a9ae219d..c1626b1a --- a/.travis.yml +++ b/.travis.yml @@@ -39,9 -39,8 +39,9 @@@ addons packages: - gcc - clang-3.8 - - automake autoconf libtool libssl-dev graphviz mscgen doxygen + - automake autoconf libtool libssl-dev graphviz mscgen - libpcap-dev + - libconfig-dev # coverity_scan: # project: # name: "$TRAVIS_REPO_SLUG" ----------------------------------------------------------------------- Summary of changes: .travis.yml | 18 +++++++++++++++--- configure.ac | 1 - test/common_plat/m4/validation.m4 | 24 ++++++++++++++++-------- 3 files changed, 31 insertions(+), 12 deletions(-) hooks/post-receive --

6 years, 6 months

1
0
0 0

[COMMIT] branch master updated. v1.15.0.0-210-gcbb7f52e

by git＠git-us.linaro.org

This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "". The branch, master has been updated via cbb7f52e28d2e1c20c8eac662aa6135242d072e8 (commit) via 49093654e6faa652387bc192c17b5006af0fc0b4 (commit) via f6f317fc47a0314f1077af2477fc169302953e5c (commit) from d091f2176a28b09503aef6aabbbe7d2433e3b69b (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit cbb7f52e28d2e1c20c8eac662aa6135242d072e8 Author: Maxim Uvarov <maxim.uvarov(a)linaro.org> Date: Tue Sep 19 23:23:23 2017 +0300 travis: cache doxygen Signed-off-by: Maxim Uvarov <maxim.uvarov(a)linaro.org> Reviewed-by: Bill Fischofer <bill.fischofer(a)linaro.org> Reviewed-by: Dmitry Eremin-Solenikov <dmitry.ereminsolenikov(a)linaro.org> diff --git a/.travis.yml b/.travis.yml index 21fa9e3b..a9ae219d 100644 --- a/.travis.yml +++ b/.travis.yml @@ -60,6 +60,7 @@ cache: - dpdk - netmap - $HOME/cunit-install + - $HOME/doxygen-install env: - CONF="" @@ -237,13 +238,17 @@ jobs: install: - true script: - - wget https://github.com/doxygen/doxygen/archive/Release_1_8_13.tar.gz - - tar xpvf Release_1_8_13.tar.gz - - pushd doxygen-Release_1_8_13 - - cmake -DCMAKE_INSTALL_PREFIX=/usr . - - sudo make install - - popd + - | + if [ ! -f "$HOME/doxygen-install/bin/doxygen" ]; then + wget https://github.com/doxygen/doxygen/archive/Release_1_8_13.tar.gz + tar xpvf Release_1_8_13.tar.gz + pushd doxygen-Release_1_8_13 + cmake -DCMAKE_INSTALL_PREFIX=$HOME/doxygen-install . + make install + popd + fi + - export PATH=$HOME/doxygen-install/bin:$PATH # doxygen does not trap on warnings, check for them here. - ./bootstrap - ./configure commit 49093654e6faa652387bc192c17b5006af0fc0b4 Author: Maxim Uvarov <maxim.uvarov(a)linaro.org> Date: Tue Sep 19 13:05:15 2017 +0300 travis: capture doxygen warnings right declare more clear syntax to capture doxygen warnings. Signed-off-by: Maxim Uvarov <maxim.uvarov(a)linaro.org> Reviewed-by: Bill Fischofer <bill.fischofer(a)linaro.org> Reviewed-by: Dmitry Eremin-Solenikov <dmitry.ereminsolenikov(a)linaro.org> diff --git a/.travis.yml b/.travis.yml index 875509cf..21fa9e3b 100644 --- a/.travis.yml +++ b/.travis.yml @@ -247,8 +247,8 @@ jobs: # doxygen does not trap on warnings, check for them here. - ./bootstrap - ./configure - - make doxygen-doc |tee doxygen.log - - fgrep -rvq warning ./doxygen.log + - make doxygen-doc 2>&1 |tee doxygen.log + - fgrep -rq warning ./doxygen.log && false - stage: test env: TEST=checkpatch compiler: gcc commit f6f317fc47a0314f1077af2477fc169302953e5c Author: Maxim Uvarov <maxim.uvarov(a)linaro.org> Date: Mon Sep 18 19:21:11 2017 +0300 travis: doxygen 1.8.13 Signed-off-by: Maxim Uvarov <maxim.uvarov(a)linaro.org> Reviewed-by: Bill Fischofer <bill.fischofer(a)linaro.org> Reviewed-by: Dmitry Eremin-Solenikov <dmitry.ereminsolenikov(a)linaro.org> diff --git a/.travis.yml b/.travis.yml index 43141f9f..875509cf 100644 --- a/.travis.yml +++ b/.travis.yml @@ -39,7 +39,7 @@ addons: packages: - gcc - clang-3.8 - - automake autoconf libtool libssl-dev graphviz mscgen doxygen + - automake autoconf libtool libssl-dev graphviz mscgen - libpcap-dev # coverity_scan: # project: @@ -237,6 +237,13 @@ jobs: install: - true script: + - wget https://github.com/doxygen/doxygen/archive/Release_1_8_13.tar.gz + - tar xpvf Release_1_8_13.tar.gz + - pushd doxygen-Release_1_8_13 + - cmake -DCMAKE_INSTALL_PREFIX=/usr . + - sudo make install + - popd + # doxygen does not trap on warnings, check for them here. - ./bootstrap - ./configure ----------------------------------------------------------------------- Summary of changes: .travis.yml | 18 +++++++++++++++--- 1 file changed, 15 insertions(+), 3 deletions(-) hooks/post-receive --

6 years, 6 months

1
0
0 0

[COMMIT] branch master updated. v1.15.0.0-207-gd091f217

by git＠git-us.linaro.org

This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "". The branch, master has been updated via d091f2176a28b09503aef6aabbbe7d2433e3b69b (commit) from e1c46f8e296a730ed27141a33189185bb7dfd1b1 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit d091f2176a28b09503aef6aabbbe7d2433e3b69b Author: Dmitry Eremin-Solenikov <dmitry.ereminsolenikov(a)linaro.org> Date: Tue Sep 19 19:10:37 2017 +0300 configure: "best effort" approach for CUnit and validation tests Allow configure to succeed (by disabling validation testsuite), if CUnit library was not found or if user did not specify --enable-test-vald explicitly). Signed-off-by: Dmitry Eremin-Solenikov <dmitry.ereminsolenikov(a)linaro.org> Reviewed-by: Bill Fischofer <bill.fischofer(a)linaro.org> Signed-off-by: Maxim Uvarov <maxim.uvarov(a)linaro.org> diff --git a/configure.ac b/configure.ac index 4af2c7c7..f7da75ec 100644 --- a/configure.ac +++ b/configure.ac @@ -214,7 +214,6 @@ AM_CONDITIONAL([test_installdir], [test "x$testdir" != "xno"]) # Set conditionals as computed within platform specific files ########################################################################## AM_CONDITIONAL([SDK_INSTALL_PATH_], [test "x${SDK_INSTALL_PATH_}" = "x1"]) -AM_CONDITIONAL([cunit_support], [test x$cunit_support = xyes ]) AM_CONDITIONAL([HAVE_DOXYGEN], [test "x${DOXYGEN}" = "xdoxygen"]) AM_CONDITIONAL([user_guide], [test "x${user_guides}" = "xyes" ]) AM_CONDITIONAL([HAVE_MSCGEN], [test "x${MSCGEN}" = "xmscgen"]) diff --git a/test/common_plat/m4/validation.m4 b/test/common_plat/m4/validation.m4 index 78c4ec03..bf849aa3 100644 --- a/test/common_plat/m4/validation.m4 +++ b/test/common_plat/m4/validation.m4 @@ -4,21 +4,29 @@ AC_ARG_ENABLE([test_vald], [AS_HELP_STRING([--enable-test-vald], [run test in test/validation])], [test_vald=$enableval], - [test_vald=yes]) -AM_CONDITIONAL([test_vald], [test x$test_vald = xyes ]) + [test_vald=check]) ########################################################################## # Check for CUnit availability ########################################################################## cunit_support=$test_vald -AS_IF([test "x$cunit_support" = "xyes"], - [PKG_CHECK_MODULES([CUNIT], [cunit], [], +AS_IF([test "x$cunit_support" != "xno"], + [PKG_CHECK_MODULES([CUNIT], [cunit], [cunit_support=yes], [AC_MSG_WARN([pkg-config could not find CUnit, guessing]) - AC_CHECK_HEADERS([CUnit/Basic.h], [], - [AC_MSG_ERROR(["can't find CUnit headers"])]) - AC_CHECK_LIB([cunit],[CU_get_error], [CUNIT_LIBS="-lcunit"], - [AC_MSG_ERROR([CUnit libraries required])]) + cunit_support=yes + AC_CHECK_HEADERS([CUnit/Basic.h], [], [cunit_support=no]) + AC_CHECK_LIB([cunit], [CU_get_error], [CUNIT_LIBS="-lcunit"], + [cunit_support=no]) ])]) +AS_IF([test "x$test_vald" = "xyes" -a "x$cunit_support" = "xno"], + [AC_MSG_ERROR([Validation testsuite requested, but CUnit was not found])], + [test "x$test_vald" = "xcheck" -a "x$cunit_support" = "xno"], + [AC_MSG_WARN([CUnit was not found, disabling validation testsuite]) + test_vald=no]) + +AM_CONDITIONAL([cunit_support], [test "x$cunit_support" = "xyes"]) +AM_CONDITIONAL([test_vald], [test "x$test_vald" = "xyes"]) + AC_SUBST([CUNIT_CFLAGS]) AC_SUBST([CUNIT_LIBS]) ----------------------------------------------------------------------- Summary of changes: configure.ac | 1 - test/common_plat/m4/validation.m4 | 24 ++++++++++++++++-------- 2 files changed, 16 insertions(+), 9 deletions(-) hooks/post-receive --

6 years, 6 months

1
0
0 0

2024

2023

2022

2021

2020

2019

2018

2017

2016

git-lng-odp September 2017