April 2018 - git-lng-odp - lists.linaro.org

[COMMIT] branch master updated. v1.19.0.0_tigermoth-8-gc440dfce

by git＠git-us.linaro.org

This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "". The branch, master has been updated via c440dfceff97526d2763383afd8da064faef3d0d (commit) via 93591a6134fbc5655c0cf6a25e0b4e0668357971 (commit) via fec701841dbe2e963cf3adc7c74c98b41e059b9d (commit) via 0e24607e3075a573ebe4ac408703c76daac7236c (commit) via 5d4be5077adeec54d1956c86dcb87b186c39a7cb (commit) via 3aa3f4352083d159260cebc23b87607e73aa6f2b (commit) via 0d4271e31fe685a8a82381d21d5166f0398080c1 (commit) via d324b9de12c510ccf9fa1c1b6ece327c578ee53d (commit) from e828b4d6f503ff94c40e30b1d8babf0dcbecde91 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit c440dfceff97526d2763383afd8da064faef3d0d Author: Dmitry Eremin-Solenikov <dmitry.ereminsolenikov(a)linaro.org> Date: Sun Apr 22 10:18:17 2018 +0300 linux-generic: random: split from crypto module While random and crypto might share some implementation details, in case of linux-generic and linux-DPDK it might be easier to split them to two different files. Signed-off-by: Dmitry Eremin-Solenikov <dmitry.ereminsolenikov(a)linaro.org> Reviewed-by: Bill Fischofer <bill.fischofer(a)linaro.org> Signed-off-by: Maxim Uvarov <maxim.uvarov(a)linaro.org> diff --git a/platform/linux-generic/Makefile.am b/platform/linux-generic/Makefile.am index 4f03eab1..7d1d5554 100644 --- a/platform/linux-generic/Makefile.am +++ b/platform/linux-generic/Makefile.am @@ -175,6 +175,7 @@ __LIB__libodp_linux_la_SOURCES = \ odp_queue_if.c \ odp_queue_lf.c \ odp_queue_scalable.c \ + odp_random.c \ odp_rwlock.c \ odp_rwlock_recursive.c \ odp_schedule_basic.c \ diff --git a/platform/linux-generic/odp_crypto.c b/platform/linux-generic/odp_crypto.c index 852f0212..aca822d8 100644 --- a/platform/linux-generic/odp_crypto.c +++ b/platform/linux-generic/odp_crypto.c @@ -23,7 +23,6 @@ #include <string.h> #include <stdlib.h> -#include <openssl/rand.h> #include <openssl/hmac.h> #include <openssl/cmac.h> #include <openssl/evp.h> @@ -1954,47 +1953,6 @@ int _odp_crypto_term_local(void) return 0; } -odp_random_kind_t odp_random_max_kind(void) -{ - return ODP_RANDOM_CRYPTO; -} - -int32_t odp_random_data(uint8_t *buf, uint32_t len, odp_random_kind_t kind) -{ - int rc; - - switch (kind) { - case ODP_RANDOM_BASIC: - case ODP_RANDOM_CRYPTO: - rc = RAND_bytes(buf, len); - return (1 == rc) ? (int)len /*success*/: -1 /*failure*/; - - case ODP_RANDOM_TRUE: - default: - return -1; - } -} - -int32_t odp_random_test_data(uint8_t *buf, uint32_t len, uint64_t *seed) -{ - union { - uint32_t rand_word; - uint8_t rand_byte[4]; - } u; - uint32_t i = 0, j; - uint32_t seed32 = (*seed) & 0xffffffff; - - while (i < len) { - u.rand_word = rand_r(&seed32); - - for (j = 0; j < 4 && i < len; j++, i++) - *buf++ = u.rand_byte[j]; - } - - *seed = seed32; - return len; -} - odp_crypto_compl_t odp_crypto_compl_from_event(odp_event_t ev) { /* This check not mandated by the API specification */ diff --git a/platform/linux-generic/odp_random.c b/platform/linux-generic/odp_random.c new file mode 100644 index 00000000..22894c47 --- /dev/null +++ b/platform/linux-generic/odp_random.c @@ -0,0 +1,54 @@ +/* Copyright (c) 2014-2018, Linaro Limited + * All rights reserved. + * + * SPDX-License-Identifier: BSD-3-Clause + */ + +#include "config.h" + +#include <odp_posix_extensions.h> +#include <odp_internal.h> +#include <odp/api/random.h> + +#include <openssl/rand.h> + +odp_random_kind_t odp_random_max_kind(void) +{ + return ODP_RANDOM_CRYPTO; +} + +int32_t odp_random_data(uint8_t *buf, uint32_t len, odp_random_kind_t kind) +{ + int rc; + + switch (kind) { + case ODP_RANDOM_BASIC: + case ODP_RANDOM_CRYPTO: + rc = RAND_bytes(buf, len); + return (1 == rc) ? (int)len /*success*/: -1 /*failure*/; + + case ODP_RANDOM_TRUE: + default: + return -1; + } +} + +int32_t odp_random_test_data(uint8_t *buf, uint32_t len, uint64_t *seed) +{ + union { + uint32_t rand_word; + uint8_t rand_byte[4]; + } u; + uint32_t i = 0, j; + uint32_t seed32 = (*seed) & 0xffffffff; + + while (i < len) { + u.rand_word = rand_r(&seed32); + + for (j = 0; j < 4 && i < len; j++, i++) + *buf++ = u.rand_byte[j]; + } + + *seed = seed32; + return len; +} commit 93591a6134fbc5655c0cf6a25e0b4e0668357971 Author: Petri Savolainen <petri.savolainen(a)linaro.org> Date: Fri Apr 20 14:25:30 2018 +0300 validation: timer: honor min timeout param value Timeout requests should be between min_tmo and max_tmo timer pool parameters, if too early/too late return codes are reported as test failures. Signed-off-by: Petri Savolainen <petri.savolainen(a)linaro.org> Reviewed-by: Bill Fischofer <bill.fischofer(a)linaro.org> Signed-off-by: Maxim Uvarov <maxim.uvarov(a)linaro.org> diff --git a/test/validation/api/timer/timer.c b/test/validation/api/timer/timer.c index f81a3d09..a34885c0 100644 --- a/test/validation/api/timer/timer.c +++ b/test/validation/api/timer/timer.c @@ -497,7 +497,7 @@ static int worker_entrypoint(void *arg TEST_UNUSED) uint32_t ncancel; uint32_t ntoolate; uint32_t ms; - uint64_t prev_tick; + uint64_t prev_tick, nsec; odp_event_t ev; struct timespec ts; uint32_t nstale; @@ -539,9 +539,9 @@ static int worker_entrypoint(void *arg TEST_UNUSED) /* Initial set all timers with a random expiration time */ nset = 0; for (i = 0; i < allocated; i++) { - tck = odp_timer_current_tick(tp) + 1 + - odp_timer_ns_to_tick(tp, (rand_r(&seed) % RANGE_MS) - * 1000000ULL); + nsec = MIN_TMO + (rand_r(&seed) % RANGE_MS) * 1000000ULL; + tck = odp_timer_current_tick(tp) + + odp_timer_ns_to_tick(tp, nsec); timer_rc = odp_timer_set_abs(tt[i].tim, tck, &tt[i].ev); if (timer_rc == ODP_TIMER_TOOEARLY) { LOG_ERR("Missed tick, setting timer\n"); @@ -585,7 +585,7 @@ static int worker_entrypoint(void *arg TEST_UNUSED) } else { odp_timer_set_t rc; uint64_t cur_tick; - uint64_t tck, nsec; + uint64_t tck; if (tt[i].ev != ODP_EVENT_INVALID) /* Timer inactive => set */ @@ -594,16 +594,18 @@ static int worker_entrypoint(void *arg TEST_UNUSED) /* Timer active => reset */ nreset++; - nsec = (rand_r(&seed) % RANGE_MS) * 1000000ULL; - tck = 1 + odp_timer_ns_to_tick(tp, nsec); + nsec = MIN_TMO + + (rand_r(&seed) % RANGE_MS) * 1000000ULL; + tck = odp_timer_ns_to_tick(tp, nsec); cur_tick = odp_timer_current_tick(tp); rc = odp_timer_set_rel(tt[i].tim, tck, &tt[i].ev); - if (rc == ODP_TIMER_TOOEARLY || - rc == ODP_TIMER_TOOLATE) { - CU_FAIL("Failed to set timer (tooearly/toolate)"); - } else if (rc != ODP_TIMER_SUCCESS) { + if (rc == ODP_TIMER_TOOEARLY) { + CU_FAIL("Failed to set timer: TOO EARLY"); + } else if (rc == ODP_TIMER_TOOLATE) { + CU_FAIL("Failed to set timer: TOO LATE"); + } else if (rc == ODP_TIMER_NOEVENT) { /* Set/reset failed, timer already expired */ ntoolate++; } else if (rc == ODP_TIMER_SUCCESS) { @@ -611,6 +613,8 @@ static int worker_entrypoint(void *arg TEST_UNUSED) tt[i].tick = cur_tick + tck; /* ODP timer owns the event now */ tt[i].ev = ODP_EVENT_INVALID; + } else { + CU_FAIL("Failed to set timer: bad return code"); } } ts.tv_sec = 0; @@ -743,7 +747,10 @@ static void timer_test_odp_timer_all(void) CU_ASSERT(strcmp(tpinfo.name, NAME) == 0); LOG_DBG("Timer pool handle: %" PRIu64 "\n", odp_timer_pool_to_u64(tp)); - LOG_DBG("#timers..: %u\n", NTIMERS); + LOG_DBG("Resolution: %" PRIu64 "\n", tparam.res_ns); + LOG_DBG("Min timeout: %" PRIu64 "\n", tparam.min_tmo); + LOG_DBG("Max timeout: %" PRIu64 "\n", tparam.max_tmo); + LOG_DBG("Num timers..: %u\n", tparam.num_timers); LOG_DBG("Tmo range: %u ms (%" PRIu64 " ticks)\n", RANGE_MS, odp_timer_ns_to_tick(tp, 1000000ULL * RANGE_MS)); commit fec701841dbe2e963cf3adc7c74c98b41e059b9d Author: Petri Savolainen <petri.savolainen(a)linaro.org> Date: Thu Apr 19 17:54:36 2018 +0300 validation: timer: fix timer_all test sync issue When timer is reset, odp_timer_set_rel() outputs the previous event handle (not ODP_EVENT_INVALID as in case of set). Test case 'timer_all' maintain test status in the event handle variable. Set the variable always to EVENT_INVALID so that both set and reset cases work the same way. Signed-off-by: Petri Savolainen <petri.savolainen(a)linaro.org> Reviewed-by: Bill Fischofer <bill.fischofer(a)linaro.org> Signed-off-by: Maxim Uvarov <maxim.uvarov(a)linaro.org> diff --git a/test/validation/api/timer/timer.c b/test/validation/api/timer/timer.c index 8ab58137..f81a3d09 100644 --- a/test/validation/api/timer/timer.c +++ b/test/validation/api/timer/timer.c @@ -609,6 +609,8 @@ static int worker_entrypoint(void *arg TEST_UNUSED) } else if (rc == ODP_TIMER_SUCCESS) { /* Save expected expiration tick on success */ tt[i].tick = cur_tick + tck; + /* ODP timer owns the event now */ + tt[i].ev = ODP_EVENT_INVALID; } } ts.tv_sec = 0; commit 0e24607e3075a573ebe4ac408703c76daac7236c Author: Petri Savolainen <petri.savolainen(a)linaro.org> Date: Thu Apr 19 14:40:21 2018 +0300 validation: timer: add plain and sched queue tests Added simple timeout delivery tests for plain and scheduled queues. Current "timer_all" test is complex and tests only plain queues. Signed-off-by: Petri Savolainen <petri.savolainen(a)linaro.org> Reviewed-by: Bill Fischofer <bill.fischofer(a)linaro.org> Signed-off-by: Maxim Uvarov <maxim.uvarov(a)linaro.org> diff --git a/test/validation/api/timer/timer.c b/test/validation/api/timer/timer.c index bd4f1b99..8ab58137 100644 --- a/test/validation/api/timer/timer.c +++ b/test/validation/api/timer/timer.c @@ -144,6 +144,170 @@ static void timer_test_timeout_pool_free(void) CU_ASSERT(odp_pool_destroy(pool) == 0); } +static void timer_test_queue_type(odp_queue_type_t queue_type) +{ + odp_pool_t pool; + const int num = 10; + odp_timeout_t tmo; + odp_event_t ev; + odp_queue_param_t queue_param; + odp_timer_pool_param_t tparam; + odp_timer_pool_t tp; + odp_queue_t queue; + odp_timer_t tim; + int i, ret, num_tmo; + uint64_t tick_base, tick; + uint64_t res_ns, period_ns, period_tick, test_period; + uint64_t diff_period, diff_test; + odp_pool_param_t params; + odp_timer_capability_t timer_capa; + odp_time_t t0, t1, t2; + + odp_pool_param_init(&params); + params.type = ODP_POOL_TIMEOUT; + params.tmo.num = num; + + pool = odp_pool_create("timeout_pool", &params); + CU_ASSERT_FATAL(pool != ODP_POOL_INVALID); + + if (odp_timer_capability(ODP_CLOCK_CPU, &timer_capa)) + CU_FAIL_FATAL("Timer capability failed") + + res_ns = 20 * ODP_TIME_MSEC_IN_NS; + + if (timer_capa.highest_res_ns > res_ns) + res_ns = timer_capa.highest_res_ns; + + tparam.res_ns = res_ns; + tparam.min_tmo = 5 * res_ns; + tparam.max_tmo = 10000 * tparam.min_tmo; + tparam.num_timers = num + 1; + tparam.priv = 0; + tparam.clk_src = ODP_CLOCK_CPU; + + LOG_DBG("\nTimer pool parameters:\n"); + LOG_DBG(" res_ns %" PRIu64 "\n", tparam.res_ns); + LOG_DBG(" min_tmo %" PRIu64 "\n", tparam.min_tmo); + LOG_DBG(" max_tmo %" PRIu64 "\n", tparam.max_tmo); + + tp = odp_timer_pool_create("timer_pool", &tparam); + if (tp == ODP_TIMER_POOL_INVALID) + CU_FAIL_FATAL("Timer pool create failed"); + + odp_timer_pool_start(); + + odp_queue_param_init(&queue_param); + if (queue_type == ODP_QUEUE_TYPE_SCHED) { + queue_param.type = ODP_QUEUE_TYPE_SCHED; + queue_param.sched.prio = ODP_SCHED_PRIO_DEFAULT; + queue_param.sched.sync = ODP_SCHED_SYNC_ATOMIC; + queue_param.sched.group = ODP_SCHED_GROUP_ALL; + } + + queue = odp_queue_create("timer_queue", &queue_param); + if (queue == ODP_QUEUE_INVALID) + CU_FAIL_FATAL("Queue create failed"); + + period_ns = 4 * tparam.min_tmo; + period_tick = odp_timer_ns_to_tick(tp, period_ns); + test_period = num * period_ns; + + LOG_DBG(" period_ns %" PRIu64 "\n", period_ns); + LOG_DBG(" period_tick %" PRIu64 "\n\n", period_tick); + + tick_base = odp_timer_current_tick(tp); + t0 = odp_time_local(); + t1 = t0; + t2 = t0; + + for (i = 0; i < num; i++) { + tmo = odp_timeout_alloc(pool); + CU_ASSERT_FATAL(tmo != ODP_TIMEOUT_INVALID); + ev = odp_timeout_to_event(tmo); + CU_ASSERT_FATAL(ev != ODP_EVENT_INVALID); + + tim = odp_timer_alloc(tp, queue, USER_PTR); + CU_ASSERT_FATAL(tim != ODP_TIMER_INVALID); + + tick = tick_base + ((i + 1) * period_tick); + ret = odp_timer_set_abs(tim, tick, &ev); + + LOG_DBG("abs timer tick %" PRIu64 "\n", tick); + if (ret == ODP_TIMER_TOOEARLY) + LOG_DBG("Too early %" PRIu64 "\n", tick); + else if (ret == ODP_TIMER_TOOLATE) + LOG_DBG("Too late %" PRIu64 "\n", tick); + else if (ret == ODP_TIMER_NOEVENT) + LOG_DBG("No event %" PRIu64 "\n", tick); + + CU_ASSERT(ret == ODP_TIMER_SUCCESS); + } + + num_tmo = 0; + + do { + if (queue_type == ODP_QUEUE_TYPE_SCHED) + ev = odp_schedule(NULL, ODP_SCHED_NO_WAIT); + else + ev = odp_queue_deq(queue); + + t2 = odp_time_local(); + diff_test = odp_time_diff_ns(t2, t0); + + if (ev != ODP_EVENT_INVALID) { + diff_period = odp_time_diff_ns(t2, t1); + t1 = odp_time_local(); + tmo = odp_timeout_from_event(ev); + tim = odp_timeout_timer(tmo); + tick = odp_timeout_tick(tmo); + + CU_ASSERT(diff_period > (period_ns - (2 * res_ns))); + CU_ASSERT(diff_period < (period_ns + (2 * res_ns))); + + LOG_DBG("timeout tick %" PRIu64 "\n", tick); + + odp_timeout_free(tmo); + CU_ASSERT(odp_timer_free(tim) == ODP_EVENT_INVALID); + + num_tmo++; + } + + } while (diff_test < (2 * test_period) && num_tmo < num); + + CU_ASSERT(num_tmo == num); + CU_ASSERT(diff_test > (test_period - tparam.min_tmo)); + CU_ASSERT(diff_test < (test_period + tparam.min_tmo)); + + /* Scalable scheduler needs this pause sequence. Otherwise, it gets + * stuck on terminate. */ + if (queue_type == ODP_QUEUE_TYPE_SCHED) { + odp_schedule_pause(); + while (1) { + ev = odp_schedule(NULL, ODP_SCHED_NO_WAIT); + if (ev == ODP_EVENT_INVALID) + break; + + CU_FAIL("Drop extra event\n"); + odp_event_free(ev); + } + } + + odp_timer_pool_destroy(tp); + + CU_ASSERT(odp_queue_destroy(queue) == 0); + CU_ASSERT(odp_pool_destroy(pool) == 0); +} + +static void timer_test_plain_queue(void) +{ + timer_test_queue_type(ODP_QUEUE_TYPE_PLAIN); +} + +static void timer_test_sched_queue(void) +{ + timer_test_queue_type(ODP_QUEUE_TYPE_SCHED); +} + static void timer_test_odp_timer_cancel(void) { odp_pool_t pool; @@ -642,6 +806,8 @@ static void timer_test_odp_timer_all(void) odp_testinfo_t timer_suite[] = { ODP_TEST_INFO(timer_test_timeout_pool_alloc), ODP_TEST_INFO(timer_test_timeout_pool_free), + ODP_TEST_INFO(timer_test_plain_queue), + ODP_TEST_INFO(timer_test_sched_queue), ODP_TEST_INFO(timer_test_odp_timer_cancel), ODP_TEST_INFO(timer_test_odp_timer_all), ODP_TEST_INFO_NULL, commit 5d4be5077adeec54d1956c86dcb87b186c39a7cb Author: Petri Savolainen <petri.savolainen(a)linaro.org> Date: Thu Apr 19 13:03:29 2018 +0300 validation: timer: don't assume low timer tick frequency Timer tick can be the same as CPU frequency. So, test cannot loop until two current_tick calls return the same tick value. Similarly, test cannot assume that expiration tick of a relative timeout call can be exactly calculated from a current_tick value. Signed-off-by: Petri Savolainen <petri.savolainen(a)linaro.org> Reviewed-by: Bill Fischofer <bill.fischofer(a)linaro.org> Signed-off-by: Maxim Uvarov <maxim.uvarov(a)linaro.org> diff --git a/test/validation/api/timer/timer.c b/test/validation/api/timer/timer.c index 9cbb08bb..bd4f1b99 100644 --- a/test/validation/api/timer/timer.c +++ b/test/validation/api/timer/timer.c @@ -291,19 +291,17 @@ static void handle_tmo(odp_event_t ev, bool stale, uint64_t prev_tick) CU_FAIL("Wrong status (stale) for fresh timeout"); if (!stale) { - /* Fresh timeout => local timer must have matching tick */ - if (ttp->tick != tick) { - LOG_DBG("Wrong tick: expected %" PRIu64 - " actual %" PRIu64 "\n", + /* tmo tick cannot be smaller than pre-calculated tick */ + if (tick < ttp->tick) { + LOG_DBG("Too small tick: pre-calculated %" PRIu64 + " timeout %" PRIu64 "\n", ttp->tick, tick); - CU_FAIL("odp_timeout_tick() wrong tick"); + CU_FAIL("odp_timeout_tick() too small tick"); } - if (ttp->ev != ODP_EVENT_INVALID) - CU_FAIL("Wrong state for fresh timer (event)"); - /* Check that timeout was delivered 'timely' */ if (tick > odp_timer_current_tick(tp)) CU_FAIL("Timeout delivered early"); + if (tick < prev_tick) { LOG_DBG("Too late tick: %" PRIu64 " prev_tick %" PRIu64"\n", @@ -421,23 +419,23 @@ static int worker_entrypoint(void *arg TEST_UNUSED) ncancel++; } } else { + odp_timer_set_t rc; + uint64_t cur_tick; + uint64_t tck, nsec; + if (tt[i].ev != ODP_EVENT_INVALID) /* Timer inactive => set */ nset++; else /* Timer active => reset */ nreset++; - uint64_t tck = 1 + odp_timer_ns_to_tick(tp, - (rand_r(&seed) % RANGE_MS) * 1000000ULL); - odp_timer_set_t rc; - uint64_t cur_tick; - /* Loop until we manage to read cur_tick and set a - * relative timer in the same tick */ - do { - cur_tick = odp_timer_current_tick(tp); - rc = odp_timer_set_rel(tt[i].tim, - tck, &tt[i].ev); - } while (cur_tick != odp_timer_current_tick(tp)); + + nsec = (rand_r(&seed) % RANGE_MS) * 1000000ULL; + tck = 1 + odp_timer_ns_to_tick(tp, nsec); + + cur_tick = odp_timer_current_tick(tp); + rc = odp_timer_set_rel(tt[i].tim, tck, &tt[i].ev); + if (rc == ODP_TIMER_TOOEARLY || rc == ODP_TIMER_TOOLATE) { CU_FAIL("Failed to set timer (tooearly/toolate)"); commit 3aa3f4352083d159260cebc23b87607e73aa6f2b Author: Petri Savolainen <petri.savolainen(a)linaro.org> Date: Thu Apr 19 11:08:14 2018 +0300 validation: timer: tick conversion may lose precision Tick <-> nsec conversion may include rounding and thus loss of precision. For example, when tick frequency is higher than 1GHz conversion to nsec lose precision by definition. Modified test to convert nsec -> tick -> nsec and allow resolution level diffrence between nsec values. Signed-off-by: Petri Savolainen <petri.savolainen(a)linaro.org> Reviewed-by: Bill Fischofer <bill.fischofer(a)linaro.org> Signed-off-by: Maxim Uvarov <maxim.uvarov(a)linaro.org> diff --git a/test/validation/api/timer/timer.c b/test/validation/api/timer/timer.c index 6d4d3ecd..9cbb08bb 100644 --- a/test/validation/api/timer/timer.c +++ b/test/validation/api/timer/timer.c @@ -25,6 +25,13 @@ /* Number of timers per thread */ #define NTIMERS 2000 +#define NAME "timer_pool" +#define RES (10 * ODP_TIME_MSEC_IN_NS / 3) +#define MIN_TMO (10 * ODP_TIME_MSEC_IN_NS / 3) +#define MAX_TMO (1000000 * ODP_TIME_MSEC_IN_NS) +#define USER_PTR ((void *)0xdead) +#define TICK_INVALID (~(uint64_t)0) + /* Barrier for thread synchronisation */ static odp_barrier_t test_barrier; @@ -41,6 +48,9 @@ static odp_atomic_u32_t ndelivtoolate; * caches may make this number lower than the capacity of the pool */ static odp_atomic_u32_t timers_allocated; +/* Timer resolution in nsec */ +static uint64_t resolution_ns; + /* Timer helper structure */ struct test_timer { odp_timer_t tim; /* Timer handle */ @@ -49,8 +59,6 @@ struct test_timer { uint64_t tick; /* Expiration tick or TICK_INVALID */ }; -#define TICK_INVALID (~(uint64_t)0) - static void timer_test_timeout_pool_alloc(void) { odp_pool_t pool; @@ -180,7 +188,6 @@ static void timer_test_odp_timer_cancel(void) if (queue == ODP_QUEUE_INVALID) CU_FAIL_FATAL("Queue create failed"); - #define USER_PTR ((void *)0xdead) tim = odp_timer_alloc(tp, queue, USER_PTR); if (tim == ODP_TIMER_INVALID) CU_FAIL_FATAL("Failed to allocate timer"); @@ -518,9 +525,7 @@ static void timer_test_odp_timer_all(void) odp_timer_pool_param_t tparam; odp_cpumask_t unused; odp_timer_pool_info_t tpinfo; - uint64_t tick; - uint64_t ns; - uint64_t t2; + uint64_t ns, tick, ns2; pthrd_arg thrdarg; odp_timer_capability_t timer_capa; @@ -546,15 +551,12 @@ static void timer_test_odp_timer_all(void) if (tbp == ODP_POOL_INVALID) CU_FAIL_FATAL("Timeout pool create failed"); -#define NAME "timer_pool" -#define RES (10 * ODP_TIME_MSEC_IN_NS / 3) -#define MIN_TMO (10 * ODP_TIME_MSEC_IN_NS / 3) -#define MAX_TMO (1000000 * ODP_TIME_MSEC_IN_NS) /* Create a timer pool */ if (odp_timer_capability(ODP_CLOCK_CPU, &timer_capa)) CU_FAIL("Error: get timer capacity failed.\n"); - tparam.res_ns = MAX(RES, timer_capa.highest_res_ns); + resolution_ns = MAX(RES, timer_capa.highest_res_ns); + tparam.res_ns = resolution_ns; tparam.min_tmo = MIN_TMO; tparam.max_tmo = MAX_TMO; tparam.num_timers = num_workers * NTIMERS; @@ -581,11 +583,26 @@ static void timer_test_odp_timer_all(void) LOG_DBG("Tmo range: %u ms (%" PRIu64 " ticks)\n", RANGE_MS, odp_timer_ns_to_tick(tp, 1000000ULL * RANGE_MS)); - for (tick = 0; tick < 1000000000000ULL; tick += 1000000ULL) { - ns = odp_timer_tick_to_ns(tp, tick); - t2 = odp_timer_ns_to_tick(tp, ns); - if (tick != t2) - CU_FAIL("Invalid conversion tick->ns->tick"); + tick = odp_timer_ns_to_tick(tp, 0); + CU_ASSERT(tick == 0); + ns2 = odp_timer_tick_to_ns(tp, tick); + CU_ASSERT(ns2 == 0); + + for (ns = resolution_ns; ns < MAX_TMO; ns += resolution_ns) { + tick = odp_timer_ns_to_tick(tp, ns); + ns2 = odp_timer_tick_to_ns(tp, tick); + + if (ns2 < ns - resolution_ns) { + LOG_DBG("FAIL ns:%" PRIu64 " tick:%" PRIu64 " ns2:%" + PRIu64 "\n", ns, tick, ns2); + CU_FAIL("tick conversion: nsec too small\n"); + } + + if (ns2 > ns + resolution_ns) { + LOG_DBG("FAIL ns:%" PRIu64 " tick:%" PRIu64 " ns2:%" + PRIu64 "\n", ns, tick, ns2); + CU_FAIL("tick conversion: nsec too large\n"); + } } /* Initialize barrier used by worker threads for synchronization */ commit 0d4271e31fe685a8a82381d21d5166f0398080c1 Author: Petri Savolainen <petri.savolainen(a)linaro.org> Date: Thu Apr 19 10:17:39 2018 +0300 validation: timer: check user pointer once Code clean up: check only once that user pointer is not NULL. Signed-off-by: Petri Savolainen <petri.savolainen(a)linaro.org> Reviewed-by: Bill Fischofer <bill.fischofer(a)linaro.org> Signed-off-by: Maxim Uvarov <maxim.uvarov(a)linaro.org> diff --git a/test/validation/api/timer/timer.c b/test/validation/api/timer/timer.c index 06148de8..6d4d3ecd 100644 --- a/test/validation/api/timer/timer.c +++ b/test/validation/api/timer/timer.c @@ -233,6 +233,10 @@ static void timer_test_odp_timer_cancel(void) static void handle_tmo(odp_event_t ev, bool stale, uint64_t prev_tick) { odp_event_subtype_t subtype; + odp_timeout_t tmo; + odp_timer_t tim; + uint64_t tick; + struct test_timer *ttp; CU_ASSERT_FATAL(ev != ODP_EVENT_INVALID); /* Internal error */ if (odp_event_type(ev) != ODP_EVENT_TIMEOUT) { @@ -255,33 +259,39 @@ static void handle_tmo(odp_event_t ev, bool stale, uint64_t prev_tick) CU_FAIL("Unexpected event subtype received"); return; } + /* Read the metadata from the timeout */ - odp_timeout_t tmo = odp_timeout_from_event(ev); - odp_timer_t tim = odp_timeout_timer(tmo); - uint64_t tick = odp_timeout_tick(tmo); - struct test_timer *ttp = odp_timeout_user_ptr(tmo); + tmo = odp_timeout_from_event(ev); + tim = odp_timeout_timer(tmo); + tick = odp_timeout_tick(tmo); + ttp = odp_timeout_user_ptr(tmo); if (tim == ODP_TIMER_INVALID) CU_FAIL("odp_timeout_timer() invalid timer"); - if (!ttp) + + if (ttp == NULL) { CU_FAIL("odp_timeout_user_ptr() null user ptr"); + return; + } - if (ttp && ttp->ev2 != ev) + if (ttp->ev2 != ev) CU_FAIL("odp_timeout_user_ptr() wrong user ptr"); - if (ttp && ttp->tim != tim) + + if (ttp->tim != tim) CU_FAIL("odp_timeout_timer() wrong timer"); if (!odp_timeout_fresh(tmo)) CU_FAIL("Wrong status (stale) for fresh timeout"); + if (!stale) { /* Fresh timeout => local timer must have matching tick */ - if (ttp && ttp->tick != tick) { + if (ttp->tick != tick) { LOG_DBG("Wrong tick: expected %" PRIu64 " actual %" PRIu64 "\n", ttp->tick, tick); CU_FAIL("odp_timeout_tick() wrong tick"); } - if (ttp && ttp->ev != ODP_EVENT_INVALID) + if (ttp->ev != ODP_EVENT_INVALID) CU_FAIL("Wrong state for fresh timer (event)"); /* Check that timeout was delivered 'timely' */ @@ -296,11 +306,9 @@ static void handle_tmo(odp_event_t ev, bool stale, uint64_t prev_tick) } } - if (ttp) { - /* Internal error */ - CU_ASSERT_FATAL(ttp->ev == ODP_EVENT_INVALID); - ttp->ev = ev; - } + /* Internal error */ + CU_ASSERT_FATAL(ttp->ev == ODP_EVENT_INVALID); + ttp->ev = ev; } /* Worker thread entrypoint which performs timer alloc/set/cancel/free commit d324b9de12c510ccf9fa1c1b6ece327c578ee53d Author: Petri Savolainen <petri.savolainen(a)linaro.org> Date: Thu Apr 19 09:57:42 2018 +0300 validation: timer: remove doxygen tags Doxygen documentation is not generated from validation test files. Remove partial and unnecessary doxygen tags. Signed-off-by: Petri Savolainen <petri.savolainen(a)linaro.org> Reviewed-by: Bill Fischofer <bill.fischofer(a)linaro.org> Signed-off-by: Maxim Uvarov <maxim.uvarov(a)linaro.org> diff --git a/test/validation/api/timer/timer.c b/test/validation/api/timer/timer.c index 1cd32cb1..06148de8 100644 --- a/test/validation/api/timer/timer.c +++ b/test/validation/api/timer/timer.c @@ -6,10 +6,6 @@ #include "config.h" -/** - * @file - */ - /* For rand_r and nanosleep */ #ifndef _GNU_SOURCE #define _GNU_SOURCE @@ -23,29 +19,29 @@ #define MAX(a, b) (((a) > (b)) ? (a) : (b)) -/** @private Timeout range in milliseconds (ms) */ +/* Timeout range in milliseconds (ms) */ #define RANGE_MS 2000 -/** @private Number of timers per thread */ +/* Number of timers per thread */ #define NTIMERS 2000 -/** @private Barrier for thread synchronisation */ +/* Barrier for thread synchronisation */ static odp_barrier_t test_barrier; -/** @private Timeout pool handle used by all threads */ +/* Timeout pool handle used by all threads */ static odp_pool_t tbp; -/** @private Timer pool handle used by all threads */ +/* Timer pool handle used by all threads */ static odp_timer_pool_t tp; -/** @private Count of timeouts delivered too late */ +/* Count of timeouts delivered too late */ static odp_atomic_u32_t ndelivtoolate; -/** @private Sum of all allocated timers from all threads. Thread-local +/* Sum of all allocated timers from all threads. Thread-local * caches may make this number lower than the capacity of the pool */ static odp_atomic_u32_t timers_allocated; -/* @private Timer helper structure */ +/* Timer helper structure */ struct test_timer { odp_timer_t tim; /* Timer handle */ odp_event_t ev; /* Timeout event */ @@ -233,7 +229,7 @@ static void timer_test_odp_timer_cancel(void) CU_FAIL_FATAL("Failed to destroy pool"); } -/* @private Handle a received (timeout) event */ +/* Handle a received (timeout) event */ static void handle_tmo(odp_event_t ev, bool stale, uint64_t prev_tick) { odp_event_subtype_t subtype; @@ -307,7 +303,7 @@ static void handle_tmo(odp_event_t ev, bool stale, uint64_t prev_tick) } } -/* @private Worker thread entrypoint which performs timer alloc/set/cancel/free +/* Worker thread entrypoint which performs timer alloc/set/cancel/free * tests */ static int worker_entrypoint(void *arg TEST_UNUSED) { @@ -506,7 +502,7 @@ static int worker_entrypoint(void *arg TEST_UNUSED) return CU_get_number_of_failures(); } -/* @private Timer test case entrypoint */ +/* Timer test case entrypoint */ static void timer_test_odp_timer_all(void) { int rc; ----------------------------------------------------------------------- Summary of changes: platform/linux-generic/Makefile.am | 1 + platform/linux-generic/odp_crypto.c | 42 ----- platform/linux-generic/odp_random.c | 54 ++++++ test/validation/api/timer/timer.c | 336 ++++++++++++++++++++++++++++-------- 4 files changed, 320 insertions(+), 113 deletions(-) create mode 100644 platform/linux-generic/odp_random.c hooks/post-receive --

6 years

1
0
0 0

[COMMIT] annotated tag v1.19.0.0_tigermoth created. v1.19.0.0_tigermoth

by git＠git-us.linaro.org

This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "". The annotated tag, v1.19.0.0_tigermoth has been created at fea17c996d047d2f2d0c1de06d7d10613ab9763d (tag) tagging e828b4d6f503ff94c40e30b1d8babf0dcbecde91 (commit) replaces v1.18.0.1_tigermoth_rc3 tagged by Maxim Uvarov on Thu Apr 19 18:01:15 2018 +0300 - Log ----------------------------------------------------------------- Tiger Moth LTS Bill Fischofer (9): doc: userguide: typo corrections doc: userguide: change pool queue to plain queue doc: userguide: shm corrections doc: userguide: change sched type none to parallel doc: userguide: refresh pktio code examples doc: userguide: add packet checksum and parsing info doc: userguide: add pktio capability and config info example: l2fwd: update readme regarding ordered queue usage changelog: updates for odp v1.19.0.0 Bogdan Pricope (3): linux-gen: pktio: dpdk: accept UDPv4 packets with all-zero csum linux-gen: pktio: dpdk: fix IPv4 csum calculation when l4 offset is not set linux-gen: dpdk: fix runtime/default config read order Dmitry Eremin-Solenikov (20): performance: fix sched_latency test with huge cpu count shippable: reenable non-ABI-compat build for GCC test: misc: use C++ I/O instead of C tests: add IPsec performance test performance: ipsec: add AH measurements performance: ipsec: add more algorithms performance: crypto: add more algorithms linux-gen: crypto: add IV length checks linux-gen: ipsec: add proper support for AES-CCM build: move odp scheduler setting to common m4 file build: another DPDK-linking fix build: don't use xxd to hexdump config file build: fix autoconf error caused by double-registering config item linux-gen: packet: IPv4 checksum insertion linux-gen: packet: l4 checksum insertion support linux-gen: pktio: loop: support IPv4/TCP/UDP checksum generation validation: verify IPv4 and UDP checksum validation and generation validation: ipsec: fix packet checksums linux-gen: ipsec: implement outbound checksumming support validation: ipsec: validate outbound checksumming support Josep Puigdemont (8): fdserver: handle interruption by signal in accept linux-gen: shm: fill data used in do_map before the call linux-gen: shm: do not close provided file descriptors linux-gen: shm: be consistent with rest of the code fdserver: change session ID after fork linux-gen: fdserver: mask signals we don't need linux-gen: shm: check return value when registering fds fdserver: handle signal interruption in connect() Juha-Matti Tilli (1): linux-gen: netmap: ring configuration for VALE Matias Elo (2): linux-gen: dpdk: bump supported dpdk version to v17.11 linux-gen: dpdk: allocate huge page memory for all numa nodes Maxim Uvarov (9): shippable: simplify test execution add odp_ipsec to .gitignore linux-gen: clean up ishm file naming linux-gen: hide debug prints from fd server linux-gen: ishm: remove useless debug print travis: use -M option for generated patches linux-gen: fix clang on aarch64 build shippable: reenable clang with disable abi compat options configure.ac: update version to v1.19.0.0 Petri Savolainen (11): linux-gen: queue: configurable default size linux-gen: queue: configurable max size linux-gen: sched: configurable priority spread linux-gen: sched: decouple spread and group table sizes linux-gen: sched: increase max spread linux-gen: pktio: add error prints linux-gen: pktio: add index to pktio print test: sched_pktio: new scheduler performance test with pktio test: sched_pktio: add option to collect statistics test: sched_pktio: run in validation test suite api: packet: UDP checksum value of zero yhe (2): linux-gen:crypto:implement AES-XCBC-MAC and SHA384-HMAC validation:crypto:implement AES-XCBC-MAC and SHA384-HMAC ----------------------------------------------------------------------- hooks/post-receive --

6 years

1
0
0 0

[COMMIT] branch tigermoth_lts created. v1.19.0.0_tigermoth

by git＠git-us.linaro.org

This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "". The branch, tigermoth_lts has been created at e828b4d6f503ff94c40e30b1d8babf0dcbecde91 (commit) - Log ----------------------------------------------------------------- ----------------------------------------------------------------------- hooks/post-receive --

6 years

1
0
0 0

[COMMIT] branch master updated. v1.19.0.0

by git＠git-us.linaro.org

This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "". The branch, master has been updated via e828b4d6f503ff94c40e30b1d8babf0dcbecde91 (commit) from 1e0ac11c75eee10959d1fa674a05e746476271b3 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit e828b4d6f503ff94c40e30b1d8babf0dcbecde91 Author: Maxim Uvarov <maxim.uvarov(a)linaro.org> Date: Wed Apr 18 17:50:47 2018 +0300 configure.ac: update version to v1.19.0.0 Signed-off-by: Maxim Uvarov <maxim.uvarov(a)linaro.org> Reviewed-by: Bill Fischofer <bill.fischofer(a)linaro.org> Reviewed-by: Dmitry Eremin-Solenikov <dmitry.ereminsolenikov(a)linaro.org> diff --git a/configure.ac b/configure.ac index 904e8197..d3f02665 100644 --- a/configure.ac +++ b/configure.ac @@ -3,9 +3,9 @@ AC_PREREQ([2.5]) # Set correct API version ########################################################################## m4_define([odpapi_generation_version], [1]) -m4_define([odpapi_major_version], [18]) +m4_define([odpapi_major_version], [19]) m4_define([odpapi_minor_version], [0]) -m4_define([odpapi_point_version], [1]) +m4_define([odpapi_point_version], [0]) m4_define([odpapi_version], [odpapi_generation_version.odpapi_major_version.odpapi_minor_version.odpapi_point_version]) AC_INIT([OpenDataPlane],[odpapi_version],[lng-odp(a)lists.linaro.org]) ----------------------------------------------------------------------- Summary of changes: configure.ac | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) hooks/post-receive --

6 years

1
0
0 0

[COMMIT] annotated tag v1.19.0.0 created. v1.19.0.0

by git＠git-us.linaro.org

This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "". The annotated tag, v1.19.0.0 has been created at 200122ffa31e4cf5367edb528138d277a1f5da1e (tag) tagging e828b4d6f503ff94c40e30b1d8babf0dcbecde91 (commit) replaces v1.18.0.1_tigermoth_rc3 tagged by Maxim Uvarov on Thu Apr 19 17:56:01 2018 +0300 - Log ----------------------------------------------------------------- == OpenDataPlane (1.19.0.0) === Summary of Changes ODP v1.19.0.0 is the official Tiger Moth final release. It incorporates final implementation changes and bug fixes and completes the Tiger Moth ODP development cycle. ==== APIs No functional changes for this release. The Tiger Moth API was frozen in ODP v1.18.0.0. ===== API Documentation Update The specification for the `odp_packet_l4_chksum_status()` API has been clarified to reflect that in IPv4 UDP checksums are optional. As a result, a zero (nonexistent) checksum will be reported as `ODP_PACKET_CHKSUM_OK`. ==== C++ Test Improvements The {cpp} test included in the ODP validation suite now uses `cout` instead of `printf()` to ensure that {cpp} is being used to compile it. ==== Queue and Scheduler Configuration For the ODP Reference Implementation, The `config/odp-linux-generic.conf` file is extended with sections to control the default and maximum sizes for basic queues, and the priority spread used by the scheduler for scheduled queues. The configuration file is a template named `platform/odp-$platform.conf` so this can be easily inherited by other ODP implementations. ==== Runtime Default `config` File Read Order Improvements For the ODP Reference Implementation, the default values of the application-provided `config` file (if used) override the values provided by the built-in `config/odp-linux-generic.conf` file. === Implementation Improvements The `odp-linux` reference implementation is improved in a number of areas: ==== Netmap Ring Configuration for VALE PktIO netmap support now uses the ODP config file to allow rings used for VALE processing to be specified. The supplied defaults provide optimal performance in typical settings. ==== AES-XCBC-MAC and SHA384-HMAC These crypto/authentication algorithms are now implemented. ==== Packet Checksum Validation and Insertion Proper packet checksum validation and insertion, in conformance with the relevant ODP APIs, is now provided. === Dependency Changes ==== DPDK 17.11 Support The Tiger Moth LTS release is synchronized with the most recent DPDK LTS release for DPDK pktio support. ==== Removal of dependency on `xxd` package. This dependency is removed. The Reference Implementation build tools now use the standard `od` tool rather than the optional `xxd` package. === Performance Tests ==== `odp_sched_pktio` A new test has been added to test the performance of PktIO operations in scheduled mode. Scheduled PktIO is inherently more scalable and simpler from an application standpoint than direct (polled) I/O, but depending on the efficiency of the scheduler implementation can incur additional levels of overhead. This test can give insight into a given platform's scheduler efficiency. For the `odp-linux` reference implementation, this test has shown scheduled I/O to be within 10% of rates achievable via direct I/O, meaning that for many applications the simplicity and scalability of the event model is preferable. ==== `odp_ipsec` A new test has been added that measures outbound (TX) IPsec performance with a variety of cipher and authentication algorithms. === Example Changes ==== `l2fwd` Example The `README` file associated with this example has been clarified to explain that this example is a throughput test and as a result does not preserve packet order under all conditions. === Bug Fixes ==== https://bugs.linaro.org/show_bug.cgi?id=3611[Bug 3611] ODP linux-generic fails on AArch64 in non-ABI-compat mode. ==== https://bugs.linaro.org/show_bug.cgi?id=3657[Bug 3657] PktIO does not work with Mellanox Interfaces ==== https://bugs.linaro.org/show_bug.cgi?id=3685[Bug 3685] RX UDP checksum offload drops valid UDP packets with Niantic ==== https://bugs.linaro.org/show_bug.cgi?id=3686[Bug 3686] IP header checksum not inserted if L4 offset not set ==== https://bugs.linaro.org/show_bug.cgi?id=3690[Bug 3690] fdserver process interferes with signal handling ==== https://bugs.linaro.org/show_bug.cgi?id=3736[Bug 3736] return value not checked for some fdserver interface functions === Known Issues ==== https://bugs.linaro.org/show_bug.cgi?id=2988[Bug 2988] ODP exposes symbols outside of odp*/_odp* namespace Bill Fischofer (9): doc: userguide: typo corrections doc: userguide: change pool queue to plain queue doc: userguide: shm corrections doc: userguide: change sched type none to parallel doc: userguide: refresh pktio code examples doc: userguide: add packet checksum and parsing info doc: userguide: add pktio capability and config info example: l2fwd: update readme regarding ordered queue usage changelog: updates for odp v1.19.0.0 Bogdan Pricope (3): linux-gen: pktio: dpdk: accept UDPv4 packets with all-zero csum linux-gen: pktio: dpdk: fix IPv4 csum calculation when l4 offset is not set linux-gen: dpdk: fix runtime/default config read order Dmitry Eremin-Solenikov (20): performance: fix sched_latency test with huge cpu count shippable: reenable non-ABI-compat build for GCC test: misc: use C++ I/O instead of C tests: add IPsec performance test performance: ipsec: add AH measurements performance: ipsec: add more algorithms performance: crypto: add more algorithms linux-gen: crypto: add IV length checks linux-gen: ipsec: add proper support for AES-CCM build: move odp scheduler setting to common m4 file build: another DPDK-linking fix build: don't use xxd to hexdump config file build: fix autoconf error caused by double-registering config item linux-gen: packet: IPv4 checksum insertion linux-gen: packet: l4 checksum insertion support linux-gen: pktio: loop: support IPv4/TCP/UDP checksum generation validation: verify IPv4 and UDP checksum validation and generation validation: ipsec: fix packet checksums linux-gen: ipsec: implement outbound checksumming support validation: ipsec: validate outbound checksumming support Josep Puigdemont (8): fdserver: handle interruption by signal in accept linux-gen: shm: fill data used in do_map before the call linux-gen: shm: do not close provided file descriptors linux-gen: shm: be consistent with rest of the code fdserver: change session ID after fork linux-gen: fdserver: mask signals we don't need linux-gen: shm: check return value when registering fds fdserver: handle signal interruption in connect() Juha-Matti Tilli (1): linux-gen: netmap: ring configuration for VALE Matias Elo (2): linux-gen: dpdk: bump supported dpdk version to v17.11 linux-gen: dpdk: allocate huge page memory for all numa nodes Maxim Uvarov (9): shippable: simplify test execution add odp_ipsec to .gitignore linux-gen: clean up ishm file naming linux-gen: hide debug prints from fd server linux-gen: ishm: remove useless debug print travis: use -M option for generated patches linux-gen: fix clang on aarch64 build shippable: reenable clang with disable abi compat options configure.ac: update version to v1.19.0.0 Petri Savolainen (11): linux-gen: queue: configurable default size linux-gen: queue: configurable max size linux-gen: sched: configurable priority spread linux-gen: sched: decouple spread and group table sizes linux-gen: sched: increase max spread linux-gen: pktio: add error prints linux-gen: pktio: add index to pktio print test: sched_pktio: new scheduler performance test with pktio test: sched_pktio: add option to collect statistics test: sched_pktio: run in validation test suite api: packet: UDP checksum value of zero yhe (2): linux-gen:crypto:implement AES-XCBC-MAC and SHA384-HMAC validation:crypto:implement AES-XCBC-MAC and SHA384-HMAC ----------------------------------------------------------------------- hooks/post-receive --

6 years

1
0
0 0

[COMMIT] branch master updated. v1.18.0.1_tigermoth_rc3-64-g1e0ac11c

by git＠git-us.linaro.org

This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "". The branch, master has been updated via 1e0ac11c75eee10959d1fa674a05e746476271b3 (commit) from 8caae505c35444706cff8815c41821d80e791403 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 1e0ac11c75eee10959d1fa674a05e746476271b3 Author: Bill Fischofer <bill.fischofer(a)linaro.org> Date: Sun Apr 8 20:30:18 2018 -0500 changelog: updates for odp v1.19.0.0 Add updates for ODP v1.19.0.0 (Tiger Moth Final Release) Signed-off-by: Bill Fischofer <bill.fischofer(a)linaro.org> Reviewed-by: Bogdan Pricope <bogdan.pricope(a)linaro.org> Reviewed-by: Dmitry Eremin-Solenikov <dmitry.ereminsolenikov(a)linaro.org> Signed-off-by: Maxim Uvarov <maxim.uvarov(a)linaro.org> diff --git a/CHANGELOG b/CHANGELOG index 1dfdd0e7..5af1777c 100644 --- a/CHANGELOG +++ b/CHANGELOG @@ -1,3 +1,108 @@ +== OpenDataPlane (1.19.0.0) +=== Summary of Changes +ODP v1.19.0.0 is the official Tiger Moth final release. It incorporates final +implementation changes and bug fixes and completes the Tiger Moth ODP +development cycle. + +==== APIs +No functional changes for this release. The Tiger Moth API was frozen in ODP +v1.18.0.0. + +===== API Documentation Update +The specification for the `odp_packet_l4_chksum_status()` API has been +clarified to reflect that in IPv4 UDP checksums are optional. As a result, a +zero (nonexistent) checksum will be reported as `ODP_PACKET_CHKSUM_OK`. + +==== C++ Test Improvements +The {cpp} test included in the ODP validation suite now uses `cout` instead +of `printf()` to ensure that {cpp} is being used to compile it. + +==== Queue and Scheduler Configuration +For the ODP Reference Implementation, The `config/odp-linux-generic.conf` file +is extended with sections to control the default and maximum sizes for basic +queues, and the priority spread used by the scheduler for scheduled queues. + +The configuration file is a template named `platform/odp-$platform.conf` so +this can be easily inherited by other ODP implementations. + +==== Runtime Default `config` File Read Order Improvements +For the ODP Reference Implementation, the default values of the +application-provided `config` file (if used) override the values provided by +the built-in `config/odp-linux-generic.conf` file. + +=== Implementation Improvements +The `odp-linux` reference implementation is improved in a number of areas: + +==== Netmap Ring Configuration for VALE +PktIO netmap support now uses the ODP config file to allow rings used for VALE +processing to be specified. The supplied defaults provide optimal performance +in typical settings. + +==== AES-XCBC-MAC and SHA384-HMAC +These crypto/authentication algorithms are now implemented. + +==== Packet Checksum Validation and Insertion +Proper packet checksum validation and insertion, in conformance with the +relevant ODP APIs, is now provided. + +=== Dependency Changes + +==== DPDK 17.11 Support +The Tiger Moth LTS release is synchronized with the most recent DPDK LTS +release for DPDK pktio support. + +==== Removal of dependency on `xxd` package. +This dependency is removed. The Reference Implementation build tools now use +the standard `od` tool rather than the optional `xxd` package. + +=== Performance Tests + +==== `odp_sched_pktio` +A new test has been added to test the performance of PktIO operations in +scheduled mode. Scheduled PktIO is inherently more scalable and simpler from +an application standpoint than direct (polled) I/O, but depending on the +efficiency of the scheduler implementation can incur additional levels of +overhead. This test can give insight into a given platform's scheduler +efficiency. For the `odp-linux` reference implementation, this test has shown +scheduled I/O to be within 10% of rates achievable via direct I/O, meaning +that for many applications the simplicity and scalability of the event model +is preferable. + +==== `odp_ipsec` +A new test has been added that measures outbound (TX) IPsec performance with +a variety of cipher and authentication algorithms. + +=== Example Changes + +==== `l2fwd` Example +The `README` file associated with this example has been clarified to explain +that this example is a throughput test and as a result does not preserve +packet order under all conditions. + +=== Bug Fixes +==== https://bugs.linaro.org/show_bug.cgi?id=3611[Bug 3611] +ODP linux-generic fails on AArch64 in non-ABI-compat mode. + +==== https://bugs.linaro.org/show_bug.cgi?id=3657[Bug 3657] +PktIO does not work with Mellanox Interfaces + +==== https://bugs.linaro.org/show_bug.cgi?id=3685[Bug 3685] +RX UDP checksum offload drops valid UDP packets with Niantic + +==== https://bugs.linaro.org/show_bug.cgi?id=3686[Bug 3686] +IP header checksum not inserted if L4 offset not set + +==== https://bugs.linaro.org/show_bug.cgi?id=3690[Bug 3690] +fdserver process interferes with signal handling + +==== https://bugs.linaro.org/show_bug.cgi?id=3736[Bug 3736] +return value not checked for some fdserver interface functions + +=== Known Issues + +==== https://bugs.linaro.org/show_bug.cgi?id=2988[Bug 2988] +ODP exposes symbols outside of odp*/_odp* namespace + == OpenDataPlane (1.18.0.1) === Summary of Changes ODP v1.18.0.1 is a fix level for Tiger Moth Release Candidate 2 (RC 2). ----------------------------------------------------------------------- Summary of changes: CHANGELOG | 105 ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++ 1 file changed, 105 insertions(+) hooks/post-receive --

6 years

1
0
0 0

[COMMIT] branch master updated. v1.18.0.1_tigermoth_rc3-63-g8caae505

by git＠git-us.linaro.org

This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "". The branch, master has been updated via 8caae505c35444706cff8815c41821d80e791403 (commit) via 4b6787c84e020c350a03ec47d12e1ef68ddb6300 (commit) via 4142652b8eb397963bec48610bdb9ab6599e65fb (commit) via 60777ba4309911df0780bd8de6d96524bc2ca03c (commit) via b2632ac253a3b9f5ba7a4174acf6abe295ec3550 (commit) via 79f5c103310c36dc213a552b9534f68ce8df1132 (commit) via 2c99a9dc1978c9178e711d264aaaca2bc4702352 (commit) from 88ba35773c76c871a222fe48a0dac05765c39936 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 8caae505c35444706cff8815c41821d80e791403 Author: Dmitry Eremin-Solenikov <dmitry.ereminsolenikov(a)linaro.org> Date: Wed Apr 11 17:29:19 2018 +0300 validation: ipsec: validate outbound checksumming support Signed-off-by: Dmitry Eremin-Solenikov <dmitry.ereminsolenikov(a)linaro.org> Reviewed-by: Bill Fischofer <bill.fischofer(a)linaro.org> Reviewed-by: Petri Savolainen <petri.savolainen(a)linaro.org> Signed-off-by: Maxim Uvarov <maxim.uvarov(a)linaro.org> diff --git a/test/validation/api/ipsec/ipsec.c b/test/validation/api/ipsec/ipsec.c index 91a66d0b..31a6f9b5 100644 --- a/test/validation/api/ipsec/ipsec.c +++ b/test/validation/api/ipsec/ipsec.c @@ -938,6 +938,7 @@ int ipsec_config(odp_instance_t ODP_UNUSED inst) odp_ipsec_config_init(&ipsec_config); ipsec_config.inbound_mode = suite_context.inbound_op_mode; ipsec_config.outbound_mode = suite_context.outbound_op_mode; + ipsec_config.outbound.all_chksum = ~0; ipsec_config.inbound.default_queue = suite_context.queue; ipsec_config.inbound.parse_level = ODP_PROTO_LAYER_ALL; ipsec_config.inbound.chksums.all_chksum = ~0; diff --git a/test/validation/api/ipsec/ipsec_test_out.c b/test/validation/api/ipsec/ipsec_test_out.c index 5089dfa7..59c631b5 100644 --- a/test/validation/api/ipsec/ipsec_test_out.c +++ b/test/validation/api/ipsec/ipsec_test_out.c @@ -1155,6 +1155,36 @@ static void test_out_dummy_esp_null_sha256_tun_ipv6(void) ipsec_sa_destroy(sa); } +static void test_out_ipv4_udp_esp_null_sha256(void) +{ + odp_ipsec_sa_param_t param; + odp_ipsec_sa_t sa; + + ipsec_sa_param_fill(&param, + false, false, 123, NULL, + ODP_CIPHER_ALG_NULL, NULL, + ODP_AUTH_ALG_SHA256_HMAC, &key_5a_256, + NULL); + + sa = odp_ipsec_sa_create(&param); + + CU_ASSERT_NOT_EQUAL_FATAL(ODP_IPSEC_SA_INVALID, sa); + + ipsec_test_part test = { + .pkt_in = &pkt_ipv4_udp, + .out_pkt = 1, + .out = { + { .status.warn.all = 0, + .status.error.all = 0, + .pkt_out = &pkt_ipv4_udp_esp_null_sha256 }, + }, + }; + + ipsec_check_out_one(&test, sa); + + ipsec_sa_destroy(sa); +} + static void ipsec_test_capability(void) { odp_ipsec_capability_t capa; @@ -1218,5 +1248,7 @@ odp_testinfo_t ipsec_out_suite[] = { ipsec_check_esp_null_sha256), ODP_TEST_INFO_CONDITIONAL(test_out_dummy_esp_null_sha256_tun_ipv6, ipsec_check_esp_null_sha256), + ODP_TEST_INFO_CONDITIONAL(test_out_ipv4_udp_esp_null_sha256, + ipsec_check_esp_null_sha256), ODP_TEST_INFO_NULL, }; diff --git a/test/validation/api/ipsec/test_vectors.h b/test/validation/api/ipsec/test_vectors.h index 0f133f01..289b8008 100644 --- a/test/validation/api/ipsec/test_vectors.h +++ b/test/validation/api/ipsec/test_vectors.h @@ -1883,4 +1883,63 @@ static const ipsec_test_packet pkt_test_nodata = { 0x0a, 0x0b, 0x0c, 0x0d, }, }; + +static const ipsec_test_packet pkt_ipv4_udp = { + .len = 76, + .l2_offset = 0, + .l3_offset = 14, + .l4_offset = 34, + .data = { + /* ETH - not a part of RFC, added for simplicity */ + 0xf1, 0xf1, 0xf1, 0xf1, 0xf1, 0xf1, + 0xf2, 0xf2, 0xf2, 0xf2, 0xf2, 0xf2, 0x08, 0x00, + + /* IP */ + 0x45, 0x00, 0x00, 0x3e, 0x69, 0x8f, 0x00, 0x00, + 0x80, 0x11, 0x00, 0x00, 0xc0, 0xa8, 0x01, 0x02, + 0xc0, 0xa8, 0x01, 0x01, + + /* UDP */ + 0x0a, 0x98, 0x00, 0x35, 0x00, 0x2a, 0x00, 0x00, + 0xb2, 0xd0, 0x01, 0x00, 0x00, 0x01, 0x00, 0x00, + 0x00, 0x00, 0x00, 0x00, 0x03, 0x73, 0x69, 0x70, + 0x09, 0x63, 0x79, 0x62, 0x65, 0x72, 0x63, 0x69, + 0x74, 0x79, 0x02, 0x64, 0x6b, 0x00, 0x00, 0x01, + 0x00, 0x01, + }, +}; + +static const ipsec_test_packet pkt_ipv4_udp_esp_null_sha256 = { + .len = 102, + .l2_offset = 0, + .l3_offset = 14, + .l4_offset = 34, + .data = { + /* ETH - not a part of RFC, added for simplicity */ + 0xf1, 0xf1, 0xf1, 0xf1, 0xf1, 0xf1, + 0xf2, 0xf2, 0xf2, 0xf2, 0xf2, 0xf2, 0x08, 0x00, + + /* IP */ + 0x45, 0x00, 0x00, 0x58, 0x69, 0x8f, 0x00, 0x00, + 0x80, 0x32, 0x4d, 0x91, 0xc0, 0xa8, 0x01, 0x02, + 0xc0, 0xa8, 0x01, 0x01, + + /* ESP */ + 0x00, 0x00, 0x00, 0x7b, 0x00, 0x00, 0x00, 0x01, + + /* UDP */ + 0x0a, 0x98, 0x00, 0x35, 0x00, 0x2a, 0x23, 0x43, + 0xb2, 0xd0, 0x01, 0x00, 0x00, 0x01, 0x00, 0x00, + 0x00, 0x00, 0x00, 0x00, 0x03, 0x73, 0x69, 0x70, + 0x09, 0x63, 0x79, 0x62, 0x65, 0x72, 0x63, 0x69, + 0x74, 0x79, 0x02, 0x64, 0x6b, 0x00, 0x00, 0x01, + 0x00, 0x01, + + /* ESP TRL */ + 0x00, 0x11, 0x2d, 0x4a, 0x06, 0x9f, 0x97, 0xcf, + 0xa3, 0x05, 0xea, 0x90, 0x7a, 0xf6, 0x6b, 0x0a, + 0x3f, 0xc7, + }, +}; + #endif commit 4b6787c84e020c350a03ec47d12e1ef68ddb6300 Author: Dmitry Eremin-Solenikov <dmitry.ereminsolenikov(a)linaro.org> Date: Wed Apr 11 17:28:46 2018 +0300 linux-gen: ipsec: implement outbound checksumming support Signed-off-by: Dmitry Eremin-Solenikov <dmitry.ereminsolenikov(a)linaro.org> Reviewed-by: Bill Fischofer <bill.fischofer(a)linaro.org> Reviewed-by: Petri Savolainen <petri.savolainen(a)linaro.org> Signed-off-by: Maxim Uvarov <maxim.uvarov(a)linaro.org> diff --git a/platform/linux-generic/odp_ipsec.c b/platform/linux-generic/odp_ipsec.c index 65f7361b..782cbf45 100644 --- a/platform/linux-generic/odp_ipsec.c +++ b/platform/linux-generic/odp_ipsec.c @@ -826,6 +826,7 @@ static int ipsec_out_tunnel_parse_ipv4(ipsec_state_t *state, state->out_tunnel.ip_tos = ipv4hdr->tos; state->out_tunnel.ip_df = _ODP_IPV4HDR_FLAGS_DONT_FRAG(flags); state->out_tunnel.ip_flabel = 0; + state->ip_next_hdr = ipv4hdr->proto; return 0; } @@ -1295,6 +1296,41 @@ static void ipsec_out_ah_post(ipsec_state_t *state, odp_packet_t pkt) } } +#define OL_TX_CHKSUM_PKT(_cfg, _proto, _ovr_set, _ovr) \ + (_proto && (_ovr_set ? _ovr : _cfg)) + +static void ipsec_out_checksums(odp_packet_t pkt, + ipsec_state_t *state) +{ + odp_bool_t ipv4_chksum_pkt, udp_chksum_pkt, tcp_chksum_pkt; + odp_packet_hdr_t *pkt_hdr = packet_hdr(pkt); + odp_ipsec_outbound_config_t outbound = ipsec_config.outbound; + + ipv4_chksum_pkt = OL_TX_CHKSUM_PKT(outbound.chksum.inner_ipv4, + state->is_ipv4, + pkt_hdr->p.flags.l3_chksum_set, + pkt_hdr->p.flags.l3_chksum); + udp_chksum_pkt = OL_TX_CHKSUM_PKT(outbound.chksum.inner_udp, + state->ip_next_hdr == + _ODP_IPPROTO_UDP, + pkt_hdr->p.flags.l4_chksum_set, + pkt_hdr->p.flags.l4_chksum); + tcp_chksum_pkt = OL_TX_CHKSUM_PKT(outbound.chksum.inner_tcp, + state->ip_next_hdr == + _ODP_IPPROTO_TCP, + pkt_hdr->p.flags.l4_chksum_set, + pkt_hdr->p.flags.l4_chksum); + + if (ipv4_chksum_pkt) + _odp_packet_ipv4_chksum_insert(pkt); + + if (tcp_chksum_pkt) + _odp_packet_tcp_chksum_insert(pkt); + + if (udp_chksum_pkt) + _odp_packet_udp_chksum_insert(pkt); +} + static ipsec_sa_t *ipsec_out_single(odp_packet_t pkt, odp_ipsec_sa_t sa, odp_packet_t *pkt_out, @@ -1354,6 +1390,9 @@ static ipsec_sa_t *ipsec_out_single(odp_packet_t pkt, if (state.ip_tot_len + state.ip_offset != odp_packet_len(pkt)) rc = -1; + + if (rc == 0) + ipsec_out_checksums(pkt, &state); } else { if (state.is_ipv4) rc = ipsec_out_tunnel_parse_ipv4(&state, ipsec_sa); @@ -1371,6 +1410,8 @@ static ipsec_sa_t *ipsec_out_single(odp_packet_t pkt, goto err; } + ipsec_out_checksums(pkt, &state); + if (ipsec_sa->tun_ipv4) rc = ipsec_out_tunnel_ipv4(&pkt, &state, ipsec_sa, opt->flag.ip_param ? commit 4142652b8eb397963bec48610bdb9ab6599e65fb Author: Dmitry Eremin-Solenikov <dmitry.ereminsolenikov(a)linaro.org> Date: Sat Jan 13 05:13:03 2018 +0300 validation: ipsec: fix packet checksums Signed-off-by: Dmitry Eremin-Solenikov <dmitry.ereminsolenikov(a)linaro.org> Reviewed-by: Bill Fischofer <bill.fischofer(a)linaro.org> Reviewed-by: Petri Savolainen <petri.savolainen(a)linaro.org> Signed-off-by: Maxim Uvarov <maxim.uvarov(a)linaro.org> diff --git a/test/validation/api/ipsec/ipsec.c b/test/validation/api/ipsec/ipsec.c index 7c82d85a..91a66d0b 100644 --- a/test/validation/api/ipsec/ipsec.c +++ b/test/validation/api/ipsec/ipsec.c @@ -940,6 +940,7 @@ int ipsec_config(odp_instance_t ODP_UNUSED inst) ipsec_config.outbound_mode = suite_context.outbound_op_mode; ipsec_config.inbound.default_queue = suite_context.queue; ipsec_config.inbound.parse_level = ODP_PROTO_LAYER_ALL; + ipsec_config.inbound.chksums.all_chksum = ~0; if (ODP_IPSEC_OK != odp_ipsec_config(&ipsec_config)) return -1; diff --git a/test/validation/api/ipsec/test_vectors.h b/test/validation/api/ipsec/test_vectors.h index 5b357a16..0f133f01 100644 --- a/test/validation/api/ipsec/test_vectors.h +++ b/test/validation/api/ipsec/test_vectors.h @@ -269,7 +269,7 @@ static const ODP_UNUSED ipsec_test_packet pkt_ipv4_icmp_0_ah_sha256_1_bad1 = { /* IP */ 0x45, 0x00, 0x00, 0x9a, 0x00, 0x00, 0x00, 0x00, - 0x40, 0x33, 0xab, 0xd9, 0xc0, 0xa8, 0x6f, 0x02, + 0x40, 0x33, 0xab, 0xdb, 0xc0, 0xa8, 0x6f, 0x02, 0xc0, 0xa8, 0xde, 0x02, /* AH */ @@ -669,7 +669,7 @@ static const ODP_UNUSED ipsec_test_packet pkt_ipv4_icmp_0_esp_aes_cbc_null_1 = { /* IP */ 0x45, 0x00, 0x00, 0x9c, 0x00, 0x00, 0x00, 0x00, - 0x40, 0x32, 0xab, 0xca, 0xc0, 0xa8, 0x6f, 0x02, + 0x40, 0x32, 0xab, 0xda, 0xc0, 0xa8, 0x6f, 0x02, 0xc0, 0xa8, 0xde, 0x02, /* ESP */ @@ -1499,7 +1499,7 @@ static const ipsec_test_packet pkt_mcgrew_gcm_test_2_esp = { /* IP - not a part of RFC, added for simplicity */ 0x45, 0x00, 0x00, 0x74, 0x69, 0x8f, 0x00, 0x00, - 0x80, 0x32, 0x4d, 0x76, 0xc0, 0xa8, 0x01, 0x02, + 0x80, 0x32, 0x4d, 0x75, 0xc0, 0xa8, 0x01, 0x02, 0xc0, 0xa8, 0x01, 0x01, /* ESP */ @@ -1557,7 +1557,7 @@ static const ipsec_test_packet pkt_mcgrew_gcm_test_3_esp = { /* IP - not a part of RFC, added for simplicity */ 0x45, 0x00, 0x00, 0x68, 0x69, 0x8f, 0x00, 0x00, - 0x80, 0x32, 0x4d, 0x82, 0xc0, 0xa8, 0x01, 0x02, + 0x80, 0x32, 0x4d, 0x81, 0xc0, 0xa8, 0x01, 0x02, 0xc0, 0xa8, 0x01, 0x01, /* ESP */ @@ -1615,7 +1615,7 @@ static const ipsec_test_packet pkt_mcgrew_gcm_test_4_esp = { /* IP - not a part of RFC, added for simplicity */ 0x45, 0x00, 0x00, 0x74, 0x69, 0x8f, 0x00, 0x00, - 0x80, 0x32, 0x4d, 0x76, 0xc0, 0xa8, 0x01, 0x02, + 0x80, 0x32, 0x4d, 0x75, 0xc0, 0xa8, 0x01, 0x02, 0xc0, 0xa8, 0x01, 0x01, /* ESP */ @@ -1730,7 +1730,7 @@ static const ipsec_test_packet pkt_mcgrew_gcm_test_15_esp = { /* IP - not a part of RFC, added for simplicity */ 0x45, 0x00, 0x00, 0x68, 0x69, 0x8f, 0x00, 0x00, - 0x80, 0x32, 0x4d, 0xb2, 0xc0, 0xa8, 0x01, 0x02, + 0x80, 0x32, 0x4d, 0x81, 0xc0, 0xa8, 0x01, 0x02, 0xc0, 0xa8, 0x01, 0x01, /* ESP */ commit 60777ba4309911df0780bd8de6d96524bc2ca03c Author: Dmitry Eremin-Solenikov <dmitry.ereminsolenikov(a)linaro.org> Date: Fri Apr 6 15:24:46 2018 +0300 validation: verify IPv4 and UDP checksum validation and generation Signed-off-by: Dmitry Eremin-Solenikov <dmitry.ereminsolenikov(a)linaro.org> Reviewed-by: Bill Fischofer <bill.fischofer(a)linaro.org> Reviewed-by: Petri Savolainen <petri.savolainen(a)linaro.org> Signed-off-by: Maxim Uvarov <maxim.uvarov(a)linaro.org> diff --git a/test/validation/api/pktio/pktio.c b/test/validation/api/pktio/pktio.c index e82a9683..09367d4e 100644 --- a/test/validation/api/pktio/pktio.c +++ b/test/validation/api/pktio/pktio.c @@ -296,7 +296,7 @@ static uint32_t pktio_init_packet(odp_packet_t pkt) return pktio_pkt_set_seq(pkt); } -static int pktio_fixup_checksums(odp_packet_t pkt) +static int pktio_zero_checksums(odp_packet_t pkt) { odph_ipv4hdr_t *ip; odph_udphdr_t *udp; @@ -312,8 +312,20 @@ static int pktio_fixup_checksums(odp_packet_t pkt) udp = (odph_udphdr_t *)odp_packet_l4_ptr(pkt, &len); ip->chksum = 0; - odph_ipv4_csum_update(pkt); udp->chksum = 0; + + return 0; +} + +static int pktio_fixup_checksums(odp_packet_t pkt) +{ + odph_udphdr_t *udp; + + pktio_zero_checksums(pkt); + + udp = (odph_udphdr_t *)odp_packet_l4_ptr(pkt, NULL); + + odph_ipv4_csum_update(pkt); udp->chksum = odph_ipv4_udp_chksum(pkt); return 0; @@ -407,10 +419,14 @@ static int flush_input_queue(odp_pktio_t pktio, odp_pktin_mode_t imode) return 0; } -static int create_packets(odp_packet_t pkt_tbl[], uint32_t pkt_seq[], int num, - odp_pktio_t pktio_src, odp_pktio_t pktio_dst) +static int create_packets_cs(odp_packet_t pkt_tbl[], + uint32_t pkt_seq[], + int num, + odp_pktio_t pktio_src, + odp_pktio_t pktio_dst, + odp_bool_t fix_cs) { - int i; + int i, ret; for (i = 0; i < num; i++) { pkt_tbl[i] = odp_packet_alloc(default_pkt_pool, packet_len); @@ -425,7 +441,11 @@ static int create_packets(odp_packet_t pkt_tbl[], uint32_t pkt_seq[], int num, pktio_pkt_set_macs(pkt_tbl[i], pktio_src, pktio_dst); - if (pktio_fixup_checksums(pkt_tbl[i]) != 0) { + if (fix_cs) + ret = pktio_fixup_checksums(pkt_tbl[i]); + else + ret = pktio_zero_checksums(pkt_tbl[i]); + if (ret != 0) { odp_packet_free(pkt_tbl[i]); break; } @@ -434,6 +454,13 @@ static int create_packets(odp_packet_t pkt_tbl[], uint32_t pkt_seq[], int num, return i; } +static int create_packets(odp_packet_t pkt_tbl[], uint32_t pkt_seq[], int num, + odp_pktio_t pktio_src, odp_pktio_t pktio_dst) +{ + return create_packets_cs(pkt_tbl, pkt_seq, num, pktio_src, pktio_dst, + true); +} + static int get_packets(pktio_info_t *pktio_rx, odp_packet_t pkt_tbl[], int num, txrx_mode_e mode) { @@ -1894,6 +1921,416 @@ static void pktio_test_pktin_ts(void) } } +static void pktio_test_chksum(void (*config_fn)(odp_pktio_t, odp_pktio_t), + void (*prep_fn)(odp_packet_t pkt), + void (*test_fn)(odp_packet_t pkt)) +{ + odp_pktio_t pktio_tx, pktio_rx; + odp_pktio_t pktio[MAX_NUM_IFACES] = {ODP_PKTIO_INVALID}; + pktio_info_t pktio_rx_info; + odp_pktout_queue_t pktout_queue; + odp_packet_t pkt_tbl[TX_BATCH_LEN]; + uint32_t pkt_seq[TX_BATCH_LEN]; + int ret; + int i, num_rx; + + CU_ASSERT_FATAL(num_ifaces >= 1); + + /* Open and configure interfaces */ + for (i = 0; i < num_ifaces; ++i) { + pktio[i] = create_pktio(i, ODP_PKTIN_MODE_DIRECT, + ODP_PKTOUT_MODE_DIRECT); + CU_ASSERT_FATAL(pktio[i] != ODP_PKTIO_INVALID); + } + + pktio_tx = pktio[0]; + pktio_rx = (num_ifaces > 1) ? pktio[1] : pktio_tx; + pktio_rx_info.id = pktio_rx; + pktio_rx_info.inq = ODP_QUEUE_INVALID; + pktio_rx_info.in_mode = ODP_PKTIN_MODE_DIRECT; + + config_fn(pktio_tx, pktio_rx); + + for (i = 0; i < num_ifaces; ++i) { + CU_ASSERT_FATAL(odp_pktio_start(pktio[i]) == 0); + _pktio_wait_linkup(pktio[i]); + } + + ret = create_packets_cs(pkt_tbl, pkt_seq, TX_BATCH_LEN, pktio_tx, + pktio_rx, false); + CU_ASSERT_FATAL(ret == TX_BATCH_LEN); + + ret = odp_pktout_queue(pktio_tx, &pktout_queue, 1); + CU_ASSERT_FATAL(ret > 0); + + for (i = 0; i < TX_BATCH_LEN; i++) + if (prep_fn) + prep_fn(pkt_tbl[i]); + + send_packets(pktout_queue, pkt_tbl, TX_BATCH_LEN); + num_rx = wait_for_packets(&pktio_rx_info, pkt_tbl, pkt_seq, + TX_BATCH_LEN, TXRX_MODE_MULTI, + ODP_TIME_SEC_IN_NS); + CU_ASSERT(num_rx == TX_BATCH_LEN); + for (i = 0; i < num_rx; i++) { + test_fn(pkt_tbl[i]); + odp_packet_free(pkt_tbl[i]); + } + + for (i = 0; i < num_ifaces; i++) { + CU_ASSERT_FATAL(odp_pktio_stop(pktio[i]) == 0); + CU_ASSERT_FATAL(odp_pktio_close(pktio[i]) == 0); + } +} + +static int pktio_check_chksum_in_ipv4(void) +{ + odp_pktio_t pktio; + odp_pktio_capability_t capa; + odp_pktio_param_t pktio_param; + int idx = (num_ifaces == 1) ? 0 : 1; + int ret; + + odp_pktio_param_init(&pktio_param); + pktio_param.in_mode = ODP_PKTIN_MODE_DIRECT; + + pktio = odp_pktio_open(iface_name[idx], pool[idx], &pktio_param); + if (pktio == ODP_PKTIO_INVALID) + return ODP_TEST_INACTIVE; + + ret = odp_pktio_capability(pktio, &capa); + (void)odp_pktio_close(pktio); + + if (ret < 0 || + !capa.config.pktin.bit.ipv4_chksum) + return ODP_TEST_INACTIVE; + + return ODP_TEST_ACTIVE; +} + +static void pktio_test_chksum_in_ipv4_config(odp_pktio_t pktio_tx ODP_UNUSED, + odp_pktio_t pktio_rx) +{ + odp_pktio_capability_t capa; + odp_pktio_config_t config; + + CU_ASSERT_FATAL(odp_pktio_capability(pktio_rx, &capa) == 0); + CU_ASSERT_FATAL(capa.config.pktin.bit.ipv4_chksum); + + odp_pktio_config_init(&config); + config.pktin.bit.ipv4_chksum = 1; + CU_ASSERT_FATAL(odp_pktio_config(pktio_rx, &config) == 0); +} + +static void pktio_test_chksum_in_ipv4_prep(odp_packet_t pkt) +{ + odph_ipv4_csum_update(pkt); +} + +static void pktio_test_chksum_in_ipv4_test(odp_packet_t pkt) +{ + CU_ASSERT(odp_packet_l3_chksum_status(pkt) == ODP_PACKET_CHKSUM_OK); +} + +static void pktio_test_chksum_in_ipv4(void) +{ + pktio_test_chksum(pktio_test_chksum_in_ipv4_config, + pktio_test_chksum_in_ipv4_prep, + pktio_test_chksum_in_ipv4_test); +} + +static int pktio_check_chksum_in_udp(void) +{ + odp_pktio_t pktio; + odp_pktio_capability_t capa; + odp_pktio_param_t pktio_param; + int idx = (num_ifaces == 1) ? 0 : 1; + int ret; + + odp_pktio_param_init(&pktio_param); + pktio_param.in_mode = ODP_PKTIN_MODE_DIRECT; + + pktio = odp_pktio_open(iface_name[idx], pool[idx], &pktio_param); + if (pktio == ODP_PKTIO_INVALID) + return ODP_TEST_INACTIVE; + + ret = odp_pktio_capability(pktio, &capa); + (void)odp_pktio_close(pktio); + + if (ret < 0 || + !capa.config.pktin.bit.udp_chksum) + return ODP_TEST_INACTIVE; + + return ODP_TEST_ACTIVE; +} + +static void pktio_test_chksum_in_udp_config(odp_pktio_t pktio_tx ODP_UNUSED, + odp_pktio_t pktio_rx) +{ + odp_pktio_capability_t capa; + odp_pktio_config_t config; + + CU_ASSERT_FATAL(odp_pktio_capability(pktio_rx, &capa) == 0); + CU_ASSERT_FATAL(capa.config.pktin.bit.udp_chksum); + + odp_pktio_config_init(&config); + config.pktin.bit.udp_chksum = 1; + CU_ASSERT_FATAL(odp_pktio_config(pktio_rx, &config) == 0); +} + +static void pktio_test_chksum_in_udp_prep(odp_packet_t pkt) +{ + odp_packet_has_ipv4_set(pkt, 1); + odp_packet_has_udp_set(pkt, 1); + odph_ipv4_csum_update(pkt); + odph_udp_chksum_set(pkt); +} + +static void pktio_test_chksum_in_udp_test(odp_packet_t pkt) +{ + CU_ASSERT(odp_packet_l4_chksum_status(pkt) == ODP_PACKET_CHKSUM_OK); +} + +static void pktio_test_chksum_in_udp(void) +{ + pktio_test_chksum(pktio_test_chksum_in_udp_config, + pktio_test_chksum_in_udp_prep, + pktio_test_chksum_in_udp_test); +} + +static int pktio_check_chksum_out_ipv4(void) +{ + odp_pktio_t pktio; + odp_pktio_capability_t capa; + odp_pktio_param_t pktio_param; + int ret; + + odp_pktio_param_init(&pktio_param); + pktio_param.in_mode = ODP_PKTIN_MODE_DIRECT; + + pktio = odp_pktio_open(iface_name[0], pool[0], &pktio_param); + if (pktio == ODP_PKTIO_INVALID) + return ODP_TEST_INACTIVE; + + ret = odp_pktio_capability(pktio, &capa); + (void)odp_pktio_close(pktio); + + if (ret < 0 || + !capa.config.pktout.bit.ipv4_chksum_ena || + !capa.config.pktout.bit.ipv4_chksum) + return ODP_TEST_INACTIVE; + + return ODP_TEST_ACTIVE; +} + +static void pktio_test_chksum_out_ipv4_config(odp_pktio_t pktio_tx, + odp_pktio_t pktio_rx ODP_UNUSED) +{ + odp_pktio_capability_t capa; + odp_pktio_config_t config; + + CU_ASSERT_FATAL(odp_pktio_capability(pktio_tx, &capa) == 0); + CU_ASSERT_FATAL(capa.config.pktout.bit.ipv4_chksum_ena); + CU_ASSERT_FATAL(capa.config.pktout.bit.ipv4_chksum); + + odp_pktio_config_init(&config); + config.pktout.bit.ipv4_chksum_ena = 1; + CU_ASSERT_FATAL(odp_pktio_config(pktio_tx, &config) == 0); +} + +static void pktio_test_chksum_out_ipv4_test(odp_packet_t pkt) +{ + odph_ipv4hdr_t *ip = odp_packet_l3_ptr(pkt, NULL); + + CU_ASSERT(ip != NULL); + if (ip != NULL) + CU_ASSERT(ip->chksum != 0); +} + +static void pktio_test_chksum_out_ipv4_no_ovr_prep(odp_packet_t pkt) +{ + odp_packet_l3_chksum_insert(pkt, false); +} + +static void pktio_test_chksum_out_ipv4_no_ovr_test(odp_packet_t pkt) +{ + odph_ipv4hdr_t *ip = odp_packet_l3_ptr(pkt, NULL); + + CU_ASSERT(ip != NULL); + if (ip != NULL) + CU_ASSERT(ip->chksum == 0); +} + +static void pktio_test_chksum_out_ipv4_no_ovr(void) +{ + pktio_test_chksum(pktio_test_chksum_out_ipv4_config, + pktio_test_chksum_out_ipv4_no_ovr_prep, + pktio_test_chksum_out_ipv4_no_ovr_test); +} + +static void pktio_test_chksum_out_ipv4_ovr_prep(odp_packet_t pkt) +{ + odp_packet_l3_chksum_insert(pkt, true); +} + +static void pktio_test_chksum_out_ipv4_ovr_test(odp_packet_t pkt) +{ + odph_ipv4hdr_t *ip = odp_packet_l3_ptr(pkt, NULL); + + CU_ASSERT(ip != NULL); + if (ip != NULL) + CU_ASSERT(ip->chksum != 0); +} + +static void pktio_test_chksum_out_ipv4_ovr(void) +{ + pktio_test_chksum(pktio_test_chksum_out_ipv4_config, + pktio_test_chksum_out_ipv4_ovr_prep, + pktio_test_chksum_out_ipv4_ovr_test); +} + +static void pktio_test_chksum_out_ipv4_pktio_config(odp_pktio_t pktio_tx, + odp_pktio_t pktio_rx + ODP_UNUSED) +{ + odp_pktio_capability_t capa; + odp_pktio_config_t config; + + CU_ASSERT_FATAL(odp_pktio_capability(pktio_tx, &capa) == 0); + CU_ASSERT_FATAL(capa.config.pktout.bit.ipv4_chksum_ena); + CU_ASSERT_FATAL(capa.config.pktout.bit.ipv4_chksum); + + odp_pktio_config_init(&config); + config.pktout.bit.ipv4_chksum_ena = 1; + config.pktout.bit.ipv4_chksum = 1; + CU_ASSERT_FATAL(odp_pktio_config(pktio_tx, &config) == 0); +} + +static void pktio_test_chksum_out_ipv4_pktio(void) +{ + pktio_test_chksum(pktio_test_chksum_out_ipv4_pktio_config, + NULL, + pktio_test_chksum_out_ipv4_test); +} + +static int pktio_check_chksum_out_udp(void) +{ + odp_pktio_t pktio; + odp_pktio_capability_t capa; + odp_pktio_param_t pktio_param; + int ret; + + odp_pktio_param_init(&pktio_param); + pktio_param.in_mode = ODP_PKTIN_MODE_DIRECT; + + pktio = odp_pktio_open(iface_name[0], pool[0], &pktio_param); + if (pktio == ODP_PKTIO_INVALID) + return ODP_TEST_INACTIVE; + + ret = odp_pktio_capability(pktio, &capa); + (void)odp_pktio_close(pktio); + + if (ret < 0 || + !capa.config.pktout.bit.udp_chksum_ena || + !capa.config.pktout.bit.udp_chksum) + return ODP_TEST_INACTIVE; + + return ODP_TEST_ACTIVE; +} + +static void pktio_test_chksum_out_udp_config(odp_pktio_t pktio_tx, + odp_pktio_t pktio_rx ODP_UNUSED) +{ + odp_pktio_capability_t capa; + odp_pktio_config_t config; + + CU_ASSERT_FATAL(odp_pktio_capability(pktio_tx, &capa) == 0); + CU_ASSERT_FATAL(capa.config.pktout.bit.udp_chksum_ena); + CU_ASSERT_FATAL(capa.config.pktout.bit.udp_chksum); + + odp_pktio_config_init(&config); + config.pktout.bit.udp_chksum_ena = 1; + CU_ASSERT_FATAL(odp_pktio_config(pktio_tx, &config) == 0); +} + +static void pktio_test_chksum_out_udp_test(odp_packet_t pkt) +{ + odph_udphdr_t *udp = odp_packet_l4_ptr(pkt, NULL); + + CU_ASSERT(udp != NULL); + if (udp != NULL) { + CU_ASSERT(udp->chksum != 0); + CU_ASSERT(!odph_udp_chksum_verify(pkt)); + } +} + +static void pktio_test_chksum_out_udp_no_ovr_prep(odp_packet_t pkt) +{ + odph_ipv4_csum_update(pkt); + odp_packet_l4_chksum_insert(pkt, false); +} + +static void pktio_test_chksum_out_udp_no_ovr_test(odp_packet_t pkt) +{ + odph_udphdr_t *udp = odp_packet_l4_ptr(pkt, NULL); + + CU_ASSERT(udp != NULL); + if (udp != NULL) + CU_ASSERT(udp->chksum == 0); +} + +static void pktio_test_chksum_out_udp_no_ovr(void) +{ + pktio_test_chksum(pktio_test_chksum_out_udp_config, + pktio_test_chksum_out_udp_no_ovr_prep, + pktio_test_chksum_out_udp_no_ovr_test); +} + +static void pktio_test_chksum_out_udp_ovr_prep(odp_packet_t pkt) +{ + odp_packet_l4_chksum_insert(pkt, true); +} + +static void pktio_test_chksum_out_udp_ovr_test(odp_packet_t pkt) +{ + odph_udphdr_t *udp = odp_packet_l4_ptr(pkt, NULL); + + CU_ASSERT(udp != NULL); + if (udp != NULL) + CU_ASSERT(udp->chksum != 0); +} + +static void pktio_test_chksum_out_udp_ovr(void) +{ + pktio_test_chksum(pktio_test_chksum_out_udp_config, + pktio_test_chksum_out_udp_ovr_prep, + pktio_test_chksum_out_udp_ovr_test); +} + +static void pktio_test_chksum_out_udp_pktio_config(odp_pktio_t pktio_tx, + odp_pktio_t pktio_rx + ODP_UNUSED) +{ + odp_pktio_capability_t capa; + odp_pktio_config_t config; + + CU_ASSERT_FATAL(odp_pktio_capability(pktio_tx, &capa) == 0); + CU_ASSERT_FATAL(capa.config.pktout.bit.udp_chksum_ena); + CU_ASSERT_FATAL(capa.config.pktout.bit.udp_chksum); + + odp_pktio_config_init(&config); + config.pktout.bit.udp_chksum_ena = 1; + config.pktout.bit.udp_chksum = 1; + CU_ASSERT_FATAL(odp_pktio_config(pktio_tx, &config) == 0); +} + +static void pktio_test_chksum_out_udp_pktio(void) +{ + pktio_test_chksum(pktio_test_chksum_out_udp_pktio_config, + NULL, + pktio_test_chksum_out_udp_test); +} + static int create_pool(const char *iface, int num) { char pool_name[ODP_POOL_NAME_LEN]; @@ -2034,6 +2471,22 @@ odp_testinfo_t pktio_suite_unsegmented[] = { pktio_check_statistics_counters), ODP_TEST_INFO_CONDITIONAL(pktio_test_pktin_ts, pktio_check_pktin_ts), + ODP_TEST_INFO_CONDITIONAL(pktio_test_chksum_in_ipv4, + pktio_check_chksum_in_ipv4), + ODP_TEST_INFO_CONDITIONAL(pktio_test_chksum_in_udp, + pktio_check_chksum_in_udp), + ODP_TEST_INFO_CONDITIONAL(pktio_test_chksum_out_ipv4_no_ovr, + pktio_check_chksum_out_ipv4), + ODP_TEST_INFO_CONDITIONAL(pktio_test_chksum_out_ipv4_pktio, + pktio_check_chksum_out_ipv4), + ODP_TEST_INFO_CONDITIONAL(pktio_test_chksum_out_ipv4_ovr, + pktio_check_chksum_out_ipv4), + ODP_TEST_INFO_CONDITIONAL(pktio_test_chksum_out_udp_no_ovr, + pktio_check_chksum_out_udp), + ODP_TEST_INFO_CONDITIONAL(pktio_test_chksum_out_udp_pktio, + pktio_check_chksum_out_udp), + ODP_TEST_INFO_CONDITIONAL(pktio_test_chksum_out_udp_ovr, + pktio_check_chksum_out_udp), ODP_TEST_INFO_NULL }; commit b2632ac253a3b9f5ba7a4174acf6abe295ec3550 Author: Dmitry Eremin-Solenikov <dmitry.ereminsolenikov(a)linaro.org> Date: Fri Apr 6 15:23:37 2018 +0300 linux-gen: pktio: loop: support IPv4/TCP/UDP checksum generation Signed-off-by: Dmitry Eremin-Solenikov <dmitry.ereminsolenikov(a)linaro.org> Reviewed-by: Bill Fischofer <bill.fischofer(a)linaro.org> Reviewed-by: Petri Savolainen <petri.savolainen(a)linaro.org> Signed-off-by: Maxim Uvarov <maxim.uvarov(a)linaro.org> diff --git a/platform/linux-generic/pktio/loop.c b/platform/linux-generic/pktio/loop.c index 7fc0fd61..fc80e801 100644 --- a/platform/linux-generic/pktio/loop.c +++ b/platform/linux-generic/pktio/loop.c @@ -15,6 +15,7 @@ #include <odp_debug_internal.h> #include <odp/api/plat/packet_flag_inlines.h> #include <odp/api/hints.h> +#include <odp/api/plat/byteorder_inlines.h> #include <odp_queue_if.h> #include <protocols/eth.h> @@ -32,6 +33,7 @@ static const char pktio_loop_mac[] = {0x02, 0xe9, 0x34, 0x80, 0x73, 0x01}; static int loopback_stats_reset(pktio_entry_t *pktio_entry); +static int loopback_init_capability(pktio_entry_t *pktio_entry); static int loopback_open(odp_pktio_t id, pktio_entry_t *pktio_entry, const char *devname, odp_pool_t pool ODP_UNUSED) @@ -61,6 +63,7 @@ static int loopback_open(odp_pktio_t id, pktio_entry_t *pktio_entry, return -1; loopback_stats_reset(pktio_entry); + loopback_init_capability(pktio_entry); return 0; } @@ -172,6 +175,85 @@ static int loopback_recv(pktio_entry_t *pktio_entry, int index ODP_UNUSED, return num_rx; } +#define OL_TX_CHKSUM_PKT(_cfg, _capa, _proto, _ovr_set, _ovr) \ + (_capa && _proto && (_ovr_set ? _ovr : _cfg)) + +static inline int check_proto(void *l3_hdr, + uint32_t l3_len, + odp_bool_t *l3_proto_v4, + uint8_t *l4_proto) +{ + uint8_t l3_proto_ver = _ODP_IPV4HDR_VER(*(uint8_t *)l3_hdr); + + if (l3_proto_ver == _ODP_IPV4 && l3_len >= _ODP_IPV4HDR_LEN) { + _odp_ipv4hdr_t *ip = l3_hdr; + uint16_t frag_offset = _odp_be_to_cpu_16(ip->frag_offset); + + *l3_proto_v4 = 1; + if (!_ODP_IPV4HDR_IS_FRAGMENT(frag_offset)) + *l4_proto = ip->proto; + else + *l4_proto = 255; + + return 0; + } else if (l3_proto_ver == _ODP_IPV6 && l3_len >= _ODP_IPV6HDR_LEN) { + _odp_ipv6hdr_t *ipv6 = l3_hdr; + + *l3_proto_v4 = 0; + *l4_proto = ipv6->next_hdr; + + /* FIXME: check that packet is not a fragment !!! + * Might require parsing headers spanning several segments, so + * not implemented yet. */ + return 0; + } + + return -1; +} + +static inline void loopback_fix_checksums(odp_packet_t pkt, + odp_pktout_config_opt_t *pktout_cfg, + odp_pktout_config_opt_t *pktout_capa) +{ + odp_bool_t l3_proto_v4 = false; + uint8_t l4_proto; + void *l3_hdr; + uint32_t l3_len; + odp_bool_t ipv4_chksum_pkt, udp_chksum_pkt, tcp_chksum_pkt; + odp_packet_hdr_t *pkt_hdr = packet_hdr(pkt); + + l3_hdr = odp_packet_l3_ptr(pkt, &l3_len); + + if (l3_hdr == NULL || + check_proto(l3_hdr, l3_len, &l3_proto_v4, &l4_proto)) + return; + + ipv4_chksum_pkt = OL_TX_CHKSUM_PKT(pktout_cfg->bit.ipv4_chksum, + pktout_capa->bit.ipv4_chksum, + l3_proto_v4, + pkt_hdr->p.flags.l3_chksum_set, + pkt_hdr->p.flags.l3_chksum); + udp_chksum_pkt = OL_TX_CHKSUM_PKT(pktout_cfg->bit.udp_chksum, + pktout_capa->bit.udp_chksum, + l4_proto == _ODP_IPPROTO_UDP, + pkt_hdr->p.flags.l4_chksum_set, + pkt_hdr->p.flags.l4_chksum); + tcp_chksum_pkt = OL_TX_CHKSUM_PKT(pktout_cfg->bit.tcp_chksum, + pktout_capa->bit.tcp_chksum, + l4_proto == _ODP_IPPROTO_TCP, + pkt_hdr->p.flags.l4_chksum_set, + pkt_hdr->p.flags.l4_chksum); + + if (ipv4_chksum_pkt) + _odp_packet_ipv4_chksum_insert(pkt); + + if (tcp_chksum_pkt) + _odp_packet_tcp_chksum_insert(pkt); + + if (udp_chksum_pkt) + _odp_packet_udp_chksum_insert(pkt); +} + static int loopback_send(pktio_entry_t *pktio_entry, int index ODP_UNUSED, const odp_packet_t pkt_tbl[], int num) { @@ -182,6 +264,9 @@ static int loopback_send(pktio_entry_t *pktio_entry, int index ODP_UNUSED, int nb_tx = 0; uint32_t bytes = 0; uint32_t out_octets_tbl[num]; + odp_pktout_config_opt_t *pktout_cfg = &pktio_entry->s.config.pktout; + odp_pktout_config_opt_t *pktout_capa = + &pktio_entry->s.capa.config.pktout; if (odp_unlikely(num > QUEUE_MULTI_MAX)) num = QUEUE_MULTI_MAX; @@ -218,6 +303,9 @@ static int loopback_send(pktio_entry_t *pktio_entry, int index ODP_UNUSED, packet_subtype_set(pkt_tbl[i], ODP_EVENT_PACKET_BASIC); } + for (i = 0; i < nb_tx; ++i) + loopback_fix_checksums(pkt_tbl[i], pktout_cfg, pktout_capa); + odp_ticketlock_lock(&pktio_entry->s.txl); queue = queue_fn->from_ext(pktio_entry->s.pkt_loop.loopq); @@ -255,9 +343,10 @@ static int loopback_link_status(pktio_entry_t *pktio_entry ODP_UNUSED) return 1; } -static int loopback_capability(pktio_entry_t *pktio_entry ODP_UNUSED, - odp_pktio_capability_t *capa) +static int loopback_init_capability(pktio_entry_t *pktio_entry) { + odp_pktio_capability_t *capa = &pktio_entry->s.capa; + memset(capa, 0, sizeof(odp_pktio_capability_t)); capa->max_input_queues = 1; @@ -267,9 +356,26 @@ static int loopback_capability(pktio_entry_t *pktio_entry ODP_UNUSED, odp_pktio_config_init(&capa->config); capa->config.pktin.bit.ts_all = 1; capa->config.pktin.bit.ts_ptp = 1; + capa->config.pktout.bit.ipv4_chksum = 1; + capa->config.pktout.bit.tcp_chksum = 1; + capa->config.pktout.bit.udp_chksum = 1; capa->config.inbound_ipsec = 1; capa->config.outbound_ipsec = 1; + capa->config.pktout.bit.ipv4_chksum_ena = + capa->config.pktout.bit.ipv4_chksum; + capa->config.pktout.bit.udp_chksum_ena = + capa->config.pktout.bit.udp_chksum; + capa->config.pktout.bit.tcp_chksum_ena = + capa->config.pktout.bit.tcp_chksum; + + return 0; +} + +static int loopback_capability(pktio_entry_t *pktio_entry ODP_UNUSED, + odp_pktio_capability_t *capa) +{ + *capa = pktio_entry->s.capa; return 0; } commit 79f5c103310c36dc213a552b9534f68ce8df1132 Author: Dmitry Eremin-Solenikov <dmitry.ereminsolenikov(a)linaro.org> Date: Mon Apr 9 15:45:55 2018 +0300 linux-gen: packet: l4 checksum insertion support Signed-off-by: Dmitry Eremin-Solenikov <dmitry.ereminsolenikov(a)linaro.org> Reviewed-by: Bill Fischofer <bill.fischofer(a)linaro.org> Reviewed-by: Petri Savolainen <petri.savolainen(a)linaro.org> Signed-off-by: Maxim Uvarov <maxim.uvarov(a)linaro.org> diff --git a/platform/linux-generic/include/odp_packet_internal.h b/platform/linux-generic/include/odp_packet_internal.h index cb1c3849..be17cac8 100644 --- a/platform/linux-generic/include/odp_packet_internal.h +++ b/platform/linux-generic/include/odp_packet_internal.h @@ -304,6 +304,8 @@ int _odp_packet_cmp_data(odp_packet_t pkt, uint32_t offset, const void *s, uint32_t len); int _odp_packet_ipv4_chksum_insert(odp_packet_t pkt); +int _odp_packet_tcp_chksum_insert(odp_packet_t pkt); +int _odp_packet_udp_chksum_insert(odp_packet_t pkt); #ifdef __cplusplus } diff --git a/platform/linux-generic/odp_packet.c b/platform/linux-generic/odp_packet.c index 8170c812..d4b19fee 100644 --- a/platform/linux-generic/odp_packet.c +++ b/platform/linux-generic/odp_packet.c @@ -1910,6 +1910,92 @@ int _odp_packet_copy_md_to_packet(odp_packet_t srcpkt, odp_packet_t dstpkt) return dst_uarea_size < src_uarea_size; } +/* Simple implementation of ones complement sum. + * Based on RFC1071 and its errata. + */ +typedef union { + uint16_t w; + uint8_t b[2]; +} swap_buf_t; + +static uint32_t segment_sum16_32(const uint8_t *p, + uint32_t len, + uint32_t offset) + +{ + uint32_t sum = 0; + + /* Include second part of 16-bit short word split between segments */ + if (len > 0 && (offset % 2)) { + swap_buf_t sw; + + sw.b[0] = 0; + sw.b[1] = *p++; + sum = sw.w; + len--; + } + + /* + * If pointer is 16-bit aligned, we can do fast path calculation. + * If it is not, we sum hi and lo bytes separately and then sum them. + */ + if ((uintptr_t)p % 2) { + uint32_t sum1 = 0, sum2 = 0; + + while (len > 1) { + sum1 += *p++; + sum2 += *p++; + len -= 2; + } +#if (ODP_BYTE_ORDER == ODP_BIG_ENDIAN) + sum += sum2 + (sum1 << 8); +#else + sum += sum1 + (sum2 << 8); +#endif + } else { + while (len > 1) { + sum += *(const uint16_t *)(uintptr_t)p; + p += 2; + len -= 2; + } + } + + /* Add left-over byte, if any */ + if (len > 0) { + swap_buf_t sw; + + sw.b[0] = *p; + sw.b[1] = 0; + sum += sw.w; + } + + return sum; +} + +static uint32_t packet_sum16_32(odp_packet_hdr_t *pkt_hdr, + uint32_t offset, + uint32_t len) +{ + uint32_t sum = 0; + + if (offset + len > pkt_hdr->frame_len) + return 0; + + while (len > 0) { + uint32_t seglen = 0; /* GCC */ + void *mapaddr = packet_map(pkt_hdr, offset, &seglen, NULL); + + if (seglen > len) + seglen = len; + + sum += segment_sum16_32(mapaddr, seglen, offset); + len -= seglen; + offset += seglen; + } + + return sum; +} + /** Parser helper function for Ethernet packets */ static inline uint16_t parse_eth(packet_parser_t *prs, const uint8_t **parseptr, uint32_t *offset, uint32_t frame_len) @@ -2291,6 +2377,11 @@ static inline int packet_ipv4_chksum(odp_packet_t pkt, } #define _ODP_IPV4HDR_CSUM_OFFSET ODP_OFFSETOF(_odp_ipv4hdr_t, chksum) +#define _ODP_IPV4ADDR_OFFSSET ODP_OFFSETOF(_odp_ipv4hdr_t, src_addr) +#define _ODP_IPV6ADDR_OFFSSET ODP_OFFSETOF(_odp_ipv6hdr_t, src_addr) +#define _ODP_IPV4HDR_CSUM_OFFSET ODP_OFFSETOF(_odp_ipv4hdr_t, chksum) +#define _ODP_UDP_LEN_OFFSET ODP_OFFSETOF(_odp_udphdr_t, length) +#define _ODP_UDP_CSUM_OFFSET ODP_OFFSETOF(_odp_udphdr_t, chksum) /** * Calculate and fill in IPv4 checksum @@ -2324,6 +2415,96 @@ int _odp_packet_ipv4_chksum_insert(odp_packet_t pkt) 2, &chksum); } +static int _odp_packet_tcp_udp_chksum_insert(odp_packet_t pkt, uint16_t proto) +{ + odp_packet_hdr_t *pkt_hdr = packet_hdr(pkt); + uint32_t zero = 0; + uint32_t sum; + uint16_t l3_ver; + uint16_t chksum; + uint32_t chksum_offset; + + if (pkt_hdr->p.l3_offset == ODP_PACKET_OFFSET_INVALID) + return -1; + if (pkt_hdr->p.l4_offset == ODP_PACKET_OFFSET_INVALID) + return -1; + + odp_packet_copy_to_mem(pkt, pkt_hdr->p.l3_offset, 2, &l3_ver); + + if (_ODP_IPV4HDR_VER(l3_ver) == _ODP_IPV4) + sum = packet_sum16_32(pkt_hdr, + pkt_hdr->p.l3_offset + + _ODP_IPV4ADDR_OFFSSET, + 2 * _ODP_IPV4ADDR_LEN); + else + sum = packet_sum16_32(pkt_hdr, + pkt_hdr->p.l3_offset + + _ODP_IPV6ADDR_OFFSSET, + 2 * _ODP_IPV6ADDR_LEN); +#if ODP_BYTE_ORDER == ODP_BIG_ENDIAN + sum += proto; +#else + sum += proto << 8; +#endif + + if (proto == _ODP_IPPROTO_TCP) { + sum += _odp_cpu_to_be_16(pkt_hdr->frame_len - + pkt_hdr->p.l4_offset); + chksum_offset = pkt_hdr->p.l4_offset + _ODP_UDP_CSUM_OFFSET; + } else { + sum += packet_sum16_32(pkt_hdr, + pkt_hdr->p.l4_offset + + _ODP_UDP_LEN_OFFSET, + 2); + chksum_offset = pkt_hdr->p.l4_offset + _ODP_UDP_CSUM_OFFSET; + } + odp_packet_copy_from_mem(pkt, chksum_offset, 2, &zero); + + sum += packet_sum16_32(pkt_hdr, + pkt_hdr->p.l4_offset, + pkt_hdr->frame_len - + pkt_hdr->p.l4_offset); + + /* Not more than two additions */ + sum = (sum & 0xffff) + (sum >> 16); + sum = (sum & 0xffff) + (sum >> 16); + + chksum = ~sum; + + if (proto == _ODP_IPPROTO_UDP && chksum == 0) + chksum = 0xffff; + + return odp_packet_copy_from_mem(pkt, + chksum_offset, + 2, &chksum); +} + +/** + * Calculate and fill in TCP checksum + * + * @param pkt ODP packet + * + * @retval 0 on success + * @retval <0 on failure + */ +int _odp_packet_tcp_chksum_insert(odp_packet_t pkt) +{ + return _odp_packet_tcp_udp_chksum_insert(pkt, _ODP_IPPROTO_TCP); +} + +/** + * Calculate and fill in UDP checksum + * + * @param pkt ODP packet + * + * @retval 0 on success + * @retval <0 on failure + */ +int _odp_packet_udp_chksum_insert(odp_packet_t pkt) +{ + return _odp_packet_tcp_udp_chksum_insert(pkt, _ODP_IPPROTO_UDP); +} + /** * Simple packet parser */ commit 2c99a9dc1978c9178e711d264aaaca2bc4702352 Author: Dmitry Eremin-Solenikov <dmitry.ereminsolenikov(a)linaro.org> Date: Mon Apr 2 22:52:11 2018 +0300 linux-gen: packet: IPv4 checksum insertion Signed-off-by: Dmitry Eremin-Solenikov <dmitry.ereminsolenikov(a)linaro.org> Reviewed-by: Bill Fischofer <bill.fischofer(a)linaro.org> Reviewed-by: Petri Savolainen <petri.savolainen(a)linaro.org> Signed-off-by: Maxim Uvarov <maxim.uvarov(a)linaro.org> diff --git a/platform/linux-generic/include/odp_packet_internal.h b/platform/linux-generic/include/odp_packet_internal.h index 75b4ce9e..cb1c3849 100644 --- a/platform/linux-generic/include/odp_packet_internal.h +++ b/platform/linux-generic/include/odp_packet_internal.h @@ -303,6 +303,8 @@ int _odp_packet_set_data(odp_packet_t pkt, uint32_t offset, int _odp_packet_cmp_data(odp_packet_t pkt, uint32_t offset, const void *s, uint32_t len); +int _odp_packet_ipv4_chksum_insert(odp_packet_t pkt); + #ifdef __cplusplus } #endif diff --git a/platform/linux-generic/odp_ipsec.c b/platform/linux-generic/odp_ipsec.c index 1e90cea0..65f7361b 100644 --- a/platform/linux-generic/odp_ipsec.c +++ b/platform/linux-generic/odp_ipsec.c @@ -162,67 +162,10 @@ static odp_ipsec_packet_result_t *ipsec_pkt_result(odp_packet_t packet) return &packet_hdr(packet)->ipsec_ctx; } -static inline int _odp_ipv4_csum(odp_packet_t pkt, - uint32_t offset, - _odp_ipv4hdr_t *ip, - odp_u16sum_t *chksum) -{ - unsigned nleft = _ODP_IPV4HDR_IHL(ip->ver_ihl) * 4; - uint16_t buf[nleft / 2]; - int res; - - if (odp_unlikely(nleft < sizeof(*ip))) - return -1; - ip->chksum = 0; - memcpy(buf, ip, sizeof(*ip)); - res = odp_packet_copy_to_mem(pkt, offset + sizeof(*ip), - nleft - sizeof(*ip), - buf + sizeof(*ip) / 2); - if (odp_unlikely(res < 0)) - return res; - - *chksum = ~odp_chksum_ones_comp16(buf, nleft); - - return 0; -} - -#define _ODP_IPV4HDR_CSUM_OFFSET ODP_OFFSETOF(_odp_ipv4hdr_t, chksum) #define _ODP_IPV4HDR_PROTO_OFFSET ODP_OFFSETOF(_odp_ipv4hdr_t, proto) #define _ODP_IPV6HDR_NHDR_OFFSET ODP_OFFSETOF(_odp_ipv6hdr_t, next_hdr) #define _ODP_IPV6HDREXT_NHDR_OFFSET ODP_OFFSETOF(_odp_ipv6hdr_ext_t, next_hdr) -/** - * Calculate and fill in IPv4 checksum - * - * @param pkt ODP packet - * - * @retval 0 on success - * @retval <0 on failure - */ -static inline int _odp_ipv4_csum_update(odp_packet_t pkt) -{ - uint32_t offset; - _odp_ipv4hdr_t ip; - odp_u16sum_t chksum; - int res; - - offset = odp_packet_l3_offset(pkt); - if (offset == ODP_PACKET_OFFSET_INVALID) - return -1; - - res = odp_packet_copy_to_mem(pkt, offset, sizeof(ip), &ip); - if (odp_unlikely(res < 0)) - return res; - - res = _odp_ipv4_csum(pkt, offset, &ip, &chksum); - if (odp_unlikely(res < 0)) - return res; - - return odp_packet_copy_from_mem(pkt, - offset + _ODP_IPV4HDR_CSUM_OFFSET, - 2, &chksum); -} - #define ipv4_hdr_len(ip) (_ODP_IPV4HDR_IHL((ip)->ver_ihl) * 4) static const uint8_t ipsec_padding[255] = { @@ -815,7 +758,7 @@ static ipsec_sa_t *ipsec_in_single(odp_packet_t pkt, ipv4hdr->tot_len = _odp_cpu_to_be_16(state.ip_tot_len); else ipv4hdr->ttl -= ipsec_sa->dec_ttl; - _odp_ipv4_csum_update(pkt); + _odp_packet_ipv4_chksum_insert(pkt); } else if (state.is_ipv6 && odp_packet_len(pkt) > _ODP_IPV6HDR_LEN) { _odp_ipv6hdr_t *ipv6hdr = odp_packet_l3_ptr(pkt, NULL); @@ -1238,7 +1181,7 @@ static int ipsec_out_esp(odp_packet_t *pkt, static void ipsec_out_esp_post(ipsec_state_t *state, odp_packet_t pkt) { if (state->is_ipv4) - _odp_ipv4_csum_update(pkt); + _odp_packet_ipv4_chksum_insert(pkt); } static int ipsec_out_ah(odp_packet_t *pkt, @@ -1343,7 +1286,7 @@ static void ipsec_out_ah_post(ipsec_state_t *state, odp_packet_t pkt) ipv4hdr->tos = state->ah_ipv4.tos; ipv4hdr->frag_offset = state->ah_ipv4.frag_offset; - _odp_ipv4_csum_update(pkt); + _odp_packet_ipv4_chksum_insert(pkt); } else { _odp_ipv6hdr_t *ipv6hdr = odp_packet_l3_ptr(pkt, NULL); @@ -1500,7 +1443,7 @@ static ipsec_sa_t *ipsec_out_single(odp_packet_t pkt, else if (ODP_IPSEC_AH == ipsec_sa->proto) ipsec_out_ah_post(&state, pkt); - _odp_ipv4_csum_update(pkt); + _odp_packet_ipv4_chksum_insert(pkt); *pkt_out = pkt; return ipsec_sa; diff --git a/platform/linux-generic/odp_packet.c b/platform/linux-generic/odp_packet.c index 462c8a4c..8170c812 100644 --- a/platform/linux-generic/odp_packet.c +++ b/platform/linux-generic/odp_packet.c @@ -2266,6 +2266,64 @@ int packet_parse_common(packet_parser_t *prs, const uint8_t *ptr, seg_len, layer, ethtype); } +static inline int packet_ipv4_chksum(odp_packet_t pkt, + uint32_t offset, + _odp_ipv4hdr_t *ip, + odp_u16sum_t *chksum) +{ + unsigned int nleft = _ODP_IPV4HDR_IHL(ip->ver_ihl) * 4; + uint16_t buf[nleft / 2]; + int res; + + if (odp_unlikely(nleft < sizeof(*ip))) + return -1; + ip->chksum = 0; + memcpy(buf, ip, sizeof(*ip)); + res = odp_packet_copy_to_mem(pkt, offset + sizeof(*ip), + nleft - sizeof(*ip), + buf + sizeof(*ip) / 2); + if (odp_unlikely(res < 0)) + return res; + + *chksum = ~odp_chksum_ones_comp16(buf, nleft); + + return 0; +} + +#define _ODP_IPV4HDR_CSUM_OFFSET ODP_OFFSETOF(_odp_ipv4hdr_t, chksum) + +/** + * Calculate and fill in IPv4 checksum + * + * @param pkt ODP packet + * + * @retval 0 on success + * @retval <0 on failure + */ +int _odp_packet_ipv4_chksum_insert(odp_packet_t pkt) +{ + uint32_t offset; + _odp_ipv4hdr_t ip; + odp_u16sum_t chksum; + int res; + + offset = odp_packet_l3_offset(pkt); + if (offset == ODP_PACKET_OFFSET_INVALID) + return -1; + + res = odp_packet_copy_to_mem(pkt, offset, sizeof(ip), &ip); + if (odp_unlikely(res < 0)) + return res; + + res = packet_ipv4_chksum(pkt, offset, &ip, &chksum); + if (odp_unlikely(res < 0)) + return res; + + return odp_packet_copy_from_mem(pkt, + offset + _ODP_IPV4HDR_CSUM_OFFSET, + 2, &chksum); +} + /** * Simple packet parser */ ----------------------------------------------------------------------- Summary of changes: .../linux-generic/include/odp_packet_internal.h | 4 + platform/linux-generic/odp_ipsec.c | 106 ++--- platform/linux-generic/odp_packet.c | 239 +++++++++++ platform/linux-generic/pktio/loop.c | 110 ++++- test/validation/api/ipsec/ipsec.c | 2 + test/validation/api/ipsec/ipsec_test_out.c | 32 ++ test/validation/api/ipsec/test_vectors.h | 71 +++- test/validation/api/pktio/pktio.c | 465 ++++++++++++++++++++- 8 files changed, 954 insertions(+), 75 deletions(-) hooks/post-receive --

6 years

1
0
0 0

[COMMIT] branch master updated. v1.18.0.1_tigermoth_rc3-56-g88ba3577

by git＠git-us.linaro.org

This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "". The branch, master has been updated via 88ba35773c76c871a222fe48a0dac05765c39936 (commit) from 2e96afe0b7c4e7e41fb03bcda605ab704f538ca1 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 88ba35773c76c871a222fe48a0dac05765c39936 Author: Josep Puigdemont <josep.puigdemont(a)linaro.org> Date: Wed Apr 11 14:40:53 2018 +0200 fdserver: handle signal interruption in connect() Signed-off-by: Josep Puigdemont <josep.puigdemont(a)linaro.org> Reviewed-by: Janne Peltonen <janne.peltonen(a)nokia.com> Signed-off-by: Maxim Uvarov <maxim.uvarov(a)linaro.org> diff --git a/platform/linux-generic/odp_fdserver.c b/platform/linux-generic/odp_fdserver.c index c88c71cd..0e9fb0e4 100644 --- a/platform/linux-generic/odp_fdserver.c +++ b/platform/linux-generic/odp_fdserver.c @@ -265,7 +265,9 @@ static int get_socket(void) remote.sun_family = AF_UNIX; strcpy(remote.sun_path, sockpath); len = strlen(remote.sun_path) + sizeof(remote.sun_family); - if (connect(s_sock, (struct sockaddr *)&remote, len) == -1) { + while (connect(s_sock, (struct sockaddr *)&remote, len) == -1) { + if (errno == EINTR) + continue; ODP_ERR("cannot connect to server: %s\n", strerror(errno)); close(s_sock); return -1; ----------------------------------------------------------------------- Summary of changes: platform/linux-generic/odp_fdserver.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) hooks/post-receive --

6 years

1
0
0 0

[COMMIT] branch master updated. v1.18.0.1_tigermoth_rc3-55-g2e96afe0

by git＠git-us.linaro.org

This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "". The branch, master has been updated via 2e96afe0b7c4e7e41fb03bcda605ab704f538ca1 (commit) from 52ea8d51d522d7013f746748bf84bfc2e9bc042c (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 2e96afe0b7c4e7e41fb03bcda605ab704f538ca1 Author: Josep Puigdemont <josep.puigdemont(a)linaro.org> Date: Fri Apr 13 13:50:21 2018 +0200 linux-gen: shm: check return value when registering fds fdserver functions such as that for registering a new fd may fail. In this case we need to check the return value and do a cleanup of any allocated blocks and fragments. If it fails on deregistering, just return the error code. Signed-off-by: Josep Puigdemont <josep.puigdemont(a)linaro.org> Reviewed-by: Bill Fischofer <bill.fischofer(a)linaro.org> Signed-off-by: Maxim Uvarov <maxim.uvarov(a)linaro.org> diff --git a/platform/linux-generic/odp_ishm.c b/platform/linux-generic/odp_ishm.c index a1a90424..babf51b9 100644 --- a/platform/linux-generic/odp_ishm.c +++ b/platform/linux-generic/odp_ishm.c @@ -767,6 +767,65 @@ static void procsync(void) ishm_proctable->nb_entries = last; } +/* + * Free a block as described in block_free(), but + * considering whether to close the file descriptor or not, and + * whether to deregister from the fdserver. + */ +static int block_free_internal(int block_index, int close_fd, int deregister) +{ + int proc_index; + ishm_block_t *block; /* entry in the main block table*/ + int last; + int ret = 0; + + if ((block_index < 0) || + (block_index >= ISHM_MAX_NB_BLOCKS) || + (ishm_tbl->block[block_index].len == 0)) { + ODP_ERR("Request to free an invalid block\n"); + return -1; + } + + block = &ishm_tbl->block[block_index]; + + proc_index = procfind_block(block_index); + if (proc_index >= 0) { + /* remove the mapping and possible fragment */ + do_unmap(ishm_proctable->entry[proc_index].start, + block->len, + ishm_proctable->entry[proc_index].flags, + block_index); + + /* close the related fd */ + if (close_fd) + close(ishm_proctable->entry[proc_index].fd); + + /* remove entry from process local table: */ + last = ishm_proctable->nb_entries - 1; + ishm_proctable->entry[proc_index] = ishm_proctable->entry[last]; + ishm_proctable->nb_entries = last; + } else { + /* just possibly free the fragment as no mapping exist here: */ + do_unmap(NULL, 0, block->flags, block_index); + } + + /* remove all files related to this block: */ + if (close_fd) + delete_file(block); + + /* deregister the file descriptor from the file descriptor server. */ + if (deregister) + ret = _odp_fdserver_deregister_fd(FD_SRV_CTX_ISHM, block_index); + + /* mark the block as free in the main block table: */ + block->len = 0; + + /* mark the change so other processes see this entry as obsolete: */ + block->seq++; + + return ret; +} + /* * Allocate and map internal shared memory, or other objects: * If a name is given, check that this name is not already in use. @@ -928,7 +987,10 @@ int _odp_ishm_reserve(const char *name, uint64_t size, int fd, ishm_proctable->entry[new_proc_entry].fd = fd; /* register the file descriptor to the file descriptor server. */ - _odp_fdserver_register_fd(FD_SRV_CTX_ISHM, new_index, fd); + if (_odp_fdserver_register_fd(FD_SRV_CTX_ISHM, new_index, fd) == -1) { + block_free_internal(new_index, !new_block->external_fd, 0); + new_index = -1; + } odp_spinlock_unlock(&ishm_tbl->lock); return new_index; @@ -1034,53 +1096,7 @@ error_exp_file: */ static int block_free(int block_index) { - int proc_index; - ishm_block_t *block; /* entry in the main block table*/ - int last; - - if ((block_index < 0) || - (block_index >= ISHM_MAX_NB_BLOCKS) || - (ishm_tbl->block[block_index].len == 0)) { - ODP_ERR("Request to free an invalid block\n"); - return -1; - } - - block = &ishm_tbl->block[block_index]; - - proc_index = procfind_block(block_index); - if (proc_index >= 0) { - /* close the related fd */ - close(ishm_proctable->entry[proc_index].fd); - - /* remove the mapping and possible fragment */ - do_unmap(ishm_proctable->entry[proc_index].start, - block->len, - ishm_proctable->entry[proc_index].flags, - block_index); - - /* remove entry from process local table: */ - last = ishm_proctable->nb_entries - 1; - ishm_proctable->entry[proc_index] = - ishm_proctable->entry[last]; - ishm_proctable->nb_entries = last; - } else { - /* just possibly free the fragment as no mapping exist here: */ - do_unmap(NULL, 0, block->flags, block_index); - } - - /* remove all files related to this block: */ - delete_file(block); - - /* deregister the file descriptor from the file descriptor server. */ - _odp_fdserver_deregister_fd(FD_SRV_CTX_ISHM, block_index); - - /* mark the block as free in the main block table: */ - block->len = 0; - - /* mark the change so other processes see this entry as obsolete: */ - block->seq++; - - return 0; + return block_free_internal(block_index, 1, 1); } /* ----------------------------------------------------------------------- Summary of changes: platform/linux-generic/odp_ishm.c | 112 ++++++++++++++++++++++---------------- 1 file changed, 64 insertions(+), 48 deletions(-) hooks/post-receive --

6 years

1
0
0 0

[COMMIT] branch master updated. v1.18.0.1_tigermoth_rc3-54-g52ea8d51

by git＠git-us.linaro.org

This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "". The branch, master has been updated via 52ea8d51d522d7013f746748bf84bfc2e9bc042c (commit) from b7ee13d765e5d8da1ef68f0c0777cb5e40fffbf7 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 52ea8d51d522d7013f746748bf84bfc2e9bc042c Author: Josep Puigdemont <josep.puigdemont(a)linaro.org> Date: Wed Apr 11 10:35:22 2018 +0200 linux-gen: fdserver: mask signals we don't need Make fdserver block all signals except those we are interested in, or those that can't be masked, and set default handlers for those left, thus preventing fdserver from executing any signal handlers that the application may have installed prior to forking this process. Signed-off-by: Josep Puigdemont <josep.puigdemont(a)linaro.org> Reviewed-by: Janne Peltonen <janne.peltonen(a)nokia.com> Signed-off-by: Maxim Uvarov <maxim.uvarov(a)linaro.org> diff --git a/platform/linux-generic/odp_fdserver.c b/platform/linux-generic/odp_fdserver.c index 9562ea0c..c88c71cd 100644 --- a/platform/linux-generic/odp_fdserver.c +++ b/platform/linux-generic/odp_fdserver.c @@ -647,6 +647,34 @@ int _odp_fdserver_init_global(void) } if (server_pid == 0) { /*child */ + sigset_t sigset; + struct sigaction action; + + sigfillset(&sigset); + /* undefined if these are ignored, as per POSIX */ + sigdelset(&sigset, SIGFPE); + sigdelset(&sigset, SIGILL); + sigdelset(&sigset, SIGSEGV); + /* can not be masked */ + sigdelset(&sigset, SIGKILL); + sigdelset(&sigset, SIGSTOP); + /* these we want to handle */ + sigdelset(&sigset, SIGTERM); + if (sigprocmask(SIG_SETMASK, &sigset, NULL) == -1) { + ODP_ERR("Could not set signal mask"); + exit(1); + } + + /* set default handlers for those signals we can handle */ + memset(&action, 0, sizeof(action)); + action.sa_handler = SIG_DFL; + sigemptyset(&action.sa_mask); + action.sa_flags = 0; + sigaction(SIGFPE, &action, NULL); + sigaction(SIGILL, &action, NULL); + sigaction(SIGSEGV, &action, NULL); + sigaction(SIGTERM, &action, NULL); + /* TODO: pin the server on appropriate service cpu mask */ /* when (if) we can agree on the usage of service mask */ ----------------------------------------------------------------------- Summary of changes: platform/linux-generic/odp_fdserver.c | 28 ++++++++++++++++++++++++++++ 1 file changed, 28 insertions(+) hooks/post-receive --

6 years

1
0
0 0

2024

2023

2022

2021

2020

2019

2018

2017

2016

git-lng-odp April 2018