This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "".
The branch, master has been updated via a8e5a8f6853ddc998430d112c22994928ddb4070 (commit) from 09abf90268a0a5a2daf7c7e0ae37a2d7c35e87c5 (commit)
Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below.
- Log ----------------------------------------------------------------- commit a8e5a8f6853ddc998430d112c22994928ddb4070 Author: Maxim Uvarov maxim.uvarov@linaro.org Date: Thu Sep 8 18:53:00 2016 +0300
linux-gen: pktio: ipc: remove todos
Remove todo around copying packet data from shared pool as it's not a bug and can be considered as future request. But left small comment that we coping packet data to make it more visible. https://bugs.linaro.org/show_bug.cgi?id=2408
Signed-off-by: Maxim Uvarov maxim.uvarov@linaro.org Reviewed-by: Mike Holmes mike.holmes@linaro.org
diff --git a/platform/linux-generic/pktio/ipc.c b/platform/linux-generic/pktio/ipc.c index b779ab7..c1f28db 100644 --- a/platform/linux-generic/pktio/ipc.c +++ b/platform/linux-generic/pktio/ipc.c @@ -373,11 +373,6 @@ static int _ipc_slave_start(pktio_entry_t *pktio_entry) pinfo->master.mdata_offset; pktio_entry->s.ipc.pkt_size = pinfo->master.shm_pkt_size;
- /* @todo: to simplify in odp-linux implementation we create pool for - * packets from IPC queue. On receive implementation copies packets to - * that pool. Later we can try to reuse original pool without packets - * copying. (pkt refcounts needs to be implemented). - */ _ipc_export_pool(pinfo, pktio_entry->s.ipc.pool);
odp_atomic_store_u32(&pktio_entry->s.ipc.ready, 1); @@ -573,7 +568,7 @@ static int ipc_pktio_recv_lockless(pktio_entry_t *pktio_entry, (PKTIO_TYPE_IPC_SLAVE == pktio_entry->s.ipc.type));
- /* @todo fix copy packet!!! */ + /* Copy packet data from shared pool to local pool. */ memcpy(pkt_data, remote_pkt_data, phdr.frame_len);
/* Copy packets L2, L3 parsed offsets and size */
-----------------------------------------------------------------------
Summary of changes: platform/linux-generic/pktio/ipc.c | 7 +------ 1 file changed, 1 insertion(+), 6 deletions(-)
hooks/post-receive