This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "".
The branch, master has been updated via b6a5e7039cc23e4547b11b78a12ba7f9efe6ae93 (commit) via 4c759ad5c0a4d1ece38b5cd93c24faddee9d5292 (commit) from 014a7fab6a34aacb061e53cc0b14d12aa119b03a (commit)
Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below.
- Log ----------------------------------------------------------------- commit b6a5e7039cc23e4547b11b78a12ba7f9efe6ae93 Author: Nikhil Agarwal nikhil.agarwal@linaro.org Date: Fri Jul 29 20:08:58 2016 +0530
api:crypto: resolve todo items
odp_session_proc_info_t is no longer required. Clarified hash_result_offset and its relation with ICV value.
Signed-off-by: Nikhil Agarwal nikhil.agarwal@linaro.org Reviewed-by: Bill Fischofer bill.fischofer@linaro.org Signed-off-by: Maxim Uvarov maxim.uvarov@linaro.org
diff --git a/include/odp/api/spec/crypto.h b/include/odp/api/spec/crypto.h index d8123e9..dea1fe9 100644 --- a/include/odp/api/spec/crypto.h +++ b/include/odp/api/spec/crypto.h @@ -170,8 +170,6 @@ typedef struct odp_crypto_data_range {
/** * Crypto API session creation parameters - * - * @todo Add "odp_session_proc_info_t" */ typedef struct odp_crypto_session_params { odp_crypto_op_t op; /**< Encode versus decode */ @@ -210,8 +208,6 @@ typedef struct odp_crypto_session_params {
/** * Crypto API per packet operation parameters - * - * @todo Clarify who zero's ICV and how this relates to "hash_result_offset" */ typedef struct odp_crypto_op_params { odp_crypto_session_t session; /**< Session handle from creation */ @@ -245,6 +241,14 @@ typedef struct odp_crypto_op_params { * indicates the caller wishes the destination packet buffer be allocated * from the output pool specified during session creation. * + * @var odp_crypto_op_params_t::hash_result_offset + * + * Specifies the offset where the hash result is to be stored. In case of + * decode sessions, input hash values will be read from this offset, and + * overwritten with hash results. If this offset lies within specified + * auth_range, implementation will mute this field before calculating the hash + * result. + * * @sa odp_crypto_session_params_t::output_pool. */
commit 4c759ad5c0a4d1ece38b5cd93c24faddee9d5292 Author: Nikhil Agarwal nikhil.agarwal@linaro.org Date: Fri Jul 29 20:08:57 2016 +0530
example:ipsec: removed invalid todos.
This todo item is no longer valid. Fixed as a part of following work card. https://cards.linaro.org/browse/LNG-857
Signed-off-by: Nikhil Agarwal nikhil.agarwal@linaro.org Reviewed-by: Bill Fischofer bill.fischofer@linaro.org Signed-off-by: Maxim Uvarov maxim.uvarov@linaro.org
diff --git a/example/ipsec/odp_ipsec_stream.h b/example/ipsec/odp_ipsec_stream.h index ea480c3..6f6f7df 100644 --- a/example/ipsec/odp_ipsec_stream.h +++ b/example/ipsec/odp_ipsec_stream.h @@ -93,10 +93,6 @@ odp_packet_t create_ipv4_packet(stream_db_entry_t *stream, /** * Verify an IPv4 packet received on a loop output queue * - * @todo Better error checking, add counters, add tracing, - * remove magic numbers, add order verification - * (see https://bugs.linaro.org/show_bug.cgi?id=620) - * * @param stream Stream to verify the packet against * @param pkt Packet to verify *
-----------------------------------------------------------------------
Summary of changes: example/ipsec/odp_ipsec_stream.h | 4 ---- include/odp/api/spec/crypto.h | 12 ++++++++---- 2 files changed, 8 insertions(+), 8 deletions(-)
hooks/post-receive