This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "".

The branch, master has been updated via 813cd2df67ae0591b0f792eff82854c5c9c642ca (commit) via 48f8503baf847315dda6609abc01f5befe6e0284 (commit) via b1100fdba29d8f514236dbcfd6f17e7941c0256a (commit) via f96a21992e13cf401a3494f2caeec9d42f56f0d9 (commit) via 1e925d0ccc7340575ddcfa07ab7bd372d751e006 (commit) from c9d31f30ba4fd7818b4ba2ffd7bbaea74761a2d9 (commit)

Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below.

- Log ----------------------------------------------------------------- commit 813cd2df67ae0591b0f792eff82854c5c9c642ca Author: Bill Fischofer bill.fischofer@linaro.org Date: Mon Apr 9 09:49:56 2018 -0500

example: l2fwd: update readme regarding ordered queue usage

Update the README file to clarify the effect of using ordered queues with direct I/O or output interfaces supporting multiple queues.

Signed-off-by: Bill Fischofer bill.fischofer@linaro.org Reviewed-by: Janne Peltonen janne.peltonen@nokia.com Signed-off-by: Maxim Uvarov maxim.uvarov@linaro.org

diff --git a/example/l2fwd/README b/example/l2fwd/README index f6fdc01c..091d046e 100644 --- a/example/l2fwd/README +++ b/example/l2fwd/README @@ -5,3 +5,10 @@ Source code and Makefiles placed under test/performance/ directory. This L2 forwarding application can be used as example reference as well as performance test for different odp modes (direct, queue or scheduler with parallel, atomic or ordered queues). + +Note that this example is tuned for performance. As a result, when using +scheduled mode with direct packet I/O output or queued output with multiple +output queues, packet order is not guaranteed. To achieve guaranteed order, +use a single worker thread or output interfaces with single output +queues. Other examples of scalable processing using ordered queues that +preserve order can be seen in the odp_pktio_ordered performance test.

commit 48f8503baf847315dda6609abc01f5befe6e0284 Author: Josep Puigdemont josep.puigdemont@linaro.org Date: Mon Apr 9 13:45:25 2018 +0200

fdserver: change session ID after fork

This is to avoid the fdserver process from handling signals sent to the process group. This patch partly fixes: https://bugs.linaro.org/show_bug.cgi?id=3690

Signed-off-by: Josep Puigdemont josep.puigdemont@linaro.org Suggested-by: Janne Peltonen janne.peltonen@nokia.com Reviewed-by: Bill Fischofer bill.fischofer@linaro.org Signed-off-by: Maxim Uvarov maxim.uvarov@linaro.org

diff --git a/platform/linux-generic/odp_fdserver.c b/platform/linux-generic/odp_fdserver.c index a06fb508..9562ea0c 100644 --- a/platform/linux-generic/odp_fdserver.c +++ b/platform/linux-generic/odp_fdserver.c @@ -654,6 +654,12 @@ int _odp_fdserver_init_global(void) /* orphans being "adopted" by the init process... */ prctl(PR_SET_PDEATHSIG, SIGTERM);

+ res = setsid(); + if (res == -1) { + ODP_ERR("Could not setsid()"); + exit(1); + } + /* allocate the space for the file descriptor<->key table: */ fd_table = malloc(FDSERVER_MAX_ENTRIES * sizeof(fdentry_t)); if (!fd_table) {

commit b1100fdba29d8f514236dbcfd6f17e7941c0256a Author: Josep Puigdemont josep.puigdemont@linaro.org Date: Thu Apr 12 14:07:30 2018 +0200

linux-gen: shm: be consistent with rest of the code

We should be consistent and use new_block as in the rest of the function, instead of accessing the array of blocks using an index.

Signed-off-by: Josep Puigdemont josep.puigdemont@linaro.org Signed-off-by: Bill Fischofer bill.fischofer@linaro.org Signed-off-by: Maxim Uvarov maxim.uvarov@linaro.org

diff --git a/platform/linux-generic/odp_ishm.c b/platform/linux-generic/odp_ishm.c index 282c39e8..a1a90424 100644 --- a/platform/linux-generic/odp_ishm.c +++ b/platform/linux-generic/odp_ishm.c @@ -566,7 +566,7 @@ static void *do_map(int block_index, uint64_t len, uint32_t align, } return NULL; } - ishm_tbl->block[block_index].fragment = fragment; + new_block->fragment = fragment; }

/* try to mmap: */

commit f96a21992e13cf401a3494f2caeec9d42f56f0d9 Author: Josep Puigdemont josep.puigdemont@linaro.org Date: Thu Apr 12 13:49:00 2018 +0200

linux-gen: shm: do not close provided file descriptors

If we provide a file descriptor to _odp_ishm_reserve, this function should not close them. It's the responsibility of the caller to decide what to do with the file descriptor if the return value indicates an error.

Signed-off-by: Josep Puigdemont josep.puigdemont@linaro.org Signed-off-by: Bill Fischofer bill.fischofer@linaro.org Signed-off-by: Maxim Uvarov maxim.uvarov@linaro.org

diff --git a/platform/linux-generic/odp_ishm.c b/platform/linux-generic/odp_ishm.c index 18255678..282c39e8 100644 --- a/platform/linux-generic/odp_ishm.c +++ b/platform/linux-generic/odp_ishm.c @@ -831,7 +831,6 @@ int _odp_ishm_reserve(const char *name, uint64_t size, int fd, /* If a file descriptor is provided, get the real size and map: */ if (fd >= 0) { if (fstat(fd, &statbuf) < 0) { - close(fd); odp_spinlock_unlock(&ishm_tbl->lock); ODP_ERR("_ishm_reserve failed (fstat failed: %s).\n", strerror(errno)); @@ -844,7 +843,6 @@ int _odp_ishm_reserve(const char *name, uint64_t size, int fd, * page is determined by the provided file descriptor: */ addr = do_map(new_index, len, align, flags, EXTERNAL, &fd); if (addr == NULL) { - close(fd); odp_spinlock_unlock(&ishm_tbl->lock); ODP_ERR("_ishm_reserve failed.\n"); return -1;

commit 1e925d0ccc7340575ddcfa07ab7bd372d751e006 Author: Josep Puigdemont josep.puigdemont@linaro.org Date: Thu Apr 12 13:53:48 2018 +0200

linux-gen: shm: fill data used in do_map before the call

do_map() checks the block's external_fd field to find out whether the file descriptor provided was allocated externally or not, before closing it in case an error occurred. However, this field was only updated _after_ calling the do_map() function. Fix this.

Signed-off-by: Josep Puigdemont josep.puigdemont@linaro.org Signed-off-by: Bill Fischofer bill.fischofer@linaro.org Signed-off-by: Maxim Uvarov maxim.uvarov@linaro.org

diff --git a/platform/linux-generic/odp_ishm.c b/platform/linux-generic/odp_ishm.c index 5f5e5eef..18255678 100644 --- a/platform/linux-generic/odp_ishm.c +++ b/platform/linux-generic/odp_ishm.c @@ -839,6 +839,7 @@ int _odp_ishm_reserve(const char *name, uint64_t size, int fd, return -1; } len = statbuf.st_size; + new_block->external_fd = 1; /* note that the huge page flag is meningless here as huge * page is determined by the provided file descriptor: */ addr = do_map(new_index, len, align, flags, EXTERNAL, &fd); @@ -849,7 +850,6 @@ int _odp_ishm_reserve(const char *name, uint64_t size, int fd, return -1; } new_block->huge = EXTERNAL; - new_block->external_fd = 1; } else { new_block->external_fd = 0; }

-----------------------------------------------------------------------

Summary of changes: example/l2fwd/README | 7 +++++++ platform/linux-generic/odp_fdserver.c | 6 ++++++ platform/linux-generic/odp_ishm.c | 6 ++---- 3 files changed, 15 insertions(+), 4 deletions(-)

hooks/post-receive