12 Aug
2014
12 Aug
'14
3:47 p.m.
On Tue, Aug 12, 2014 at 3:40 PM, gaurav.minocha@alumni.ubc.ca gaurav.minocha@alumni.ubc.ca wrote:
Hi Grant,
You're right, I haven't. Considering the fact that changes were minimal, so I planned to fix it in the third patch that was meant to attach the device tree if no live tree is present. So, have been waiting for your review on the same.
I reviewed the patch this morning. You should have my comments and the fixups I've done. You can roll the fixups into your patch before you repost.
Please let me know if you need a separate patch for the same.
A separate patch would be good. It is good practice for each patch to do exactly one thing. I would only put them into a single patch if the two issues were tightly intertwined.
g.