On Tue, 27 Aug 2019 at 19:47, Jarkko Sakkinen jarkko.sakkinen@linux.intel.com wrote:
On Wed, Aug 21, 2019 at 06:29:05PM +0530, Sumit Garg wrote:
+// SPDX-License-Identifier: GPL-2.0-only +/*
- Copyright (C) 2004 IBM Corporation
- Copyright (C) 2014 Intel Corporation
Everything below can be dropped from this new file. Git has the most accurate authority information.
I'm not sure why I added the authors-list in the first place to the header when I implemented these functions as none of those folks have contributed to this particular piece of work.
- Authors:
- Leendert van Doorn leendert@watson.ibm.com
- Dave Safford safford@watson.ibm.com
- Reiner Sailer sailer@watson.ibm.com
- Kylene Hall kjhall@us.ibm.com
- Maintained by: tpmdd-devel@lists.sourceforge.net
- Trusted Keys code for TCG/TCPA TPM2 (trusted platform module).
- */
To summarize, I think this would be sufficient:
// SPDX-License-Identifier: GPL-2.0-only /*
- Copyright (C) 2004 IBM Corporation
- Copyright (C) 2014 Intel Corporation
*/
Sounds good to me.
I think there should never be such a rush that acronym could not be written with the correct spelling. I'm referring to 'tpm2' in the short summary.
So you mean to say we should use upper-case letters for 'TPM2' acronym?
I'm sorry, I had to say it, just can't help myself with those kind of details :-) I can take care of fixing those once I apply these patches.
You've done an awesome job. Thank you.
You are welcome.
Reviewed-by: Jarkko Sakkinen jarkko.sakkinen@linux.intel.com
Thanks for your review.
-Sumit
Unfortunately I'm not yet sure if I have time to test these before going to Linux Plumbers but these would be anyway too close to the next merge window to be added to the v5.4 PR.
/Jarkko