On 01/08/2018 11:04 PM, Viresh Kumar wrote:
On 08-01-18, 16:11, Patrick Bellasi wrote:
On 05-Jan 16:13, Viresh Kumar wrote:
I don't have access to this report... just sent a requests.
I thought I shared it correctly earlier but looks like it was set to "Anyone with link from Linaro". Fixed it now.
How to replicate setup:
Android kernel tree: https://git.linaro.org/people/vireshk/mylinux.git android-4.9-hikey
This has several patches over latest 4.9-hikey aosp tree.
Some patches to reduce disturbances, which Vincent shared earlier with a document.
"thermal: Add debugfs support for cooling devices" and "cpufreq: stats: New sysfs attribute for clearing statistics" are used to read some more data from userspace after tests are done which can be used to build conclusions on working of pelt/walt and how they are behaving differently.
For example, we can know the amount of time we spent on individual cpu frequencies while the test was running. And also the time for which cpu-cooling and devfreq (ddr) has throttled some frequencies.
Pelt 16 and pelt 8 patches.
Are those the patches I've shared few weeks ago, on top of util_est?
http://www.linux-arm.org/git?p=linux-pb.git%3Ba=shortlog%3Bh=refs/heads/eas/...
Ah no. I never saw yours and created my own :)
I even uploaded a very similar patch for inclusion in the Android tree yesterday.
https://android-review.googlesource.com/c/kernel/common/+/581203
Just reinvented the wheel it seems :(
Kinda offtopic, but chiming in because I've had enough people rant about this to me:
I know this isn't an intentional reinvention. But even for an unintentional case, I would recommend going back to Patrick's patches for future profiling instead of reinventing similar functionality. I've had several people rant to me that upstream maintainers don't pick up the patches people send and instead rewrite it themselves. We shouldn't continue propagating that notion. The kernel will lose devs if that keeps happening.
Thanks, Saravana
-- Qualcomm Innovation Center, Inc. The Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, a Linux Foundation Collaborative Project