On Thu, Jun 02, 2016 at 01:18:07PM +0100, Jon Medhurst (Tixy) wrote:
If CONFIG_CPU_FREQ is not defined then we don't include a definition for struct sched_domain, which leads to a stream of build warnings and an error...
./arch/arm/include/asm/topology.h:33:48: warning: 'struct sched_domain' declared inside parameter list extern unsigned long scale_cpu_capacity(struct sched_domain *sd, int cpu); ^ ./arch/arm/include/asm/topology.h:33:48: warning: its scope is only this definition or declaration, which is probably not what you want arch/arm/kernel/topology.c:45:15: error: conflicting types for 'scale_cpu_capacity' unsigned long scale_cpu_capacity(struct sched_domain *sd, int cpu)
Signed-off-by: Jon Medhurst tixy@linaro.org
arch/arm/include/asm/topology.h | 1 + 1 file changed, 1 insertion(+)
diff --git a/arch/arm/include/asm/topology.h b/arch/arm/include/asm/topology.h index 94d3265..a6aa17b 100644 --- a/arch/arm/include/asm/topology.h +++ b/arch/arm/include/asm/topology.h @@ -28,6 +28,7 @@ const struct cpumask *cpu_coregroup_mask(int cpu); #include <linux/cpufreq.h> #define arch_scale_freq_capacity cpufreq_scale_freq_capacity #endif +struct sched_domain; #define arch_scale_cpu_capacity scale_cpu_capacity extern unsigned long scale_cpu_capacity(struct sched_domain *sd, int cpu);
Yes, arm64 has added it already. But arm has missed the definition.
-- 2.1.4
eas-dev mailing list eas-dev@lists.linaro.org https://lists.linaro.org/mailman/listinfo/eas-dev