Hi Vikram,
On Thu, Nov 17, 2016 at 03:06:24PM -0800, Vikram Mulukutla wrote:
Hi Leo,
On 11/16/2016 10:04 PM, Leo Yan wrote:
This patch series is to backport walt_prepare_migrate() and walt_finish_migrate() functions from Vikram latest WALT patch series [1] to Android common kernel 4.4.
We use these two functions to replace function walt_fixup_busy_time(), as result the scheduler will saperately acquire lock for source rq and destination rq and don't need use function double_lock_balance(). So this will let scheduler flows more safe due we can ensure atomicity by using walt_prepare_migrate() and walt_finish_migrate().
Thanks for Patrick and Vikram's suggestions for this.
Thanks for doing this; just one minor comment on the second patch. If you're testing with this series, please test suspend/resume, I may have seen a problem when I did a backport to our own internal 3.18 tree in the resume path, I didn't have time to debug then. I'll be happy to help with any debugging.
Thanks for reminding the suspend/resume testing. I did this testing on Hikey + kernel 4.4 with below command, have not found issue after run 10 times. So if you think other thing I should note, please let me know.
echo +3 > /sys/class/rtc/rtc0/wakealarm; echo mem > /sys/power/state
Thanks, Leo Yan
Leo Yan (3): sched/walt: port walt_{prepare|finish}_migrate() functions sched/core: fix atomicity broken issue sched/walt: remove walt_fixup_busy_time()
kernel/sched/core.c | 10 ++++--- kernel/sched/deadline.c | 8 ++++++ kernel/sched/fair.c | 4 +-- kernel/sched/rt.c | 4 +++ kernel/sched/walt.c | 75 +++++++++++++++++++++++++++++++++++++------------ kernel/sched/walt.h | 6 ++-- 6 files changed, 81 insertions(+), 26 deletions(-)
Thanks, Vikram _______________________________________________ eas-dev mailing list eas-dev@lists.linaro.org https://lists.linaro.org/mailman/listinfo/eas-dev