On 12-01-18, 15:37, Saravana Kannan wrote:
Kinda offtopic, but chiming in because I've had enough people rant about this to me:
:)
I know this isn't an intentional reinvention. But even for an unintentional case, I would recommend going back to Patrick's patches for future profiling instead of reinventing similar functionality. I've had several people rant to me that upstream maintainers don't pick up the patches people send and instead rewrite it themselves. We shouldn't continue propagating that notion. The kernel will lose devs if that keeps happening.
Well, this is something which is targeted just for Android right now and this isn't going to make me earn any BitCoins :). I wouldn't mind whose name gets on this patch and I am quite sure Patrick wouldn't either. It was too trivial of a patch.
Anyway, here is a short summary of events:
- Most of the content of this patch is obtained from Documentation/scheduler/sched-pelt.c, its too trivial otherwise.
- I believe the first version of this patch (in any form) was to move the period to 16 ms instead of 32 ms and that was done by Juri few years ago (while he was at ARM).
- I started playing with this stuff around 9th November and both me and Vincent had an internal patch we were sharing on this since then.
- Not sure when Patrick wrote his version of the patch, the date from his tree goes back to 21st November though.
Now even if both me and Patrick had our versions of this patch, anyone can come up and send his own patch for it to the lists or android tree and we can't object to that because: "We never posted our patch for review".
Anyway, @Patrick please feel free to post the patch for Android inclusion and I will review/verify/ack it and drop mine :)
-- viresh