Linaro-acpi July 2013

linaro-acpi@lists.linaro.org

12 participants
30 discussions

by Graeme Gregory

Hi Guys, I have detailed the steps I did to get our ACPI stuff running with EFI/GRUB2. https://wiki.linaro.org/LEG/Engineering/Kernel/ACPI/ACPIviaEFI And I have uploaded a demo tree which is our ACPI work on top of the lce_2013 branch of Leif. https://git.linaro.org/gitweb?p=people/graemegregory/linux.git;a=shortlog;h… Thanks Graeme

10 years, 9 months

GRUB add armacpi command to load blob.

by Graeme Gregory

Please find attached patch to add new armacpi command to grub. This will load the blob and do the correct thing to add it to the system configuration table. Graeme

10 years, 9 months

[PATCH 1/2] acpi: arm: allow relocation of tables passed from EFI

by Graeme Gregory

From: Graeme Gregory <graeme.gregory(a)linaro.org> Add handling for tables from EFI in addition to the handling already present for tables passed via FDT. Signed-off-by: Graeme Gregory <graeme.gregory(a)linaro.org> --- drivers/acpi/plat/arm/boot.c | 13 +++++++++---- 1 file changed, 9 insertions(+), 4 deletions(-) diff --git a/drivers/acpi/plat/arm/boot.c b/drivers/acpi/plat/arm/boot.c index 82b7bd6..9818ba1 100644 --- a/drivers/acpi/plat/arm/boot.c +++ b/drivers/acpi/plat/arm/boot.c @@ -746,13 +746,18 @@ void __init acpi_arm_blob_relocate(void) u32 ii; u64 *tmp; - if (!acpi_arm_rsdp_info.phys_address && !acpi_arm_rsdp_info.size) { - printk(KERN_ERR "(E) ACPI: failed to find rsdp info\n"); + if (efi.acpi20) + paddress = efi.acpi20; + else if (efi.acpi) + paddress = efi.acpi; + else if (acpi_arm_rsdp_info.phys_address && acpi_arm_rsdp_info.size) { + paddress = acpi_arm_rsdp_info.phys_address; + paddress += ACPI_BLOB_HEADER_SIZE; + } else { + pr_err("ACPI: failed to find rsdp info\n"); return; } - paddress = acpi_arm_rsdp_info.phys_address; - paddress += ACPI_BLOB_HEADER_SIZE; vaddress = phys_to_virt(paddress); /* fixups for the rsdp */ -- 1.7.10.4

10 years, 9 months

[PATCH] ARM/ACPI: remove yet another unneeded debug message

by al.stone＠linaro.org

From: Al Stone <ahs3(a)redhat.com> Signed-off-by: Al Stone <al.stone(a)linaro.org> --- drivers/acpi/acpica/tbutils.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/acpi/acpica/tbutils.c b/drivers/acpi/acpica/tbutils.c index 2b6d8dc..ce3d5db 100644 --- a/drivers/acpi/acpica/tbutils.c +++ b/drivers/acpi/acpica/tbutils.c @@ -634,7 +634,6 @@ acpi_tb_parse_root_table(acpi_physical_address rsdp_address) acpi_status status; ACPI_FUNCTION_TRACE(tb_parse_root_table); - printk(KERN_INFO "(I) entering acpi_tb_parse_root_table\n"); /* * Map the entire RSDP and extract the address of the RSDT or XSDT -- 1.8.1.4

10 years, 10 months

[PATCH] ARM: ACPI: for now add some dummies to make acpi_processor compile

by Graeme Gregory

From: Graeme Gregory <graeme.gregory(a)linaro.org> These dummies are copied directly from arm64 and will probably need corrected for arm. Signed-off-by: Graeme Gregory <graeme.gregory(a)linaro.org> --- arch/arm/include/asm/acpi.h | 12 ++++++++++++ 1 file changed, 12 insertions(+) diff --git a/arch/arm/include/asm/acpi.h b/arch/arm/include/asm/acpi.h index e752c5c..e5ac1b8 100644 --- a/arch/arm/include/asm/acpi.h +++ b/arch/arm/include/asm/acpi.h @@ -36,6 +36,9 @@ #define COMPILER_DEPENDENT_INT64 long long #define COMPILER_DEPENDENT_UINT64 unsigned long long +#define MAX_LOCAL_APIC 256 +#define MAX_IO_APICS 64 + /* * Calling conventions: * @@ -96,6 +99,13 @@ extern int acpi_noirq; extern int acpi_pci_disabled; extern int acpi_strict; +/* map logic cpu id to physical APIC id + * APIC = GIC cpu interface on ARM + */ +extern volatile int arm_cpu_to_apicid[NR_CPUS]; +extern int boot_cpu_apic_id; +#define cpu_physical_id(cpu) arm_cpu_to_apicid[cpu] + struct acpi_arm_root { phys_addr_t phys_address; unsigned long size; @@ -105,6 +115,8 @@ extern struct acpi_arm_root acpi_arm_rsdp_info; /* Low-level suspend routine. */ extern int acpi_suspend_lowlevel(void); +extern void prefill_possible_map(void); + /* Physical address to resume after wakeup */ /* BOZO: was... #define acpi_wakeup_address ((unsigned long)(real_mode_header->wakeup_start)) -- 1.7.10.4

10 years, 10 months

[PATCH 00/10] ARM64 / ACPI: Prototype for cpu hot-plug

by Hanjun Guo

Here is the first version of prototype for cpu-hotplug on ARM64. The first part is patch 1~3 for MADT parse. MADT is being parsed and the cpu possible map and cpu present map are prefilled. I kept the terminology consistent with x86 as Al and Andrea's advice. CPU possible map is equal to the GIC entries in MADT no matter enabled or disabled, and cpu present map limits to the enabled cpu in MADT. This is the base for cpu hot-plug. The second part is patch 4~10 for ACPI cpu hot-plug drivers. ACPI driver for CPU hot-plug is implemented in this part, when the cpu logical online/offline is ready, the cpu hot-plug can work on arm64. Please give some comments, thanks. Hanjun Guo (10): ARM64 / ACPI: MADT for armv8 foundation model ARM64 / ACPI: Core functions for MADT parse ARM64 / ACPI: Prefill cpu possible and present maps and map logical cpu id to APIC id ARM64 / ACPI: Declare processors in ACPI namespace in the DSDT ARM64 / ACPI: Introduce map_gic_id() to get apic id from MADT or _MAT method ARM64 / ACPI: Get logic cpu id to see if the cpu is a new added cpu ARM64 / ACPI: Implement acpi_map/unmap_lsapic for cpu hot-plug ARM64 / ACPI: Fix the variable declared but not defined ARM64 / ACPI: Introduce arch_register/unregister_cpu() for arm64 ARM64 / CPU hot-plug: Skeleton logic cpu online/offline for cpu hot-plug arch/arm64/Kconfig | 7 + arch/arm64/boot/asl/foundation-v8.acpi/apic.asl | 165 +++++++------ arch/arm64/boot/asl/foundation-v8.acpi/dsdt.asl | 205 +++++++++++++++- arch/arm64/include/asm/acpi.h | 12 + arch/arm64/include/asm/cpu.h | 5 + arch/arm64/include/asm/smp.h | 3 + arch/arm64/kernel/setup.c | 16 +- arch/arm64/kernel/smp.c | 23 ++ arch/arm64/kernel/topology.c | 26 +++ drivers/acpi/plat/arm/boot.c | 286 +++++++++++++++++++++-- drivers/acpi/processor_core.c | 50 ++-- drivers/acpi/tables.c | 21 ++ 12 files changed, 694 insertions(+), 125 deletions(-) -- 1.7.9.5

10 years, 10 months

[PATCH] ARM: ACPI: exynos5250-arndale fix DSDT for cpu definitions

by Graeme Gregory

From: Graeme Gregory <graeme.gregory(a)linaro.org> This file was mismerged scope \_PR should have been removed and SCK0 should have been in scope \_SB. Signed-off-by: Graeme Gregory <graeme.gregory(a)linaro.org> Reported-by: Hanjun Guo <hanjun.guo(a)linaro.org> --- arch/arm/boot/asl/exynos5250-arndale.acpi/dsdt.asl | 118 ++++++++++---------- 1 file changed, 56 insertions(+), 62 deletions(-) diff --git a/arch/arm/boot/asl/exynos5250-arndale.acpi/dsdt.asl b/arch/arm/boot/asl/exynos5250-arndale.acpi/dsdt.asl index c67aeec..2cca765 100644 --- a/arch/arm/boot/asl/exynos5250-arndale.acpi/dsdt.asl +++ b/arch/arm/boot/asl/exynos5250-arndale.acpi/dsdt.asl @@ -14,12 +14,6 @@ DefinitionBlock ( "ARNDALE ", // table ID 0x00000002) // OEM revision { - Scope (\_PR) - { - Processor (CPU0, 0x01, 0x00000410, 0x06) {} - Processor (CPU1, 0x02, 0x00000410, 0x06) {} - } - Scope (\_SB) { Device (GPB3) { @@ -51,105 +45,105 @@ DefinitionBlock ( Return (20000) } } - } - - Device (SCK0) - { - Name (_HID, "ACPI0004") - Name (_UID, 0x00) - Method (_STA, 0, NotSerialized) - { - Return (0x0F) - } - Device (PRC0) + Device (SCK0) { - Name (_HID, "ACPI0007") + Name (_HID, "ACPI0004") Name (_UID, 0x00) - - /* CPU0 will be always present */ Method (_STA, 0, NotSerialized) { Return (0x0F) } - Name (MAT0, Buffer (0x28) + Device (PRC0) { + Name (_HID, "ACPI0007") + Name (_UID, 0x00) + + /* CPU0 will be always present */ + Method (_STA, 0, NotSerialized) + { + Return (0x0F) + } + + Name (MAT0, Buffer (0x28) + { /* 0000 */ 0x0B, 0x28, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, /* type, len, reserved, gic_id */ /* 0008 */ 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x01, /* uid, flags */ /* 0010 */ 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, /* parking_version, performance_interrupt */ /* 0018 */ 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, /* parked_address */ /* 0020 */ 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00 /* base_address */ - }) + }) - Name (MAT1, Buffer (0x28) - { + Name (MAT1, Buffer (0x28) + { /* 0000 */ 0x0B, 0x28, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, /* 0008 */ 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, /* 0010 */ 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, /* 0018 */ 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, /* 0020 */ 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00 - }) + }) - Method (_MAT, 0, NotSerialized) - { - If (_STA()) - { - Return (MAT0) - } - Else + Method (_MAT, 0, NotSerialized) { - Return (MAT1) + If (_STA()) + { + Return (MAT0) + } + Else + { + Return (MAT1) + } } } - } - Device (PRC1) - { - Name (_HID, "ACPI0007") - Name (_UID, 0x01) - - Name (STA1, 0x0F) - Method (_STA, 0, NotSerialized) + Device (PRC1) { - Return (STA1) - } + Name (_HID, "ACPI0007") + Name (_UID, 0x01) - Method (_EJ0, 1, NotSerialized) - { - If (LEqual (STA1, 0x0F)) + Name (STA1, 0x0F) + Method (_STA, 0, NotSerialized) { - Store (0x00, STA1) + Return (STA1) } - } - Name (MAT0, Buffer (0x28) - { + Method (_EJ0, 1, NotSerialized) + { + If (LEqual (STA1, 0x0F)) + { + Store (0x00, STA1) + } + } + + Name (MAT0, Buffer (0x28) + { /* 0000 */ 0x0B, 0x28, 0x00, 0x00, 0x00, 0x00, 0x00, 0x01, /* type, len, reserved, gic_id */ /* 0008 */ 0x00, 0x00, 0x00, 0x01, 0x00, 0x00, 0x00, 0x01, /* uid, flags */ /* 0010 */ 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, /* parking_version, performance_interrupt */ /* 0018 */ 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, /* parked_address */ /* 0020 */ 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00 /* base_address */ - }) + }) - Name (MAT1, Buffer (0x28) - { + Name (MAT1, Buffer (0x28) + { /* 0000 */ 0x0B, 0x28, 0x00, 0x00, 0x00, 0x00, 0x00, 0x01, /* 0008 */ 0x00, 0x00, 0x00, 0x01, 0x00, 0x00, 0x00, 0x00, /* 0010 */ 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, /* 0018 */ 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, /* 0020 */ 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00 - }) + }) - Method (_MAT, 0, NotSerialized) - { - If (_STA()) - { - Return (MAT0) - } - Else + Method (_MAT, 0, NotSerialized) { - Return (MAT1) + If (_STA()) + { + Return (MAT0) + } + Else + { + Return (MAT1) + } } } } -- 1.7.10.4

10 years, 10 months

ACPI vs FDT Presentation

by Graeme Gregory

I have attached the slides, I never realised until doing this quite how buggy LibreOffice/OpenOffice is :-( Graeme

10 years, 10 months

[PATCH 0/5] Hanjuns CPU Topology patches

by Graeme Gregory

Hi Hanjun and others, I have rebased these patches on the 3.10rcX based tree and done a quick boot test and they don't cause any oopses. So I thought I would push them to the tree. Thanks Graeme

10 years, 10 months

[PATCH 0/8] APEI: injection of GHES error from userspace

by Tomasz Nowicki

We are able to inject GHES from userspace. Kernel can parse error status block and print error message in a more descriptive way: [...] [ 0.744715] GHES: APEI firmware first mode is enabled by APEI bit. [ 0.744749] EINJ: Error INJection is initialized. [...] # echo 0x20 > /sys/kernel/debug/apei/einj/error_inject [ 149.010380] {1}[Hardware Error]: Hardware error from APEI Generic Hardware Error Source: 2 [ 149.017080] {1}[Hardware Error]: APEI generic hardware error status [ 149.023217] {1}[Hardware Error]: severity: 1, fatal [ 149.027998] {1}[Hardware Error]: section: 0, severity: 0, recoverable [ 149.034317] {1}[Hardware Error]: flags: 0x00 [ 149.038501] {1}[Hardware Error]: section_type: memory error where 0x20 can be random error ID because of the hack. Please see following patches for more explanation.

10 years, 10 months

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

Linaro-acpi July 2013