Linaro-acpi October 2013

linaro-acpi@lists.linaro.org

11 participants
36 discussions

[PATCH 0/4 v2] Add tool to enable APEI tables test, other minor changes.

by Tomasz Nowicki

Patch set implement as follows: 1. Minor changes around existing tools - reorganize building process, - move common code to separate direction, - no functionality changes. 2. Add BFAPEI (Blob For APEI) tool which can create blobs for APEI testing. - see commit log for more details Changes for v2: - compilation regardless of whether APEI is used or not, - correct file name in comment headers, - move ACPI structures, defines, etc. to acpi.h headers, - suppress compiler warnings. Tomasz Nowicki (4): map, cab: Reorganize building process and tree hierarchy. bfapei: Add tool that can create blobs for APEI table testing. bfapei: Move generic ACPI structures to separated file, remove duplicated defines. Suppress compiler warnings, file comment headers cleanup. Makefile | 28 +- platforms/Makefile | 9 +- tools/bfapei/Makefile | 11 + tools/bfapei/bfapei.c | 271 +++++++++++++++++++ tools/bfapei/bfapei.h | 49 ++++ tools/cab/Makefile | 12 +- tools/cab/cab.c | 535 +------------------------------------- tools/cab/cab.h | 149 ----------- tools/common/Makefile | 4 + tools/common/build_aml.c | 455 ++++++++++++++++++++++++++++++++ tools/common/check_aml.c | 512 ++++++++++++++++++++++++++++++++++++ tools/common/include/acpi.h | 204 +++++++++++++++ tools/common/include/build_aml.h | 74 ++++++ tools/common/include/check_aml.h | 92 +++++++ tools/mab/Makefile | 13 +- tools/mab/mab.c | 437 +------------------------------ tools/mab/mab.h | 77 ------ 17 files changed, 1734 insertions(+), 1198 deletions(-) create mode 100644 tools/bfapei/Makefile create mode 100644 tools/bfapei/bfapei.c create mode 100644 tools/bfapei/bfapei.h create mode 100644 tools/common/Makefile create mode 100644 tools/common/build_aml.c create mode 100644 tools/common/check_aml.c create mode 100644 tools/common/include/acpi.h create mode 100644 tools/common/include/build_aml.h create mode 100644 tools/common/include/check_aml.h -- 1.7.9.5

7 years

[RFC PATCH 0/3] ACPI: Add vexpress-sysreg

by naresh.bhat＠linaro.org

From: Naresh Bhat <naresh.bhat(a)linaro.org> Add vexpress sysreg probe support, platform ID and remove dts binding. Logs on the v8 model are as below root@genericarmv8:/sys# find . -name LINA0009* ./bus/acpi/devices/LINA0009:00 ./bus/platform/devices/LINA0009:00 ./bus/platform/drivers/vexpress-sysreg/LINA0009:00 ./devices/platform/LINA0009:00 ./devices/LNXSYSTM:00/device:00/ACPI0004:01/ACPI0004:02/LINA0009:00 root@genericarmv8:/sys# Naresh Bhat (3): v2m_sysreg: Add ACPI probing for SYSREG ACPI: Add vexpress sysreg platform ID arm64: dts: remove the vexpress-sysreg binding arch/arm64/boot/dts/foundation-v8-acpi.dts | 6 +++--- drivers/acpi/acpi_platform.c | 3 ++- drivers/mfd/vexpress-sysreg.c | 9 +++++++++ 3 files changed, 14 insertions(+), 4 deletions(-) -- 1.7.9.5

9 years, 10 months

[RFC PATCH 0/2] ACPI: Remove fixed clock binding and add uart pl011 platform id

by naresh.bhat＠linaro.org

From: Naresh Bhat <naresh.bhat(a)linaro.org> Removed the fixed clock binding and add uart pl011 to platform ID table. Tested on v8 logs are as below root@genericarmv8:/sys# find . -name LINA* ./bus/acpi/devices/LINA0003:00 ./bus/acpi/devices/LINA0005:00 ./bus/acpi/devices/LINA0007:00 ./bus/acpi/devices/LINA0008:00 ./bus/acpi/devices/LINA0008:01 ./bus/acpi/devices/LINA0008:02 ./bus/acpi/devices/LINA0009:00 ./bus/acpi/devices/LINA000A:00 ./bus/acpi/devices/LINA000A:01 ./bus/acpi/devices/LINA000A:02 ./bus/acpi/devices/LINA000A:03 ./bus/amba/devices/LINA000A:00 ./bus/amba/devices/LINA000A:01 ./bus/amba/devices/LINA000A:02 ./bus/amba/devices/LINA000A:03 ./bus/amba/drivers/uart-pl011/LINA000A:00 ./bus/amba/drivers/uart-pl011/LINA000A:01 ./bus/amba/drivers/uart-pl011/LINA000A:02 ./bus/amba/drivers/uart-pl011/LINA000A:03 ./bus/platform/devices/LINA0003:00 ./bus/platform/devices/LINA0005:00 ./bus/platform/devices/LINA0007:00 ./bus/platform/devices/LINA0008:00 ./bus/platform/devices/LINA0008:01 ./bus/platform/devices/LINA0008:02 ./bus/platform/devices/LINA0009:00 ./bus/platform/drivers/vexpress-sysreg/LINA0009:00 ./bus/platform/drivers/smc91x/LINA0003:00 ./bus/platform/drivers/fixed-clk/LINA0008:00 ./bus/platform/drivers/fixed-clk/LINA0008:01 ./bus/platform/drivers/fixed-clk/LINA0008:02 ./bus/platform/drivers/arm-pmu/LINA0007:00 ./bus/platform/drivers/virtio-mmio/LINA0005:00 ./devices/platform/LINA0003:00 ./devices/platform/LINA0005:00 ./devices/platform/LINA0007:00 ./devices/platform/LINA0008:00 ./devices/platform/LINA0008:01 ./devices/platform/LINA0008:02 ./devices/platform/LINA0009:00 ./devices/platform/LINA000A:00 ./devices/platform/LINA000A:01 ./devices/platform/LINA000A:02 ./devices/platform/LINA000A:03 ./devices/LNXSYSTM:00/device:00/LINA0007:00 ./devices/LNXSYSTM:00/device:00/AMBA0000:00/LINA000A:00 ./devices/LNXSYSTM:00/device:00/AMBA0000:00/LINA000A:01 ./devices/LNXSYSTM:00/device:00/AMBA0000:00/LINA000A:02 ./devices/LNXSYSTM:00/device:00/AMBA0000:00/LINA000A:03 ./devices/LNXSYSTM:00/device:00/ACPI0004:01/LINA0003:00 ./devices/LNXSYSTM:00/device:00/ACPI0004:01/LINA0008:00 ./devices/LNXSYSTM:00/device:00/ACPI0004:01/LINA0008:01 ./devices/LNXSYSTM:00/device:00/ACPI0004:01/LINA0008:02 ./devices/LNXSYSTM:00/device:00/ACPI0004:01/ACPI0004:02/LINA0005:00 ./devices/LNXSYSTM:00/device:00/ACPI0004:01/ACPI0004:02/LINA0009:00 root@genericarmv8:/sys# Naresh Bhat (2): arm64: dts: remove the fixed clock binding ACPI: Add uart pl011 platform ID arch/arm64/boot/dts/foundation-v8-acpi.dts | 2 +- drivers/acpi/acpi_platform.c | 1 + 2 files changed, 2 insertions(+), 1 deletion(-) -- 1.7.9.5

10 years, 5 months

[RFC Resend PATCH 0/5] Convert the fixed clock to ACPI

by Hanjun Guo

This is the RFC version for converting the fixed clock to ACPI. Since the ACPI namespace is ok at the very late stage of system boot, so I did some major change in boot sequence for the enumeration of fixed clock, amba bus and its child device. I think this part should be review carefully. For DT, it works well for armv8 foudation model after the change in boot sequence, but the UART and amba bus are dependent on the fixed clock, if I only convert the fixed clock to ACPI, UART will not work. So this is the RFC version and the UART will be converted together in next version. Hanjun Guo (5): Driver / clk: add platform driver for fixed clock ACPI / ARM64: Whitelist the ACPI ID for fixed clock ACPI / platform: add some comments for internel registry of _HID names ACPI / fixed-clock: Add ACPI driver for fixed clock Clk / fixed clock: Delay the enumeration of fixed clock and make it popssible for ACPI arch/arm64/kernel/setup.c | 2 +- drivers/acpi/acpi_platform.c | 7 ++-- drivers/clk/clk-fixed-rate.c | 78 +++++++++++++++++++++++++++++++++++++++++- 3 files changed, 82 insertions(+), 5 deletions(-) -- 1.7.9.5

10 years, 5 months

[PATCH] ACPI: FDT: clean up unused variable in early_init_dt_scan_acpi

by al.stone＠linaro.org

From: Al Stone <ahs3(a)redhat.com> Signed-off-by: Al Stone <al.stone(a)linaro.org> --- drivers/of/fdt.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/of/fdt.c b/drivers/of/fdt.c index d1d17e0..6c4c937 100644 --- a/drivers/of/fdt.c +++ b/drivers/of/fdt.c @@ -797,7 +797,6 @@ int __init early_init_dt_scan_acpi(unsigned long node, const char *uname, unsigned long l; unsigned int *p; struct acpi_arm_root *pinfo; - unsigned char *sig; pr_debug("search \"chosen\" for acpi info, depth: %d, uname: %s\n", depth, uname); -- 1.8.3.1

10 years, 5 months

[PATCH] ACPI: ARM: stub out acpi_idle_play_dead properly

by al.stone＠linaro.org

From: Al Stone <ahs3(a)redhat.com> Signed-off-by: Al Stone <al.stone(a)linaro.org> --- drivers/acpi/processor_idle.c | 11 +++++++---- 1 file changed, 7 insertions(+), 4 deletions(-) diff --git a/drivers/acpi/processor_idle.c b/drivers/acpi/processor_idle.c index 587f3cf..e45f913 100644 --- a/drivers/acpi/processor_idle.c +++ b/drivers/acpi/processor_idle.c @@ -760,6 +760,7 @@ static int acpi_idle_enter_c1(struct cpuidle_device *dev, * @dev: the target CPU * @index: the index of suggested state */ +#ifdef CONFIG_X86 static int acpi_idle_play_dead(struct cpuidle_device *dev, int index) { struct acpi_processor_cx *cx = per_cpu(acpi_cstate[index], dev->cpu); @@ -767,9 +768,6 @@ static int acpi_idle_play_dead(struct cpuidle_device *dev, int index) ACPI_FLUSH_CPU_CACHE(); while (1) { - -#ifdef CONFIG_X86 - /* BOZO: abstract out? */ if (cx->entry_method == ACPI_CSTATE_HALT) safe_halt(); else if (cx->entry_method == ACPI_CSTATE_SYSTEMIO) { @@ -777,13 +775,18 @@ static int acpi_idle_play_dead(struct cpuidle_device *dev, int index) /* See comment in acpi_idle_do_entry() */ inl(acpi_gbl_FADT.xpm_timer_block.address); } else -#endif return -ENODEV; } /* Never reached */ return 0; } +#else +static int acpi_idle_play_dead(struct cpuidle_device *dev, int index) +{ + return 0; +} +#endif /** * acpi_idle_enter_simple - enters an ACPI state without BM handling -- 1.8.3.1

10 years, 5 months

[RFC PATCH 00/13 v2] Hardware Reduced Mode cleanup for ACPI

by al.stone＠linaro.org

From: Al Stone <ahs3(a)redhat.com> This series of patches starts with Hanjun's patch to create a kernel config item for CONFIG_ACPI_REDUCED_HARDWARE [0]. Building on that, I then reviewed all of the code that touched any of several fields in the FADT that the OSPM is supposed to ignore when ACPI is in Hardware Reduced mode [1]. Any time there was a use of one of the fields to be ignored, I evaluated whether or not the code was implementing Hardware Reduced mode correctly. Similarly, for each the flags in the FADT flags field that are to be ignored in Hardware Reduced mode, the kernel code was again scanned for proper usage. The remainder of the patches are to fix all of the situations I could find where the kernel would not behave correctly in this ACPI mode. These are being submitted as an RFC to the linaro-acpi@ list so I can get some other eyes looking at them before sending them to linux-acpi@ where they really need to go. These seem to work just fine on the RTSM model for ARMv7, both with and without ACPI enabled, and with and without ACPI_REDUCED_HARDWARE enabled. However, there's no way I can think of or test all possible scenarios so feedback would be greatly appreciated. Changes for v2: -- Change patch series title -- Add in the FACS global lock patch as further hardware reduced mode cleanup that is needed -- Remove whitespace change that should not have gotten in [1] Please see the ACPI Specification v5.0 for details on Hardware Reduced mode. [0] List at https://wiki.linaro.org/LEG/Engineering/Kernel/ACPI/AcpiReducedHw#Section_5… Al Stone (13): ACPI: introduce CONFIG_ACPI_REDUCED_HARDWARE to enable this ACPI mode ACPI: bus master reload is unsupported in ACPI reduced HW mode ACPI: clean up compiler warning about uninitialized field ACPI: HW reduced mode does not allow use of the FADT sci_interrupt field ACPI: ARM: exclude calls on ARM platforms, not include them on x86 ACPI: ensure several FADT fields are only used in HW reduced mode ACPI: do not reserve memory regions for some FADT entries in HW reduced mode ACPI: in HW reduced mode, getting power latencies from FADT is not allowed ACPI: add clarifying comment about processor throttling in HW reduced mode ACPI: ACPI_FADT_C2_MP_SUPPORTED must be ignored in HW reduced mode ACPI: use of ACPI_FADT_32BIT_TIMER is not allowed in HW reduced mode ACPI: correct #ifdefs so compiling without ACPI_REDUCED_HARDWARE works properly ACPI: ARM/ARM64: ensure the ACPI FACS global_lock is never used in HW reduced mode arch/arm/include/asm/acpi.h | 3 ++- arch/arm64/include/asm/acpi.h | 3 ++- drivers/acpi/Kconfig | 8 ++++++++ drivers/acpi/acpica/utxface.c | 3 ++- drivers/acpi/bus.c | 9 +++++---- drivers/acpi/osl.c | 28 ++++++++++++++++++++-------- drivers/acpi/pci_link.c | 14 ++++++++------ drivers/acpi/plat/arm/boot.c | 2 ++ drivers/acpi/processor_idle.c | 29 ++++++++++++++++++++++++----- drivers/acpi/processor_throttling.c | 8 ++++++++ drivers/acpi/sleep.c | 2 +- include/acpi/acconfig.h | 2 +- include/acpi/platform/aclinux.h | 6 ++++++ 13 files changed, 89 insertions(+), 28 deletions(-) -- 1.8.3.1

10 years, 5 months

Re: [Linaro-acpi] [PATCH 17/20] ACPICA: Simplify configuration of global ACPI_REDUCED_HARDWARE macro.

by Hanjun Guo

On 29 October 2013 09:30, Lv Zheng <lv.zheng(a)intel.com> wrote: > From: Bob Moore <robert.moore(a)intel.com> > > Surround definition of this with a #ifndef so that the kernel > can define it elsewhere if desired. > > Signed-off-by: Bob Moore <robert.moore(a)intel.com> > Signed-off-by: Lv Zheng <lv.zheng(a)intel.com> > Reviewed-by: Hanjun Guo <hanjun.guo(a)linaro.org> > --- > include/acpi/acconfig.h | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/include/acpi/acconfig.h b/include/acpi/acconfig.h > index 1c16f82..d98c670 100644 > --- a/include/acpi/acconfig.h > +++ b/include/acpi/acconfig.h > @@ -100,7 +100,9 @@ > * ACPI PM timer > * FACS table (Waking vectors and Global Lock) > */ > +#ifndef ACPI_REDUCED_HARDWARE > #define ACPI_REDUCED_HARDWARE FALSE > +#endif > > > /****************************************************************************** > * > -- > 1.7.10 > > -- > To unsubscribe from this list: send the line "unsubscribe linux-acpi" in > the body of a message to majordomo(a)vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html >

10 years, 5 months

[RFC PATCH 0/3] ACPI: ARM AMBA bus connector resource

by brandon.anderson＠amd.com

From: Brandon Anderson <brandon.anderson(a)amd.com> This is a proposal for ACPI driver probing of the ARM AMBA devices currently listed under ‘iofpga’ in the RTSM dts file. The main addition is drivers/amba/acpi.c which fits the role of an AMBA bus ‘connector resource’ for ACPI using struct amba_device. I have not yet figured out the implementation details regarding clocks (handled in the dts file with clock-names). However, I have included a proposed ASL format for clock information in the DSDT example below. With the last patch that hacks the clock info, this prototype will run on the Foundation and RTSM models. These patches require Hanjun’s fixed-clock patches to be applied first on top of a Linaro ACPI kernel: https://git.linaro.org/gitweb?p=arm/acpi/leg-kernel.git;a=summary Please comment on both the concept and the implementation. Brandon Anderson (3): Remove UART and KMI entries from DTS file Prototype of AMBA bus 'connector resource' for ACPI Hack clock names to get prototype running arch/arm64/boot/dts/foundation-v8-acpi.dts | 10 +- arch/arm64/boot/dts/rtsm_ve-aemv8a-acpi.dts | 4 + arch/arm64/boot/dts/rtsm_ve-motherboard-acpi.dtsi | 4 + drivers/acpi/acpi_platform.c | 2 + drivers/amba/Makefile | 2 +- drivers/amba/acpi.c | 172 +++++++++++++++++++++ drivers/clk/clk-fixed-rate.c | 15 +- 7 files changed, 203 insertions(+), 6 deletions(-) create mode 100644 drivers/amba/acpi.c -- 1.7.9.5 --- Device (AMBA) { Name (_HID, "AMBA0000") /* the parallel to "arm,primecell" in DTS */ Name (_UID, 0) /* Define 'apb_pclk' as a default clock source since it is common with devices below */ Method(_DSM, 4, NotSerialized) { Store (Package (3) { "clock-name", "apb_pclk", "\\_SB_.CLK0", }, Local0) Return (Local0) } Device (KMI0) { Name (_ADR,0x1c060000) Method (_CRS, 0x0, Serialized) { Name (RBUF, ResourceTemplate () { Memory32Fixed (ReadWrite, 0x1c060000, 0x00010000) Interrupt (ResourceConsumer, Edge, ActiveBoth, Exclusive, , , ) {44} }) Return (RBUF) } } Device (KMI1) { Name (_ADR,0x1c070000) Method (_CRS, 0x0, Serialized) { Name (RBUF, ResourceTemplate () { Memory32Fixed (ReadWrite, 0x1c070000, 0x00010000) Interrupt (ResourceConsumer, Edge, ActiveBoth, Exclusive, , , ) {45} }) Return (RBUF) } } Device (SER0) { Name (_ADR,0x1c090000) // UART0 Method (_CRS, 0x0, Serialized) { Name (RBUF, ResourceTemplate () { Memory32Fixed (ReadWrite, 0x1c090000, 0x00010000) Interrupt (ResourceConsumer, Edge, ActiveBoth, Exclusive, , , ) {37} }) Return (RBUF) } } Device (SER1) { Name (_ADR,0x1c0a0000) // UART1 Method (_CRS, 0x0, Serialized) { Name (RBUF, ResourceTemplate () { Memory32Fixed (ReadWrite, 0x1c0a0000, 0x00010000) Interrupt (ResourceConsumer, Edge, ActiveBoth, Exclusive, , , ) {38} }) Return (RBUF) } } Device (SER2) { Name (_ADR,0x1c0b0000) // UART2 Method (_CRS, 0x0, Serialized) { Name (RBUF, ResourceTemplate () { Memory32Fixed (ReadWrite, 0x1c0b0000, 0x00010000) Interrupt (ResourceConsumer, Edge, ActiveBoth, Exclusive, , , ) {39} }) Return (RBUF) } } Device (SER3) { Name (_ADR,0x1c0c0000) // UART3 Method (_CRS, 0x0, Serialized) { Name (RBUF, ResourceTemplate () { Memory32Fixed (ReadWrite, 0x1c0c0000, 0x00010000) Interrupt (ResourceConsumer, Edge, ActiveBoth, Exclusive, , , ) {40} }) Return (RBUF) } } }

10 years, 6 months

[PATCH] ACPI: ARM: define acpi_suspend_lowlevel() properly to eliminate compiler warning

by al.stone＠linaro.org

From: Al Stone <ahs3(a)redhat.com> This function was not defined as a pointer to a function but as a function. This resulted in a "test is always true" warning in drivers/acpi/sleep.c where it tested for the existence of the function. Signed-off-by: Al Stone <al.stone(a)linaro.org> --- arch/arm/include/asm/acpi.h | 2 +- arch/arm64/include/asm/acpi.h | 2 +- drivers/acpi/plat/arm/sleep.c | 11 +++++++++-- 3 files changed, 11 insertions(+), 4 deletions(-) diff --git a/arch/arm/include/asm/acpi.h b/arch/arm/include/asm/acpi.h index ca7efaa..31f21fd 100644 --- a/arch/arm/include/asm/acpi.h +++ b/arch/arm/include/asm/acpi.h @@ -115,7 +115,7 @@ extern struct acpi_arm_root acpi_arm_rsdp_info; void arm_acpi_reserve_memory(void); /* Low-level suspend routine. */ -extern int acpi_suspend_lowlevel(void); +extern int (*acpi_suspend_lowlevel)(void); extern void prefill_possible_map(void); diff --git a/arch/arm64/include/asm/acpi.h b/arch/arm64/include/asm/acpi.h index a19b73f..aee7190 100644 --- a/arch/arm64/include/asm/acpi.h +++ b/arch/arm64/include/asm/acpi.h @@ -93,7 +93,7 @@ extern struct acpi_arm_root acpi_arm_rsdp_info; void arm_acpi_reserve_memory(void); /* Low-level suspend routine. */ -extern int acpi_suspend_lowlevel(void); +extern int (*acpi_suspend_lowlevel)(void); extern void prefill_possible_map(void); diff --git a/drivers/acpi/plat/arm/sleep.c b/drivers/acpi/plat/arm/sleep.c index 9129c7e..ac5e343 100644 --- a/drivers/acpi/plat/arm/sleep.c +++ b/drivers/acpi/plat/arm/sleep.c @@ -1,15 +1,22 @@ /* - * sleep.c - x86-specific ACPI sleep support. + * sleep.c - ARM-specific ACPI sleep support. * * Copyright (C) 2001-2003 Patrick Mochel * Copyright (C) 2001-2003 Pavel Machek <pavel(a)ucw.cz> */ +#ifdef CONFIG_ACPI_SLEEP int acpi_suspend_lowlevel(void) { - /* BOZO: dummy routine; see below for actual */ + /* + * TODO: connect this function to PSCI when it becomes available, + * and if actually needed. + */ return 0; } +#else +int acpi_suspend_lowlevel(void); +#endif #ifdef CONFIG_X86 /* BOZO: disable everything for now... */ -- 1.8.3.1

10 years, 6 months

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

Linaro-acpi October 2013