Linaro-acpi September 2013

linaro-acpi@lists.linaro.org

20 participants
41 discussions

[PATCH 1/1] ACPI: Expand SCI_EMULATE patch toward more generic usage.

by Tomasz Nowicki

ACPI spec define that devices can be notified with some well defined values. Handlers from system list are called for notify values within 0-0x7F. In turn, handlers from device list are called for notify value greater than 0x80. Till now only system handler could be called. Now we are able to notify devices with all notify values range that means we can emulate SCI line e.g. to trigger APCI errors. Signed-off-by: Tomasz Nowicki <tomasz.nowicki(a)linaro.org> --- drivers/acpi/sci_emu.c | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/drivers/acpi/sci_emu.c b/drivers/acpi/sci_emu.c index 2f13ca1..08af8e9 100644 --- a/drivers/acpi/sci_emu.c +++ b/drivers/acpi/sci_emu.c @@ -55,7 +55,10 @@ static void sci_notify_client(char *acpi_name, u32 event) */ obj_desc = acpi_ns_get_attached_object(node); if (obj_desc) { - if (obj_desc->common_notify.notify_list[0]) { + if (((event <= ACPI_MAX_SYS_NOTIFY) && + obj_desc->common_notify.notify_list[ACPI_SYSTEM_HANDLER_LIST]) || + (((event > ACPI_MAX_SYS_NOTIFY) && + obj_desc->common_notify.notify_list[ACPI_DEVICE_HANDLER_LIST]))) { /* * Release the lock and queue the item for later * exectuion -- 1.7.9.5

11 years, 3 months

[PATCH] arm: acpi: remove the ACPI blob from memory map

by Graeme Gregory

When booting from UEFI the ACPI regions are removed from memory map. So to maintain compatability do the same when the ACPI region is passed from the FDT. Signed-off-by: Graeme Gregory <graeme.gregory(a)linaro.org> --- arch/arm/include/asm/acpi.h | 2 ++ arch/arm/kernel/setup.c | 3 +++ arch/arm64/include/asm/acpi.h | 2 ++ arch/arm64/kernel/setup.c | 3 +++ drivers/acpi/osl.c | 2 +- drivers/acpi/plat/arm/boot.c | 23 +++++++++++++++++++++++ 6 files changed, 34 insertions(+), 1 deletion(-) diff --git a/arch/arm/include/asm/acpi.h b/arch/arm/include/asm/acpi.h index e5ac1b8..ca7efaa 100644 --- a/arch/arm/include/asm/acpi.h +++ b/arch/arm/include/asm/acpi.h @@ -112,6 +112,8 @@ struct acpi_arm_root { }; extern struct acpi_arm_root acpi_arm_rsdp_info; +void arm_acpi_reserve_memory(void); + /* Low-level suspend routine. */ extern int acpi_suspend_lowlevel(void); diff --git a/arch/arm/kernel/setup.c b/arch/arm/kernel/setup.c index a440211..ac1bd1f 100644 --- a/arch/arm/kernel/setup.c +++ b/arch/arm/kernel/setup.c @@ -894,6 +894,9 @@ void __init setup_arch(char **cmdline_p) #ifdef CONFIG_EFI efi_memblock_arm_reserve_range(); #endif +#ifdef CONFIG_ACPI + arm_acpi_reserve_memory(); +#endif paging_init(mdesc); request_standard_resources(mdesc); diff --git a/arch/arm64/include/asm/acpi.h b/arch/arm64/include/asm/acpi.h index 3d37c0e..a19b73f 100644 --- a/arch/arm64/include/asm/acpi.h +++ b/arch/arm64/include/asm/acpi.h @@ -90,6 +90,8 @@ struct acpi_arm_root { }; extern struct acpi_arm_root acpi_arm_rsdp_info; +void arm_acpi_reserve_memory(void); + /* Low-level suspend routine. */ extern int acpi_suspend_lowlevel(void); diff --git a/arch/arm64/kernel/setup.c b/arch/arm64/kernel/setup.c index 627c6d6..fda34a3 100644 --- a/arch/arm64/kernel/setup.c +++ b/arch/arm64/kernel/setup.c @@ -272,6 +272,9 @@ void __init setup_arch(char **cmdline_p) arm64_memblock_init(); +#ifdef CONFIG_ACPI + arm_acpi_reserve_memory(); +#endif paging_init(); request_standard_resources(); diff --git a/drivers/acpi/osl.c b/drivers/acpi/osl.c index ebe34b3..18d62c1 100644 --- a/drivers/acpi/osl.c +++ b/drivers/acpi/osl.c @@ -386,7 +386,7 @@ acpi_map_lookup_virt(void __iomem *virt, acpi_size size) return NULL; } -#ifndef CONFIG_IA64 +#if !defined(CONFIG_IA64) && !defined(CONFIG_ARM64) && !defined(CONFIG_ARM) #define should_use_kmap(pfn) page_is_ram(pfn) #else /* ioremap will take care of cache attributes */ diff --git a/drivers/acpi/plat/arm/boot.c b/drivers/acpi/plat/arm/boot.c index 5ca62dc..130e35a 100644 --- a/drivers/acpi/plat/arm/boot.c +++ b/drivers/acpi/plat/arm/boot.c @@ -754,6 +754,29 @@ int __init acpi_boot_init(void) return 0; } +/* + * make sure that the address passed for ACPI tables which is normall in + * system ram is removed from the kernel memory map + */ +void __init arm_acpi_reserve_memory() +{ + unsigned long section_offset; + unsigned long num_sections; + phys_addr_t addr = acpi_arm_rsdp_info.phys_address; + int size = acpi_arm_rsdp_info.size; + + /* if ACPI tables were not passed in FDT then escape here */ + if (!addr || !size) + return; + + section_offset = addr - (addr & SECTION_MASK); + num_sections = size / SECTION_SIZE; + if (size % SECTION_SIZE) + num_sections++; + + memblock_remove(addr - section_offset, num_sections * SECTION_SIZE); +} + static int __init parse_acpi(char *arg) { if (!arg) -- 1.8.3.1

11 years, 3 months

[PATCH] loadtest: xsdt only needs one table

by Graeme Gregory

Extra table entries in mab will create an incorrect blob. Signed-off-by: Graeme Gregory <graeme.gregory(a)linaro.org> --- platforms/loadtest.acpi/xsdt.asl | 3 --- 1 file changed, 3 deletions(-) diff --git a/platforms/loadtest.acpi/xsdt.asl b/platforms/loadtest.acpi/xsdt.asl index cadca58..43de827 100644 --- a/platforms/loadtest.acpi/xsdt.asl +++ b/platforms/loadtest.acpi/xsdt.asl @@ -18,6 +18,3 @@ [0004] Asl Compiler Revision : 20100528 [0008] ACPI Table Address 0 : 0000000000000010 -[0008] ACPI Table Address 0 : 0000000000000020 -[0008] ACPI Table Address 0 : 0000000000000030 -[0008] ACPI Table Address 0 : 0000000000000040 -- 1.8.3.1

11 years, 3 months

[PATCH part3 01/13] Remove unnecessary ldr from boot wrapper

by Hanjun Guo

From: Mark Rutland <mark.rutland(a)arm.com> We currently do an ldr from GICC_CTLR to w0, then immediately overwrite w0 with a mov. Reading the GICC_CTLR has no effect on the state of the GIC, so there's no reason to do the ldr. It's also inconsistent with the way we set the GICD_CTLR. Fix this. Signed-off-by: Mark Rutland <mark.rutland(a)arm.com> --- boot.S | 1 - 1 file changed, 1 deletion(-) diff --git a/boot.S b/boot.S index a1f25e2..7c28e84 100644 --- a/boot.S +++ b/boot.S @@ -49,7 +49,6 @@ _start: str w0, [x1], #4 2: ldr x1, =GIC_CPU_BASE // GICC_CTLR - ldr w0, [x1] mov w0, #3 // EnableGrp0 | EnableGrp1 str w0, [x1] -- 1.7.9.5

11 years, 3 months

[RFC PATCH] ACPICA / hwreg: Use acpi_gbl_reduced_hardware to prevent accessing PM registers

by Hanjun Guo

On hardware reduced platforms, there is no support for the following: - PM Event and Control registers - SCI interrupt (and handler) - Fixed Events - General Purpose Events (GPEs) - Global Lock - ACPI PM timer - FACS table (Waking vectors and Global Lock) but when FACP Hardware Reduced flag is set, ACPI drivers will still access power management registers directly which will cause oops when system booted. acpi_gbl_reduced_hardware is a global flag and can be used to prevent misbehavior on hardware reduced platforms, and this flag is initialized at the very beginning of the system boot when FADT is parsed, so we can use it to prevent accessing PM registers. There are still lots of other places to be fixed, this is the first patch to fix hte bug we met when --cores=1; I will finish a patch set and send to upstream if you guys have no objections. I think we should start a discussion in ACPI mail list for this bug on hardware reduced platforms now. Signed-off-by: Hanjun Guo <hanjun.guo(a)linaro.org> --- drivers/acpi/acpica/hwregs.c | 24 ++++++++++++++++++++++++ 1 file changed, 24 insertions(+) diff --git a/drivers/acpi/acpica/hwregs.c b/drivers/acpi/acpica/hwregs.c index 8d2e866..4c270c3 100644 --- a/drivers/acpi/acpica/hwregs.c +++ b/drivers/acpi/acpica/hwregs.c @@ -265,6 +265,11 @@ acpi_status acpi_hw_clear_acpi_status(void) ACPI_FUNCTION_TRACE(hw_clear_acpi_status); + /* If Hardware Reduced flag is set, there are no GPEs */ + if (acpi_gbl_reduced_hardware) { + return_ACPI_STATUS(AE_NOT_IMPLEMENTED); + } + ACPI_DEBUG_PRINT((ACPI_DB_IO, "About to write %04X to %8.8X%8.8X\n", ACPI_BITMASK_ALL_FIXED_STATUS, ACPI_FORMAT_UINT64(acpi_gbl_xpm1a_status.address))); @@ -305,6 +310,10 @@ struct acpi_bit_register_info *acpi_hw_get_bit_register_info(u32 register_id) { ACPI_FUNCTION_ENTRY(); + if (acpi_gbl_reduced_hardware) { + return (NULL); + } + if (register_id > ACPI_BITREG_MAX) { ACPI_ERROR((AE_INFO, "Invalid BitRegister ID: 0x%X", register_id)); @@ -337,6 +346,11 @@ acpi_status acpi_hw_write_pm1_control(u32 pm1a_control, u32 pm1b_control) ACPI_FUNCTION_TRACE(hw_write_pm1_control); + /* If Hardware Reduced flag is set, there are no PM Control registers */ + if (acpi_gbl_reduced_hardware) { + return_ACPI_STATUS(AE_NOT_IMPLEMENTED); + } + status = acpi_hw_write(pm1a_control, &acpi_gbl_FADT.xpm1a_control_block); if (ACPI_FAILURE(status)) { @@ -370,6 +384,11 @@ acpi_status acpi_hw_register_read(u32 register_id, u32 *return_value) ACPI_FUNCTION_TRACE(hw_register_read); + /* If Hardware Reduced flag is set, there are no PM Control registers */ + if (acpi_gbl_reduced_hardware) { + return_ACPI_STATUS(AE_NOT_IMPLEMENTED); + } + switch (register_id) { case ACPI_REGISTER_PM1_STATUS: /* PM1 A/B: 16-bit access each */ @@ -465,6 +484,11 @@ acpi_status acpi_hw_register_write(u32 register_id, u32 value) ACPI_FUNCTION_TRACE(hw_register_write); + /* If Hardware Reduced flag is set, there are no PM Control registers */ + if (acpi_gbl_reduced_hardware) { + return_ACPI_STATUS(AE_NOT_IMPLEMENTED); + } + switch (register_id) { case ACPI_REGISTER_PM1_STATUS: /* PM1 A/B: 16-bit access each */ /* -- 1.7.9.5

11 years, 4 months

Standup notes 12.09.2013

by Tomasz Nowicki

Hi, Update from my side: - have got invitation letter to US Connect - run ACPI kernel on RTSMv8 model, environment preparation - now working on converting PMU driver to ACPI Tomasz

11 years, 4 months

[PATCH] ARM: dts: Correct typo in use of samsung, pin-drv for exynos5250

by al.stone＠linaro.org

From: Al Stone <ahs3(a)redhat.com> Corrects an obvious typo in the Arndale pinctrl descriptions in DT. The samsung-pinctrl driver uses the correct name. Signed-off-by: Al Stone <al.stone(a)linaro.org> --- arch/arm/boot/dts/exynos5250-pinctrl.dtsi | 44 +++++++++++++++---------------- 1 file changed, 22 insertions(+), 22 deletions(-) diff --git a/arch/arm/boot/dts/exynos5250-pinctrl.dtsi b/arch/arm/boot/dts/exynos5250-pinctrl.dtsi index 656e381..031e198 100644 --- a/arch/arm/boot/dts/exynos5250-pinctrl.dtsi +++ b/arch/arm/boot/dts/exynos5250-pinctrl.dtsi @@ -210,21 +210,21 @@ samsung,pins = "gpa0-2", "gpa0-3"; samsung,pin-function = <2>; samsung,pin-pud = <0>; - samaung,pin-drv = <0>; + samsung,pin-drv = <0>; }; i2c2_bus: i2c2-bus { samsung,pins = "gpa0-6", "gpa0-7"; samsung,pin-function = <3>; samsung,pin-pud = <3>; - samaung,pin-drv = <0>; + samsung,pin-drv = <0>; }; i2c2_hs_bus: i2c2-hs-bus { samsung,pins = "gpa0-6", "gpa0-7"; samsung,pin-function = <4>; samsung,pin-pud = <3>; - samaung,pin-drv = <0>; + samsung,pin-drv = <0>; }; uart2_data: uart2-data { @@ -238,21 +238,21 @@ samsung,pins = "gpa1-2", "gpa1-3"; samsung,pin-function = <2>; samsung,pin-pud = <0>; - samaung,pin-drv = <0>; + samsung,pin-drv = <0>; }; i2c3_bus: i2c3-bus { samsung,pins = "gpa1-2", "gpa1-3"; samsung,pin-function = <3>; samsung,pin-pud = <3>; - samaung,pin-drv = <0>; + samsung,pin-drv = <0>; }; i2c3_hs_bus: i2c3-hs-bus { samsung,pins = "gpa1-2", "gpa1-3"; samsung,pin-function = <4>; samsung,pin-pud = <3>; - samaung,pin-drv = <0>; + samsung,pin-drv = <0>; }; uart3_data: uart3-data { @@ -273,14 +273,14 @@ samsung,pins = "gpa2-0", "gpa2-1"; samsung,pin-function = <3>; samsung,pin-pud = <3>; - samaung,pin-drv = <0>; + samsung,pin-drv = <0>; }; i2c5_bus: i2c5-bus { samsung,pins = "gpa2-2", "gpa2-3"; samsung,pin-function = <3>; samsung,pin-pud = <3>; - samaung,pin-drv = <0>; + samsung,pin-drv = <0>; }; spi1_bus: spi1-bus { @@ -376,14 +376,14 @@ samsung,pins = "gpb3-0", "gpb3-1"; samsung,pin-function = <4>; samsung,pin-pud = <3>; - samaung,pin-drv = <0>; + samsung,pin-drv = <0>; }; i2c1_hs_bus: i2c1-hs-bus { samsung,pins = "gpb3-2", "gpb3-3"; samsung,pin-function = <4>; samsung,pin-pud = <3>; - samaung,pin-drv = <0>; + samsung,pin-drv = <0>; }; sd0_clk: sd0-clk { @@ -551,14 +551,14 @@ samsung,pins = "gpd0-2", "gpd0-3"; samsung,pin-function = <2>; samsung,pin-pud = <0>; - samaung,pin-drv = <0>; + samsung,pin-drv = <0>; }; dp_hpd: dp_hpd { samsung,pins = "gpx0-7"; samsung,pin-function = <3>; samsung,pin-pud = <0>; - samaung,pin-drv = <0>; + samsung,pin-drv = <0>; }; }; @@ -650,42 +650,42 @@ "gpf1-0", "gpf1-1", "gpf1-2", "gpf1-3"; samsung,pin-function = <3>; samsung,pin-pud = <0>; - samaung,pin-drv = <0>; + samsung,pin-drv = <0>; }; cam_i2c2_bus: cam-i2c2-bus { samsung,pins = "gpe0-6", "gpe1-0"; samsung,pin-function = <4>; samsung,pin-pud = <3>; - samaung,pin-drv = <0>; + samsung,pin-drv = <0>; }; cam_spi1_bus: cam-spi1-bus { samsung,pins = "gpe0-4", "gpe0-5", "gpf0-2", "gpf0-3"; samsung,pin-function = <4>; samsung,pin-pud = <0>; - samaung,pin-drv = <0>; + samsung,pin-drv = <0>; }; cam_i2c1_bus: cam-i2c1-bus { samsung,pins = "gpf0-2", "gpf0-3"; samsung,pin-function = <2>; samsung,pin-pud = <3>; - samaung,pin-drv = <0>; + samsung,pin-drv = <0>; }; cam_i2c0_bus: cam-i2c0-bus { samsung,pins = "gpf0-0", "gpf0-1"; samsung,pin-function = <2>; samsung,pin-pud = <3>; - samaung,pin-drv = <0>; + samsung,pin-drv = <0>; }; cam_spi0_bus: cam-spi0-bus { samsung,pins = "gpf1-0", "gpf1-1", "gpf1-2", "gpf1-3"; samsung,pin-function = <2>; samsung,pin-pud = <0>; - samaung,pin-drv = <0>; + samsung,pin-drv = <0>; }; cam_bayrgb_bus: cam-bayrgb-bus { @@ -696,7 +696,7 @@ "gpg2-0", "gpg2-1"; samsung,pin-function = <2>; samsung,pin-pud = <0>; - samaung,pin-drv = <0>; + samsung,pin-drv = <0>; }; cam_port_a: cam-port-a { @@ -705,7 +705,7 @@ "gph1-4", "gph1-5", "gph1-6", "gph1-7"; samsung,pin-function = <2>; samsung,pin-pud = <0>; - samaung,pin-drv = <0>; + samsung,pin-drv = <0>; }; }; @@ -757,7 +757,7 @@ "gpv1-4", "gpv1-5", "gpv1-6", "gpv1-7"; samsung,pin-function = <2>; samsung,pin-pud = <0>; - samaung,pin-drv = <0>; + samsung,pin-drv = <0>; }; c2c_txd: c2c-txd { @@ -767,7 +767,7 @@ "gpv3-4", "gpv3-5", "gpv3-6", "gpv3-7"; samsung,pin-function = <2>; samsung,pin-pud = <0>; - samaung,pin-drv = <0>; + samsung,pin-drv = <0>; }; }; -- 1.8.3.1

11 years, 4 months

[PATCH 0/3] Convert v2m_sysreg into ACPI tables

by naresh.bhat＠linaro.org

From: Naresh Bhat <naresh.bhat(a)linaro.org> The patch set will add ACPI probing for v2m_sysreg and allocate a LINA0006 platform ID. Also remove the defination under foundation-v8-acpi.dts file. Naresh Bhat (3): v2m_sysreg: Add ACPI probing ACPI: Allocate platform ID for v2m_sysreg arm64: dts: Remove v2m_sysreg binding arch/arm64/boot/dts/foundation-v8-acpi.dts | 6 +++++- drivers/acpi/acpi_platform.c | 1 + drivers/mfd/vexpress-sysreg.c | 12 ++++++++++++ 3 files changed, 18 insertions(+), 1 deletion(-) -- 1.7.9.5

11 years, 4 months

[PATCH] ASL/foundation-v8: Add v2m_sysreg

by naresh.bhat＠linaro.org

From: Naresh Bhat <naresh.bhat(a)linaro.org> Add v2m_sysreg and allocate LINA0006 as platform ID. Signed-off-by: Naresh Bhat <naresh.bhat(a)linaro.org> --- platforms/foundation-v8.acpi/dsdt.asl | 12 ++++++++++++ 1 file changed, 12 insertions(+) diff --git a/platforms/foundation-v8.acpi/dsdt.asl b/platforms/foundation-v8.acpi/dsdt.asl index 89459ec..0f3626f 100644 --- a/platforms/foundation-v8.acpi/dsdt.asl +++ b/platforms/foundation-v8.acpi/dsdt.asl @@ -244,5 +244,17 @@ DefinitionBlock ( Return (RBUF) } } + + Device (SREG) { + Name (_HID, "LINA0006") + Name (_UID, 0) + + Method (_CRS, 0x0, Serialized) { + Name (RBUF, ResourceTemplate() { + Memory32Fixed (ReadWrite, 0x1c010000, 0x1000) + }) + Return (RBUF) + } + } } } -- 1.7.9.5

11 years, 4 months

[PATCH 0/2] Add tool to enable APEI tables test, other minor changes.

by Tomasz Nowicki

Patch set implement as follows: 1. Minor changes around existing tools - reorganize building process, - move common code to separate direction. 2. Add BFAPEI (Blob For APEI) tool which can create blobs for APEI testing. - see commit log for more details Tomasz Nowicki (2): map, cab: Reorganize building process and tree hierarchy. bfapei: Add tool that can create blobs for APEI table testing. Makefile | 28 +- platforms/Makefile | 7 +- tools/bfapei/Makefile | 11 + tools/bfapei/bfapei.c | 271 ++++++++++++++++++++ tools/bfapei/bfapei.h | 235 +++++++++++++++++ tools/cab/Makefile | 12 +- tools/cab/cab.c | 527 +------------------------------------- tools/cab/cab.h | 149 ----------- tools/common/Makefile | 4 + tools/common/build_aml.c | 455 ++++++++++++++++++++++++++++++++ tools/common/check_aml.c | 512 ++++++++++++++++++++++++++++++++++++ tools/common/include/build_aml.h | 74 ++++++ tools/common/include/check_aml.h | 99 +++++++ tools/mab/Makefile | 13 +- tools/mab/mab.c | 430 +------------------------------ tools/mab/mab.h | 77 ------ 16 files changed, 1712 insertions(+), 1192 deletions(-) create mode 100644 tools/bfapei/Makefile create mode 100644 tools/bfapei/bfapei.c create mode 100644 tools/bfapei/bfapei.h create mode 100644 tools/common/Makefile create mode 100644 tools/common/build_aml.c create mode 100644 tools/common/check_aml.c create mode 100644 tools/common/include/build_aml.h create mode 100644 tools/common/include/check_aml.h -- 1.7.9.5

11 years, 4 months

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

Linaro-acpi September 2013