Linaro-acpi

linaro-acpi@lists.linaro.org

820 discussions

[PATCH v2] ARM64 / ASL: Fix interrupt type and level flag for device interrupts

by Hanjun Guo

For gic bindings, The 3rd cell of interrupts is the flags,encoded as follows: bits[3:0] trigger type and level flags. 1 = low-to-high edge triggered 2 = high-to-low edge triggered 4 = active high level-sensitive 8 = active low level-sensitive bits[15:8] PPI interrupt cpu mask. Please refer to Documentation/devicetree/bindings/arm/gic.txt for detailed information. In Foundation model and RTSM model's device tree, the 3rd cell of interrupts of all devices is 4, so we should use active high level-sensitive in the DSDT table too when we convert the device to ACPI. Signed-off-by: Hanjun Guo <hanjun.guo(a)linaro.org> --- platforms/foundation-v8.acpi/dsdt.asl | 6 +++--- platforms/rtsm_ve-aemv8a.acpi/dsdt.asl | 4 ++-- 2 files changed, 5 insertions(+), 5 deletions(-) diff --git a/platforms/foundation-v8.acpi/dsdt.asl b/platforms/foundation-v8.acpi/dsdt.asl index 39b4886..8d4657c 100644 --- a/platforms/foundation-v8.acpi/dsdt.asl +++ b/platforms/foundation-v8.acpi/dsdt.asl @@ -247,7 +247,7 @@ DefinitionBlock ( Method (_CRS, 0x0, Serialized) { Name (RBUF, ResourceTemplate () { Memory32Fixed (ReadWrite, 0x1a000000, 0x00010000) - Interrupt (ResourceConsumer, Edge, ActiveBoth, Exclusive, , , ) {0x2F} + Interrupt (ResourceConsumer, Level, ActiveHigh, Exclusive, , , ) {0x2F} }) Return (RBUF) } @@ -260,7 +260,7 @@ DefinitionBlock ( Method (_CRS, 0x0, Serialized) { Name (RBUF, ResourceTemplate() { Memory32Fixed (ReadWrite, 0x1c130000, 0x1000) - Interrupt (ResourceConsumer, Edge, ActiveBoth, Exclusive, , , ) {0x4A} + Interrupt (ResourceConsumer, Level, ActiveHigh, Exclusive, , , ) {0x4A} }) Return (RBUF) } @@ -272,7 +272,7 @@ DefinitionBlock ( Method (_CRS, 0x0, Serialized) { Name (RBUF, ResourceTemplate () { - Interrupt (ResourceConsumer, Edge, ActiveBoth, Exclusive, , , ) {92, 93, 94, 95} + Interrupt (ResourceConsumer, Level, ActiveHigh, Exclusive, , , ) {92, 93, 94, 95} }) Return (RBUF) } diff --git a/platforms/rtsm_ve-aemv8a.acpi/dsdt.asl b/platforms/rtsm_ve-aemv8a.acpi/dsdt.asl index 0bcc94d..1d51323 100644 --- a/platforms/rtsm_ve-aemv8a.acpi/dsdt.asl +++ b/platforms/rtsm_ve-aemv8a.acpi/dsdt.asl @@ -246,7 +246,7 @@ DefinitionBlock ( Method (_CRS, 0x0, Serialized) { Name (RBUF, ResourceTemplate () { Memory32Fixed (ReadWrite, 0x1a000000, 0x00010000) - Interrupt (ResourceConsumer, Edge, ActiveBoth, Exclusive, , , ) {0x2F} + Interrupt (ResourceConsumer, Level, ActiveHigh, Exclusive, , , ) {0x2F} }) Return (RBUF) } @@ -258,7 +258,7 @@ DefinitionBlock ( Method (_CRS, 0x0, Serialized) { Name (RBUF, ResourceTemplate () { - Interrupt (ResourceConsumer, Edge, ActiveBoth, Exclusive, , , ) {92, 93, 94, 95} + Interrupt (ResourceConsumer, Level, ActiveHigh, Exclusive, , , ) {92, 93, 94, 95} }) Return (RBUF) } -- 1.7.9.5

11 years, 7 months

[PATCH 00/10] Change ACPI ASL licenses to BSD

by al.stone＠linaro.org

From: Al Stone <ahs3(a)redhat.com> In order to make the ASL files that have been created more usable to a wider audience, we found it necessary to change the distribution license from GPLv2 to the less restrictive BSD 2-clause license. This patch series changes all of the files to reflect the new licensing. Al Stone (10): Add in LICENSE file (BSD 2-clause, specifically) Change the cab tool to the BSD license. Convert the mab project to a BSD license. Convert all tool common files to BSD license. Convert the bfapei tool to the BSD license. Convert overall Makefiles to BSD license. Convert the loadtest.acpi files to a BSD license. Convert ASL for Arndale to BSD license. Convert ASL for Foundation model to BSD license. Convert ASL for RTSM to BSD license. LICENSE | 30 +++++++++++++++++ Makefile | 31 +++++++++++++++++ platforms/Makefile | 31 +++++++++++++++++ platforms/exynos5250-arndale.acpi/apic.asl | 29 +++++++++++++++- platforms/exynos5250-arndale.acpi/asf!.asl | 37 ++++++++++++++++---- platforms/exynos5250-arndale.acpi/bert.asl | 30 ++++++++++++++++- platforms/exynos5250-arndale.acpi/bgrt.asl | 39 ++++++++++++++++++---- platforms/exynos5250-arndale.acpi/boot.asl | 39 ++++++++++++++++++---- platforms/exynos5250-arndale.acpi/cpep.asl | 29 +++++++++++++++- platforms/exynos5250-arndale.acpi/csrt.asl | 39 ++++++++++++++++++---- platforms/exynos5250-arndale.acpi/dsdt.asl | 29 +++++++++++++++- platforms/exynos5250-arndale.acpi/ecdt.asl | 29 +++++++++++++++- platforms/exynos5250-arndale.acpi/einj.asl | 29 +++++++++++++++- platforms/exynos5250-arndale.acpi/erst.asl | 29 +++++++++++++++- .../exynos5250-arndale.manifest | 29 ++++++++++++++++ platforms/exynos5250-arndale.acpi/facp.asl | 29 +++++++++++++++- platforms/exynos5250-arndale.acpi/facs.asl | 29 +++++++++++++++- platforms/exynos5250-arndale.acpi/fpdt.asl | 29 +++++++++++++++- platforms/exynos5250-arndale.acpi/gtdt.asl | 29 +++++++++++++++- platforms/exynos5250-arndale.acpi/hest.asl | 31 +++++++++++++++-- platforms/exynos5250-arndale.acpi/mcfg.asl | 29 +++++++++++++++- platforms/exynos5250-arndale.acpi/mchi.asl | 29 +++++++++++++++- platforms/exynos5250-arndale.acpi/mpst.asl | 29 +++++++++++++++- platforms/exynos5250-arndale.acpi/msct.asl | 29 +++++++++++++++- platforms/exynos5250-arndale.acpi/oem0.asl | 29 +++++++++++++++- platforms/exynos5250-arndale.acpi/pmtt.asl | 29 +++++++++++++++- platforms/exynos5250-arndale.acpi/rsdp.asl | 29 +++++++++++++++- platforms/exynos5250-arndale.acpi/slit.asl | 29 +++++++++++++++- platforms/exynos5250-arndale.acpi/spmi.asl | 31 +++++++++++++++-- platforms/exynos5250-arndale.acpi/srat.asl | 29 +++++++++++++++- platforms/exynos5250-arndale.acpi/ssdt0.asl | 29 +++++++++++++++- platforms/exynos5250-arndale.acpi/uefi.asl | 29 +++++++++++++++- platforms/exynos5250-arndale.acpi/xsdt.asl | 29 +++++++++++++++- platforms/foundation-v8.acpi/apic.asl | 29 +++++++++++++++- platforms/foundation-v8.acpi/bert.asl | 29 +++++++++++++++- platforms/foundation-v8.acpi/bgrt.asl | 36 +++++++++++++++++--- platforms/foundation-v8.acpi/boot.asl | 37 +++++++++++++++++--- platforms/foundation-v8.acpi/cpep.asl | 29 +++++++++++++++- platforms/foundation-v8.acpi/csrt.asl | 37 +++++++++++++++++--- platforms/foundation-v8.acpi/dsdt.asl | 29 +++++++++++++++- platforms/foundation-v8.acpi/ecdt.asl | 29 +++++++++++++++- platforms/foundation-v8.acpi/einj.asl | 29 +++++++++++++++- platforms/foundation-v8.acpi/erst.asl | 29 +++++++++++++++- platforms/foundation-v8.acpi/facp.asl | 29 +++++++++++++++- platforms/foundation-v8.acpi/facs.asl | 29 +++++++++++++++- .../foundation-v8.acpi/foundation-v8.manifest | 30 +++++++++++++++++ platforms/foundation-v8.acpi/fpdt.asl | 29 +++++++++++++++- platforms/foundation-v8.acpi/gtdt.asl | 29 +++++++++++++++- platforms/foundation-v8.acpi/hest.asl | 31 +++++++++++++++-- platforms/foundation-v8.acpi/mcfg.asl | 29 +++++++++++++++- platforms/foundation-v8.acpi/mchi.asl | 29 +++++++++++++++- platforms/foundation-v8.acpi/mpst.asl | 29 +++++++++++++++- platforms/foundation-v8.acpi/msct.asl | 29 +++++++++++++++- platforms/foundation-v8.acpi/oem0.asl | 29 +++++++++++++++- platforms/foundation-v8.acpi/pmtt.asl | 29 +++++++++++++++- platforms/foundation-v8.acpi/rsdp.asl | 29 +++++++++++++++- platforms/foundation-v8.acpi/slit.asl | 29 +++++++++++++++- platforms/foundation-v8.acpi/spmi.asl | 31 +++++++++++++++-- platforms/foundation-v8.acpi/srat.asl | 29 +++++++++++++++- platforms/foundation-v8.acpi/ssdt0.asl | 29 +++++++++++++++- platforms/foundation-v8.acpi/uefi.asl | 29 +++++++++++++++- platforms/foundation-v8.acpi/xsdt.asl | 29 +++++++++++++++- platforms/loadtest.acpi/dsdt.asl | 28 +++++++++++++++- platforms/loadtest.acpi/facp.asl | 29 +++++++++++++++- platforms/loadtest.acpi/facs.asl | 29 +++++++++++++++- platforms/loadtest.acpi/loadtest.manifest | 30 +++++++++++++++++ platforms/loadtest.acpi/rsdp.asl | 29 +++++++++++++++- platforms/loadtest.acpi/xsdt.asl | 29 +++++++++++++++- platforms/rtsm_ve-aemv8a.acpi/apic.asl | 29 +++++++++++++++- platforms/rtsm_ve-aemv8a.acpi/bert.asl | 29 +++++++++++++++- platforms/rtsm_ve-aemv8a.acpi/cpep.asl | 29 +++++++++++++++- platforms/rtsm_ve-aemv8a.acpi/dsdt.asl | 29 +++++++++++++++- platforms/rtsm_ve-aemv8a.acpi/ecdt.asl | 29 +++++++++++++++- platforms/rtsm_ve-aemv8a.acpi/einj.asl | 29 +++++++++++++++- platforms/rtsm_ve-aemv8a.acpi/erst.asl | 29 +++++++++++++++- platforms/rtsm_ve-aemv8a.acpi/facp.asl | 29 +++++++++++++++- platforms/rtsm_ve-aemv8a.acpi/facs.asl | 29 +++++++++++++++- platforms/rtsm_ve-aemv8a.acpi/fpdt.asl | 29 +++++++++++++++- platforms/rtsm_ve-aemv8a.acpi/gtdt.asl | 29 +++++++++++++++- platforms/rtsm_ve-aemv8a.acpi/hest.asl | 31 +++++++++++++++-- platforms/rtsm_ve-aemv8a.acpi/mcfg.asl | 29 +++++++++++++++- platforms/rtsm_ve-aemv8a.acpi/mchi.asl | 29 +++++++++++++++- platforms/rtsm_ve-aemv8a.acpi/mpst.asl | 29 +++++++++++++++- platforms/rtsm_ve-aemv8a.acpi/msct.asl | 29 +++++++++++++++- platforms/rtsm_ve-aemv8a.acpi/oem0.asl | 29 +++++++++++++++- platforms/rtsm_ve-aemv8a.acpi/pmtt.asl | 29 +++++++++++++++- platforms/rtsm_ve-aemv8a.acpi/rsdp.asl | 29 +++++++++++++++- .../rtsm_ve-aemv8a.acpi/rtsm_ve-aemv8a.manifest | 30 +++++++++++++++++ platforms/rtsm_ve-aemv8a.acpi/slit.asl | 29 +++++++++++++++- platforms/rtsm_ve-aemv8a.acpi/spmi.asl | 31 +++++++++++++++-- platforms/rtsm_ve-aemv8a.acpi/srat.asl | 29 +++++++++++++++- platforms/rtsm_ve-aemv8a.acpi/ssdt0.asl | 29 +++++++++++++++- platforms/rtsm_ve-aemv8a.acpi/uefi.asl | 29 +++++++++++++++- platforms/rtsm_ve-aemv8a.acpi/xsdt.asl | 29 +++++++++++++++- tools/bfapei/Makefile | 31 +++++++++++++++++ tools/bfapei/bfapei.c | 32 +++++++++++++++--- tools/bfapei/bfapei.h | 32 +++++++++++++++--- tools/cab/Makefile | 31 +++++++++++++++++ tools/cab/cab.c | 31 ++++++++++++++--- tools/cab/cab.h | 31 ++++++++++++++--- tools/common/Makefile | 31 +++++++++++++++++ tools/common/build_aml.c | 32 +++++++++++++++--- tools/common/check_aml.c | 32 +++++++++++++++--- tools/common/include/acpi.h | 32 +++++++++++++++--- tools/common/include/build_aml.h | 32 +++++++++++++++--- tools/common/include/check_aml.h | 32 +++++++++++++++--- tools/mab/Changelog | 3 ++ tools/mab/Makefile | 31 +++++++++++++++++ tools/mab/mab.c | 32 +++++++++++++++--- tools/mab/mab.h | 32 +++++++++++++++--- 110 files changed, 3115 insertions(+), 169 deletions(-) create mode 100644 LICENSE -- 1.8.3.1

11 years, 7 months

[PATCH 0/2] Cleanup unusable/unneeded ASL files

by al.stone＠linaro.org

From: Al Stone <ahs3(a)redhat.com> The Arndale and Foundation model ASL files included a bunch of template files that will either (a) never be used since they are x86 specific, or (b) are highly unlikely to ever be needed (e.g., the TPM2 table). Even if they ever do become needed, templates can easily be regenerated using the ACPICA iasl tool. So, remove these ASL files to introduce a little more clarity. Al Stone (2): Remove all Arndale ASL files that should never be used. Remove all Foundation model ASL files that should never be used. platforms/exynos5250-arndale.acpi/dbgp.asl | 29 ---------- platforms/exynos5250-arndale.acpi/dmar.asl | 68 ----------------------- platforms/exynos5250-arndale.acpi/hpet.asl | 33 ------------ platforms/exynos5250-arndale.acpi/ivrs.asl | 86 ------------------------------ platforms/exynos5250-arndale.acpi/s3pt.asl | 26 --------- platforms/exynos5250-arndale.acpi/sbst.asl | 22 -------- platforms/exynos5250-arndale.acpi/slic.asl | 56 ------------------- platforms/exynos5250-arndale.acpi/spcr.asl | 46 ---------------- platforms/exynos5250-arndale.acpi/tcpa.asl | 22 -------- platforms/exynos5250-arndale.acpi/tpm2.asl | 22 -------- platforms/exynos5250-arndale.acpi/waet.asl | 22 -------- platforms/exynos5250-arndale.acpi/wdat.asl | 47 ---------------- platforms/exynos5250-arndale.acpi/wddt.asl | 44 --------------- platforms/exynos5250-arndale.acpi/wdrt.asl | 42 --------------- platforms/foundation-v8.acpi/dbgp.asl | 29 ---------- platforms/foundation-v8.acpi/dmar.asl | 68 ----------------------- platforms/foundation-v8.acpi/hpet.asl | 33 ------------ platforms/foundation-v8.acpi/ivrs.asl | 86 ------------------------------ platforms/foundation-v8.acpi/s3pt.asl | 26 --------- platforms/foundation-v8.acpi/sbst.asl | 22 -------- platforms/foundation-v8.acpi/slic.asl | 56 ------------------- platforms/foundation-v8.acpi/spcr.asl | 46 ---------------- platforms/foundation-v8.acpi/tcpa.asl | 22 -------- platforms/foundation-v8.acpi/tpm2.asl | 22 -------- platforms/foundation-v8.acpi/waet.asl | 22 -------- platforms/foundation-v8.acpi/wdat.asl | 47 ---------------- platforms/foundation-v8.acpi/wddt.asl | 44 --------------- platforms/foundation-v8.acpi/wdrt.asl | 42 --------------- 28 files changed, 1130 deletions(-) delete mode 100644 platforms/exynos5250-arndale.acpi/dbgp.asl delete mode 100644 platforms/exynos5250-arndale.acpi/dmar.asl delete mode 100644 platforms/exynos5250-arndale.acpi/hpet.asl delete mode 100644 platforms/exynos5250-arndale.acpi/ivrs.asl delete mode 100644 platforms/exynos5250-arndale.acpi/s3pt.asl delete mode 100644 platforms/exynos5250-arndale.acpi/sbst.asl delete mode 100644 platforms/exynos5250-arndale.acpi/slic.asl delete mode 100644 platforms/exynos5250-arndale.acpi/spcr.asl delete mode 100644 platforms/exynos5250-arndale.acpi/tcpa.asl delete mode 100644 platforms/exynos5250-arndale.acpi/tpm2.asl delete mode 100644 platforms/exynos5250-arndale.acpi/waet.asl delete mode 100644 platforms/exynos5250-arndale.acpi/wdat.asl delete mode 100644 platforms/exynos5250-arndale.acpi/wddt.asl delete mode 100644 platforms/exynos5250-arndale.acpi/wdrt.asl delete mode 100644 platforms/foundation-v8.acpi/dbgp.asl delete mode 100644 platforms/foundation-v8.acpi/dmar.asl delete mode 100644 platforms/foundation-v8.acpi/hpet.asl delete mode 100644 platforms/foundation-v8.acpi/ivrs.asl delete mode 100644 platforms/foundation-v8.acpi/s3pt.asl delete mode 100644 platforms/foundation-v8.acpi/sbst.asl delete mode 100644 platforms/foundation-v8.acpi/slic.asl delete mode 100644 platforms/foundation-v8.acpi/spcr.asl delete mode 100644 platforms/foundation-v8.acpi/tcpa.asl delete mode 100644 platforms/foundation-v8.acpi/tpm2.asl delete mode 100644 platforms/foundation-v8.acpi/waet.asl delete mode 100644 platforms/foundation-v8.acpi/wdat.asl delete mode 100644 platforms/foundation-v8.acpi/wddt.asl delete mode 100644 platforms/foundation-v8.acpi/wdrt.asl -- 1.8.3.1

11 years, 7 months

[PATCH] Foundation model / ASL: Fix level flags for device interrupts

by Hanjun Guo

For gic bindings, The 3rd cell of interrupts is the flags, encoded as follows: bits[3:0] trigger type and level flags. 1 = low-to-high edge triggered 2 = high-to-low edge triggered 4 = active high level-sensitive 8 = active low level-sensitive bits[15:8] PPI interrupt cpu mask. In Foundation model and RTSM model's device tree, the 3rd cell of interrupts of all devices is 4, so we should use active high level-sensitive in the DSDT table too when we convert the device to ACPI. Signed-off-by: Hanjun Guo <hanjun.guo(a)linaro.org> --- platforms/foundation-v8.acpi/dsdt.asl | 6 +++--- platforms/rtsm_ve-aemv8a.acpi/dsdt.asl | 4 ++-- 2 files changed, 5 insertions(+), 5 deletions(-) diff --git a/platforms/foundation-v8.acpi/dsdt.asl b/platforms/foundation-v8.acpi/dsdt.asl index 39b4886..d278c32 100644 --- a/platforms/foundation-v8.acpi/dsdt.asl +++ b/platforms/foundation-v8.acpi/dsdt.asl @@ -247,7 +247,7 @@ DefinitionBlock ( Method (_CRS, 0x0, Serialized) { Name (RBUF, ResourceTemplate () { Memory32Fixed (ReadWrite, 0x1a000000, 0x00010000) - Interrupt (ResourceConsumer, Edge, ActiveBoth, Exclusive, , , ) {0x2F} + Interrupt (ResourceConsumer, Edge, ActiveHigh, Exclusive, , , ) {0x2F} }) Return (RBUF) } @@ -260,7 +260,7 @@ DefinitionBlock ( Method (_CRS, 0x0, Serialized) { Name (RBUF, ResourceTemplate() { Memory32Fixed (ReadWrite, 0x1c130000, 0x1000) - Interrupt (ResourceConsumer, Edge, ActiveBoth, Exclusive, , , ) {0x4A} + Interrupt (ResourceConsumer, Edge, ActiveHigh, Exclusive, , , ) {0x4A} }) Return (RBUF) } @@ -272,7 +272,7 @@ DefinitionBlock ( Method (_CRS, 0x0, Serialized) { Name (RBUF, ResourceTemplate () { - Interrupt (ResourceConsumer, Edge, ActiveBoth, Exclusive, , , ) {92, 93, 94, 95} + Interrupt (ResourceConsumer, Edge, ActiveHigh, Exclusive, , , ) {92, 93, 94, 95} }) Return (RBUF) } diff --git a/platforms/rtsm_ve-aemv8a.acpi/dsdt.asl b/platforms/rtsm_ve-aemv8a.acpi/dsdt.asl index 0bcc94d..a736653 100644 --- a/platforms/rtsm_ve-aemv8a.acpi/dsdt.asl +++ b/platforms/rtsm_ve-aemv8a.acpi/dsdt.asl @@ -246,7 +246,7 @@ DefinitionBlock ( Method (_CRS, 0x0, Serialized) { Name (RBUF, ResourceTemplate () { Memory32Fixed (ReadWrite, 0x1a000000, 0x00010000) - Interrupt (ResourceConsumer, Edge, ActiveBoth, Exclusive, , , ) {0x2F} + Interrupt (ResourceConsumer, Edge, ActiveHigh, Exclusive, , , ) {0x2F} }) Return (RBUF) } @@ -258,7 +258,7 @@ DefinitionBlock ( Method (_CRS, 0x0, Serialized) { Name (RBUF, ResourceTemplate () { - Interrupt (ResourceConsumer, Edge, ActiveBoth, Exclusive, , , ) {92, 93, 94, 95} + Interrupt (ResourceConsumer, Edge, ActiveHigh, Exclusive, , , ) {92, 93, 94, 95} }) Return (RBUF) } -- 1.7.9.5

11 years, 7 months

[PATCH v3 00/13] Hardware Reduced Mode cleanup for ACPI

by al.stone＠linaro.org

From: Al Stone <ahs3(a)redhat.com> This series of patches starts with Hanjun's patch to create a kernel config item for CONFIG_ACPI_REDUCED_HARDWARE [0]. Building on that, I then reviewed all of the code that touched any of several fields in the FADT that the OSPM is supposed to ignore when ACPI is in Hardware Reduced mode [1]. Any time there was a use of one of the fields to be ignored, I evaluated whether or not the code was implementing Hardware Reduced mode correctly. Similarly, for each the flags in the FADT flags field that are to be ignored in Hardware Reduced mode, the kernel code was again scanned for proper usage. The remainder of the patches are to fix all of the situations I could find where the kernel would not behave correctly in this ACPI mode. These are being submitted as an RFC to the linaro-acpi@ list so I can get some other eyes looking at them before sending them to linux-acpi@ where they really need to go. These seem to work just fine on the RTSM model for ARMv7, both with and without ACPI enabled, and with and without ACPI_REDUCED_HARDWARE enabled. However, there's no way I can think of or test all possible scenarios so feedback would be greatly appreciated. NB: these changes are only applicable to the LEG ACPI working tree. The macros in patch 1/13 will have to change for the linux-acpi tree. Changes for v3: -- Consistent use of #if (!ACPI_REDUCED_HARDWARE) -- Use of ACPI_HW_DEPENDENT_RETURN_{*} macros -- Simplify wherever possible Changes for v2: -- Change patch series title -- Add in the FACS global lock patch as further hardware reduced mode cleanup that is needed -- Remove whitespace change that should not have gotten in [1] Please see the ACPI Specification v5.0 for details on Hardware Reduced mode. [0] List at https://wiki.linaro.org/LEG/Engineering/Kernel/ACPI/AcpiReducedHw#Section_5… Al Stone (13): ACPI: introduce CONFIG_ACPI_REDUCED_HARDWARE to enable this ACPI mode ACPI: bus master reload not supported in reduced HW mode ACPI: clean up compiler warning about uninitialized field ACPI: HW reduced mode does not allow use of the FADT sci_interrupt field ACPI: ARM: exclude calls on ARM platforms, not include them on x86 ACPI: ensure several FADT fields are only used in HW reduced mode ACPI: do not reserve memory regions for some FADT entries in HW reduced mode ACPI: in HW reduced mode, getting power latencies from FADT is not allowed ACPI: add clarifying comment about processor throttling in HW reduced mode ACPI: ACPI_FADT_C2_MP_SUPPORTED must be ignored in HW reduced mode ACPI: use of ACPI_FADT_32BIT_TIMER is not allowed in HW reduced mode ACPI: correct #ifdef so compilation without ACPI_REDUCED_HARDWARE works ACPI: ARM/ARM64: ensure the ACPI FACS global_lock is never used in HW reduced mode arch/arm/include/asm/acpi.h | 3 ++- arch/arm64/include/asm/acpi.h | 3 ++- drivers/acpi/Kconfig | 8 ++++++++ drivers/acpi/acpica/utxface.c | 3 ++- drivers/acpi/bus.c | 7 ++++--- drivers/acpi/osl.c | 28 ++++++++++++++++++++-------- drivers/acpi/pci_link.c | 14 ++++++++------ drivers/acpi/plat/arm/boot.c | 2 ++ drivers/acpi/processor_idle.c | 19 ++++++++++++------- drivers/acpi/processor_throttling.c | 8 ++++++++ drivers/acpi/sleep.c | 2 +- include/acpi/acconfig.h | 2 +- include/acpi/acpixf.h | 6 ++++++ include/acpi/platform/aclinux.h | 6 ++++++ 14 files changed, 82 insertions(+), 29 deletions(-) -- 1.8.3.1

11 years, 7 months

[RFC PATCH 00/13 v2] Hardware Reduced Mode cleanup for ACPI

by al.stone＠linaro.org

From: Al Stone <ahs3(a)redhat.com> This series of patches starts with Hanjun's patch to create a kernel config item for CONFIG_ACPI_REDUCED_HARDWARE [0]. Building on that, I then reviewed all of the code that touched any of several fields in the FADT that the OSPM is supposed to ignore when ACPI is in Hardware Reduced mode [1]. Any time there was a use of one of the fields to be ignored, I evaluated whether or not the code was implementing Hardware Reduced mode correctly. Similarly, for each the flags in the FADT flags field that are to be ignored in Hardware Reduced mode, the kernel code was again scanned for proper usage. The remainder of the patches are to fix all of the situations I could find where the kernel would not behave correctly in this ACPI mode. These are being submitted as an RFC to the linaro-acpi@ list so I can get some other eyes looking at them before sending them to linux-acpi@ where they really need to go. These seem to work just fine on the RTSM model for ARMv7, both with and without ACPI enabled, and with and without ACPI_REDUCED_HARDWARE enabled. However, there's no way I can think of or test all possible scenarios so feedback would be greatly appreciated. Changes for v2: -- Change patch series title -- Add in the FACS global lock patch as further hardware reduced mode cleanup that is needed -- Remove whitespace change that should not have gotten in [1] Please see the ACPI Specification v5.0 for details on Hardware Reduced mode. [0] List at https://wiki.linaro.org/LEG/Engineering/Kernel/ACPI/AcpiReducedHw#Section_5… Al Stone (13): ACPI: introduce CONFIG_ACPI_REDUCED_HARDWARE to enable this ACPI mode ACPI: bus master reload is unsupported in ACPI reduced HW mode ACPI: clean up compiler warning about uninitialized field ACPI: HW reduced mode does not allow use of the FADT sci_interrupt field ACPI: ARM: exclude calls on ARM platforms, not include them on x86 ACPI: ensure several FADT fields are only used in HW reduced mode ACPI: do not reserve memory regions for some FADT entries in HW reduced mode ACPI: in HW reduced mode, getting power latencies from FADT is not allowed ACPI: add clarifying comment about processor throttling in HW reduced mode ACPI: ACPI_FADT_C2_MP_SUPPORTED must be ignored in HW reduced mode ACPI: use of ACPI_FADT_32BIT_TIMER is not allowed in HW reduced mode ACPI: correct #ifdefs so compiling without ACPI_REDUCED_HARDWARE works properly ACPI: ARM/ARM64: ensure the ACPI FACS global_lock is never used in HW reduced mode arch/arm/include/asm/acpi.h | 3 ++- arch/arm64/include/asm/acpi.h | 3 ++- drivers/acpi/Kconfig | 8 ++++++++ drivers/acpi/acpica/utxface.c | 3 ++- drivers/acpi/bus.c | 9 +++++---- drivers/acpi/osl.c | 28 ++++++++++++++++++++-------- drivers/acpi/pci_link.c | 14 ++++++++------ drivers/acpi/plat/arm/boot.c | 2 ++ drivers/acpi/processor_idle.c | 29 ++++++++++++++++++++++++----- drivers/acpi/processor_throttling.c | 8 ++++++++ drivers/acpi/sleep.c | 2 +- include/acpi/acconfig.h | 2 +- include/acpi/platform/aclinux.h | 6 ++++++ 13 files changed, 89 insertions(+), 28 deletions(-) -- 1.8.3.1

11 years, 7 months

Re: [Linaro-acpi] [PATCH 17/20] ACPICA: Simplify configuration of global ACPI_REDUCED_HARDWARE macro.

by Hanjun Guo

On 29 October 2013 09:30, Lv Zheng <lv.zheng(a)intel.com> wrote: > From: Bob Moore <robert.moore(a)intel.com> > > Surround definition of this with a #ifndef so that the kernel > can define it elsewhere if desired. > > Signed-off-by: Bob Moore <robert.moore(a)intel.com> > Signed-off-by: Lv Zheng <lv.zheng(a)intel.com> > Reviewed-by: Hanjun Guo <hanjun.guo(a)linaro.org> > --- > include/acpi/acconfig.h | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/include/acpi/acconfig.h b/include/acpi/acconfig.h > index 1c16f82..d98c670 100644 > --- a/include/acpi/acconfig.h > +++ b/include/acpi/acconfig.h > @@ -100,7 +100,9 @@ > * ACPI PM timer > * FACS table (Waking vectors and Global Lock) > */ > +#ifndef ACPI_REDUCED_HARDWARE > #define ACPI_REDUCED_HARDWARE FALSE > +#endif > > > /****************************************************************************** > * > -- > 1.7.10 > > -- > To unsubscribe from this list: send the line "unsubscribe linux-acpi" in > the body of a message to majordomo(a)vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html >

11 years, 8 months

[RFC PATCH 0/3] ACPI: ARM AMBA bus connector resource

by brandon.anderson＠amd.com

From: Brandon Anderson <brandon.anderson(a)amd.com> This is a proposal for ACPI driver probing of the ARM AMBA devices currently listed under ‘iofpga’ in the RTSM dts file. The main addition is drivers/amba/acpi.c which fits the role of an AMBA bus ‘connector resource’ for ACPI using struct amba_device. I have not yet figured out the implementation details regarding clocks (handled in the dts file with clock-names). However, I have included a proposed ASL format for clock information in the DSDT example below. With the last patch that hacks the clock info, this prototype will run on the Foundation and RTSM models. These patches require Hanjun’s fixed-clock patches to be applied first on top of a Linaro ACPI kernel: https://git.linaro.org/gitweb?p=arm/acpi/leg-kernel.git;a=summary Please comment on both the concept and the implementation. Brandon Anderson (3): Remove UART and KMI entries from DTS file Prototype of AMBA bus 'connector resource' for ACPI Hack clock names to get prototype running arch/arm64/boot/dts/foundation-v8-acpi.dts | 10 +- arch/arm64/boot/dts/rtsm_ve-aemv8a-acpi.dts | 4 + arch/arm64/boot/dts/rtsm_ve-motherboard-acpi.dtsi | 4 + drivers/acpi/acpi_platform.c | 2 + drivers/amba/Makefile | 2 +- drivers/amba/acpi.c | 172 +++++++++++++++++++++ drivers/clk/clk-fixed-rate.c | 15 +- 7 files changed, 203 insertions(+), 6 deletions(-) create mode 100644 drivers/amba/acpi.c -- 1.7.9.5 --- Device (AMBA) { Name (_HID, "AMBA0000") /* the parallel to "arm,primecell" in DTS */ Name (_UID, 0) /* Define 'apb_pclk' as a default clock source since it is common with devices below */ Method(_DSM, 4, NotSerialized) { Store (Package (3) { "clock-name", "apb_pclk", "\\_SB_.CLK0", }, Local0) Return (Local0) } Device (KMI0) { Name (_ADR,0x1c060000) Method (_CRS, 0x0, Serialized) { Name (RBUF, ResourceTemplate () { Memory32Fixed (ReadWrite, 0x1c060000, 0x00010000) Interrupt (ResourceConsumer, Edge, ActiveBoth, Exclusive, , , ) {44} }) Return (RBUF) } } Device (KMI1) { Name (_ADR,0x1c070000) Method (_CRS, 0x0, Serialized) { Name (RBUF, ResourceTemplate () { Memory32Fixed (ReadWrite, 0x1c070000, 0x00010000) Interrupt (ResourceConsumer, Edge, ActiveBoth, Exclusive, , , ) {45} }) Return (RBUF) } } Device (SER0) { Name (_ADR,0x1c090000) // UART0 Method (_CRS, 0x0, Serialized) { Name (RBUF, ResourceTemplate () { Memory32Fixed (ReadWrite, 0x1c090000, 0x00010000) Interrupt (ResourceConsumer, Edge, ActiveBoth, Exclusive, , , ) {37} }) Return (RBUF) } } Device (SER1) { Name (_ADR,0x1c0a0000) // UART1 Method (_CRS, 0x0, Serialized) { Name (RBUF, ResourceTemplate () { Memory32Fixed (ReadWrite, 0x1c0a0000, 0x00010000) Interrupt (ResourceConsumer, Edge, ActiveBoth, Exclusive, , , ) {38} }) Return (RBUF) } } Device (SER2) { Name (_ADR,0x1c0b0000) // UART2 Method (_CRS, 0x0, Serialized) { Name (RBUF, ResourceTemplate () { Memory32Fixed (ReadWrite, 0x1c0b0000, 0x00010000) Interrupt (ResourceConsumer, Edge, ActiveBoth, Exclusive, , , ) {39} }) Return (RBUF) } } Device (SER3) { Name (_ADR,0x1c0c0000) // UART3 Method (_CRS, 0x0, Serialized) { Name (RBUF, ResourceTemplate () { Memory32Fixed (ReadWrite, 0x1c0c0000, 0x00010000) Interrupt (ResourceConsumer, Edge, ActiveBoth, Exclusive, , , ) {40} }) Return (RBUF) } } }

11 years, 8 months

[PATCH] ACPI: ARM: define acpi_suspend_lowlevel() properly to eliminate compiler warning

by al.stone＠linaro.org

From: Al Stone <ahs3(a)redhat.com> This function was not defined as a pointer to a function but as a function. This resulted in a "test is always true" warning in drivers/acpi/sleep.c where it tested for the existence of the function. Signed-off-by: Al Stone <al.stone(a)linaro.org> --- arch/arm/include/asm/acpi.h | 2 +- arch/arm64/include/asm/acpi.h | 2 +- drivers/acpi/plat/arm/sleep.c | 11 +++++++++-- 3 files changed, 11 insertions(+), 4 deletions(-) diff --git a/arch/arm/include/asm/acpi.h b/arch/arm/include/asm/acpi.h index ca7efaa..31f21fd 100644 --- a/arch/arm/include/asm/acpi.h +++ b/arch/arm/include/asm/acpi.h @@ -115,7 +115,7 @@ extern struct acpi_arm_root acpi_arm_rsdp_info; void arm_acpi_reserve_memory(void); /* Low-level suspend routine. */ -extern int acpi_suspend_lowlevel(void); +extern int (*acpi_suspend_lowlevel)(void); extern void prefill_possible_map(void); diff --git a/arch/arm64/include/asm/acpi.h b/arch/arm64/include/asm/acpi.h index a19b73f..aee7190 100644 --- a/arch/arm64/include/asm/acpi.h +++ b/arch/arm64/include/asm/acpi.h @@ -93,7 +93,7 @@ extern struct acpi_arm_root acpi_arm_rsdp_info; void arm_acpi_reserve_memory(void); /* Low-level suspend routine. */ -extern int acpi_suspend_lowlevel(void); +extern int (*acpi_suspend_lowlevel)(void); extern void prefill_possible_map(void); diff --git a/drivers/acpi/plat/arm/sleep.c b/drivers/acpi/plat/arm/sleep.c index 9129c7e..ac5e343 100644 --- a/drivers/acpi/plat/arm/sleep.c +++ b/drivers/acpi/plat/arm/sleep.c @@ -1,15 +1,22 @@ /* - * sleep.c - x86-specific ACPI sleep support. + * sleep.c - ARM-specific ACPI sleep support. * * Copyright (C) 2001-2003 Patrick Mochel * Copyright (C) 2001-2003 Pavel Machek <pavel(a)ucw.cz> */ +#ifdef CONFIG_ACPI_SLEEP int acpi_suspend_lowlevel(void) { - /* BOZO: dummy routine; see below for actual */ + /* + * TODO: connect this function to PSCI when it becomes available, + * and if actually needed. + */ return 0; } +#else +int acpi_suspend_lowlevel(void); +#endif #ifdef CONFIG_X86 /* BOZO: disable everything for now... */ -- 1.8.3.1

11 years, 8 months

Fwd: Re: APEI question

by Tomasz Nowicki

Hi, This is interesting answer to my question so I am shearing it with you. Tomasz -------- Original Message -------- Subject: Re: APEI question Date: Thu, 24 Oct 2013 02:38:26 -0400 From: Chen, Gong <gong.chen(a)linux.intel.com> To: Tomasz Nowicki <tn(a)semihalf.com> On Wed, Oct 23, 2013 at 11:16:13AM +0200, Tomasz Nowicki wrote: > Date: Wed, 23 Oct 2013 11:16:13 +0200 > From: Tomasz Nowicki <tn(a)semihalf.com> > To: chen gong <Chen(a)gchen.bj.intel.com> > CC: gong.chen(a)linux.intel.com > Subject: Re: APEI question > User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 > Thunderbird/24.0 > > Let me put this in the different way. > > ghes_do_proc() process errors which are reported via APEI. It > handles with CPER_SEC_PLATFORM_MEM and CPER_SEC_PCIE error types. I > wander why this function is not taking care of > CPER_SEC_PROC_GENERIC. > Yes, the spec has covered all kinds of situations but the reality is cruel. Even FFM is enabled, not all errors can be covered by firmware. Based on the fact, only memory/IO CE and IO UC errors can be handled well by firmware by now. For processer errors, as a fact, I never saw so-called CE errors, only UC, even fatal error. As a result, you will get a MCE. You can consider that firmware just *bypass* this kind of error. In some way, that's why eMCA happens as a successor. That's all. Otherwise I will cross the red line ;-).

11 years, 8 months

← Newer
1
...
61
62
63
64
65
66
67
...
82
Older →

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

Linaro-acpi