Re: [Linaro-acpi] [PATCH v2 6/6] ACPI: add importing SBSA Generic watchdog info of GTDT into platform device for whole system.

Hi Timur, I should update this , for Foundation model , it is 64K. But in GTDT, there is not a "size" parameter, for short term , I think we should use the minimum one first : 4K

Any thought ?

On 8 May 2015 at 06:49, Timur Tabi timur@codeaurora.org wrote:

On 05/04/2015 07:04 AM, fu.wei@linaro.org wrote:

...

•   res[0].start = (resource_size_t)rf_base_phy;
  

•   res[0].end = (resource_size_t)(rf_base_phy + SZ_64K - 1);
  

•   res[0].name = "refresh_frame";
  

•   res[0].flags = IORESOURCE_MEM;
  

•   res[1].start = (resource_size_t)cf_base_phy;
  

•   res[1].end = (resource_size_t)(cf_base_phy + SZ_64K - 1);
  

•   res[1].name = "control_frame";
  

•   res[1].flags = IORESOURCE_MEM;
  
  

These should be SZ_4K instead of SZ_64K. The frames are only 4KB in size. On my platform, specifying SZ_64K causes an overlap, which is why I got that platform_device_add() error.

-- Qualcomm Innovation Center, Inc. The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum, a Linux Foundation Collaborative Project.