On 01/22/14 09:22, Hanjun Guo wrote:
On 2014-1-22 3:22, Tomasz Nowicki wrote:
On 01/21/2014 05:39 PM, Sudeep Holla wrote:
Hi Hanjun,
On 21/01/14 14:53, Hanjun Guo wrote:
On 2014年01月21日 19:41, Tomasz Nowicki wrote:
GIC ID is unique for GIC instance (not for CPU) and reflect number of GIC instances system has.
Signed-off-by: Tomasz Nowicki tomasz.nowicki@linaro.org
platforms/rtsm_ve-aemv8a.acpi/apic.asl | 20 ++++++++++---------- 1 file changed, 10 insertions(+), 10 deletions(-)diff --git a/platforms/rtsm_ve-aemv8a.acpi/apic.asl b/platforms/rtsm_ve-aemv8a.acpi/apic.asl index 81351c3..41e869f 100644 --- a/platforms/rtsm_ve-aemv8a.acpi/apic.asl +++ b/platforms/rtsm_ve-aemv8a.acpi/apic.asl @@ -36,7 +36,7 @@
[0004] Signature : "APIC" [0004] Table Length : 000000F6-[0001] Revision : 03 +[0001] Revision : 04 [0001] Checksum : B0 [0006] Oem ID : "LINARO" [0008] Oem Table ID : "RTSMVEV8" @@ -51,8 +51,8 @@ [0001] Subtable Type : 0B [Generic Interrupt Controller] [0001] Length : 28 [0002] Reserved : 0000 -[0004] Local GIC Hardware ID : 00000000 /* Should be equal to FDT provided or CPU hardware ID */ -[0004] Processor UID : 00000000 +[0004] Local GIC Hardware ID : 00000000
The GIC ID is the same always, I think they should be unique in the system.
how about matching the bit index of the associated processor in the distributor’s GICD_ITARGETSR register?
Seeing this change and your change on linux-acpi list to support ACPI on ARM64, I am bit confused. What should "Local GIC Hardware ID" in MADT represent ?
Hi Sudeep,
Sorry for confusing you, I should make my changelog more exhaustive.
Actually it is good question about "Local GIC Hardware ID" meaning.
- Is it the interrupt controller(GIC) ID ?
or 2. GIC CPU interface ID ?
As I responded to Hanjun in other mail, this patch assume that first answer it the right one and UID should be used for arm_cpu_to_apicid mapping after your suggestion.
I think not. Local GIC Hardware ID should be unique and one to one mapping to UID, please refer to the code of map_lapic_id() in processor_core.c
If so, this patch is not needed.
Tomasz