Re: [Linaro-acpi] [PATCH V2 1/2] efi: print unrecognized CPER section

On 09/08/2015 04:29 PM, Jonathan (Zhixiong) Zhang wrote:

Change-Id: I663a6e3ae6dcf68e4e389f76d555e9106ffee165

You need to strip out the Change-Id's before posting the patch.

+#define cper_print_hex(pfx, buf, len) \

• print_hex_dump(pfx, "", \

• DUMP_PREFIX_OFFSET, ROW_SIZE, GROUP_SIZE,	\
  

• buf, len, 0)
  

(buf), (len), 0)

is safer

• } else {

• const void *raw_err = gdata + 1;
  

• printk("%ssection type: %pUl\n", pfx, sec_type);
  

• printk("%ssection length: %d\n", pfx, len);
  

• cper_print_hex(newpfx, raw_err, len);
  

You don't need raw_err. This should work fine:

cper_print_hex(newpfx, gdata + 1, len);