Re: [Linaro-acpi] [PATCH v7 1/2] Mailbox: Add support for Platform Communication Channel

On Wed, Sep 17, 2014 at 06:17:03PM -0400, Ashwin Chaugule wrote:

•   while (!(readw_relaxed(&generic_comm_base->status) &
  

PCC_CMD_COMPLETE)) {

•           if (retries++ < 5)
  

•                   udelay(cmd_delay);
  

•           else {
  

•                   pr_err("PCC platform did not respond.\n");
  

•                   return false;
  

•           }
  

•   }
  

You should have { } on both branches of the if but otherwise that looks fine to me (assuming that there are enough retries).