Re: [Linaro-acpi] [PATCH v2 2/5] acpi, apei, ghes: Introduce ACPI_APEI_NMI to make NMI error notification a GHES feature.

On 12.06.2014 12:32, Robert Richter wrote:

On 28.05.14 09:39:27, Tomasz Nowicki wrote:

...

+config ACPI_APEI_NMI

• bool "NMI error notification support"
• default y
• depends on ACPI_APEI_GHES && X86
• help

•  Firmware first mode can use NMI notification mechanism to report errors
  

•  to operating system. This feature is currently supported by X86
  

•  architecture only.
  

This selection is not necessary. I don't see why one should select this at all. It's either there for an arch or not. Just use ARCH_HAS_ style and and hard select ARCH_HAS_ACPI_APEI_NMI for x86. There is no need for the ACPI_APEI_GHES dependency then.

It does make sense to me, will address your comment appropriately.

Tomasz