On Fri, May 22, 2015 at 09:09:10AM -0500, Timur Tabi wrote:
fu.wei@linaro.org wrote:
Some devices get clock from system counter, like SBSA watchdog driver. They may need to get system counter rate.
We don't need this patch. The watchdog driver can use arch_timer_get_cntfrq() instead of arch_timer_get_rate(). There's nothing wrong with arch_timer_get_cntfrq() since the SBSA driver is intended only for ARM64 server systems, and arch_timer_get_cntfrq() is always defined for such systems.
I agree, since the SBSA driver also uses arch_counter_get_cntvct() which is declared in the same include file as arch_timer_get_cntfrq(). The additional dependency does not provide any value, unless architecture implementation dependencies can be removed entirely, which does not seem to be the case.
Doo bad that SBSA is not hardware independent enough to provide all the information needed to implement such a driver :-(.
Guenter