[+Sudeep]
On Thu, Jul 07, 2016 at 02:03:17PM +0200, Rafael J. Wysocki wrote:
[...]
So is this a documentation issue in which case Fu Wei can add that to the file to explain its limited to ARM64. Or we could even rename the file acpi_arm64_gtdt.c
It seems a pity as the comment on this series were minors to block things on a filename/location.
Let me repeat what I said above:
I'm mostly concerned about how (and by whom) that code is going to be maintained going forward.
This is not about documentation, it is about responsibility.
Honestly, I don't think I'm the right maintainer to apply the patch introducing this code and then handle bug reports regarding it and so on. That has to be done by somebody else.
I'm working on ACPI for years and upstreamed the ARM64 ACPI core support (with lots of people's help), I'm willing to maintain the ARM64 ACPI code under drivers/acpi/ if no objections.
OK
I would ask you please to add Sudeep and myself for the ARM64 specific ACPI code maintainership too.
Can the ARM64-specific code go under drivers/acpi/arm64/ then, for clarity?
It can, but I do not understand why x86 should not have a separate directory for all x86 specific stuff too then.
Anyway let's avoid these petty arguments, I agree there must be some sort of ARM64 ACPI maintainership for the reasons you mentioned above.
That's one thing.
Another one is the question I asked a few messages ago: Why having the GTDT code in drivers/acpi/ is actually useful to anyone? It definitely would not be useful to me as the maintainer of drivers/acpi/, but maybe it would be useful to somebody for a specific practical reason. Or is it just "let's put this into drivers/acpi/ for the lack of a better place"?
The same logic applies to eg ioapic.c but anyway, see above, if it can help having a separate subdirectory let's do it.
Having GTDT code in drivers/acpi/ is useful as it is code that is used by two different subsystems, clocksource and watchdog,and where people look by default for utility ACPI code.
If the mostly concerned thing (maintainer ship) is settled down, the second question would be easily solved.
See above.
Thanks, Lorenzo