Re: [Linaro-acpi] [PATCH v2] ASL / ARMv8 foudation model: Fix cpu hot add failure on ARM64

V2 version of patch applied with Als Ack.

G

On Tue, Sep 03, 2013 at 08:56:21AM -0600, Al Stone wrote:

On 09/02/2013 03:17 AM, Hanjun Guo wrote:

...

All values in the ACPI blob are little-endian, but I creat the DSDT table with values in big-endian format, so when I evaluate _MAT object I will get values unexperted, this leads to cpu hot add failure, fix it.

v1 -> v2: No functional change, just change the title for better readability.

Signed-off-by: Hanjun Guo hanjun.guo@linaro.org

platforms/foundation-v8.acpi/dsdt.asl | 27 ++++++++++++++------------- 1 file changed, 14 insertions(+), 13 deletions(-)

diff --git a/platforms/foundation-v8.acpi/dsdt.asl b/platforms/foundation-v8.acpi/dsdt.asl index d1a9716..9c128d3 100644 --- a/platforms/foundation-v8.acpi/dsdt.asl +++ b/platforms/foundation-v8.acpi/dsdt.asl @@ -38,8 +38,9 @@ DefinitionBlock (

		Name (MAT0, Buffer (0x28)
		{

• 		/* Be careful, little-endian here */
  	/* 0000 */    0x0B, 0x28, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, /* type, len, reserved, gic_id */
  

• 		/* 0008 */    0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x01, /* uid, flags */
  

• 		/* 0008 */    0x00, 0x00, 0x00, 0x00, 0x01, 0x00, 0x00, 0x00, /* uid, flags */
  	/* 0010 */    0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, /* parking_version, performance_interrupt */
  	/* 0018 */    0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, /* parked_address */
  	/* 0020 */    0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00  /* base_address */
  

@@ -88,8 +89,8 @@ DefinitionBlock (

		Name (MAT0, Buffer (0x28)
		{

• 		/* 0000 */    0x0B, 0x28, 0x00, 0x00, 0x00, 0x00, 0x00, 0x01,
  

• 		/* 0008 */    0x00, 0x00, 0x00, 0x01, 0x00, 0x00, 0x00, 0x01,
  

• 		/* 0000 */    0x0B, 0x28, 0x00, 0x00, 0x01, 0x00, 0x00, 0x00,
  

• 		/* 0008 */    0x01, 0x00, 0x00, 0x00, 0x01, 0x00, 0x00, 0x00,
  	/* 0010 */    0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00,
  	/* 0018 */    0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00,
  	/* 0020 */    0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00
  

@@ -97,8 +98,8 @@ DefinitionBlock (

		Name (MAT1, Buffer (0x28)
		{

• 		/* 0000 */    0x0B, 0x28, 0x00, 0x00, 0x00, 0x00, 0x00, 0x01,
  

• 		/* 0008 */    0x00, 0x00, 0x00, 0x01, 0x00, 0x00, 0x00, 0x00,
  

• 		/* 0000 */    0x0B, 0x28, 0x00, 0x00, 0x01, 0x00, 0x00, 0x00,
  

• 		/* 0008 */    0x01, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00,
  	/* 0010 */    0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00,
  	/* 0018 */    0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00,
  	/* 0020 */    0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00
  

@@ -138,8 +139,8 @@ DefinitionBlock (

		Name (MAT0, Buffer (0x28)
		{

• 		/* 0000 */    0x0B, 0x28, 0x00, 0x00, 0x00, 0x00, 0x00, 0x02,
  

• 		/* 0008 */    0x00, 0x00, 0x00, 0x02, 0x00, 0x00, 0x00, 0x01,
  

• 		/* 0000 */    0x0B, 0x28, 0x00, 0x00, 0x02, 0x00, 0x00, 0x00,
  

• 		/* 0008 */    0x02, 0x00, 0x00, 0x00, 0x01, 0x00, 0x00, 0x00,
  	/* 0010 */    0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00,
  	/* 0018 */    0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00,
  	/* 0020 */    0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00
  

@@ -147,8 +148,8 @@ DefinitionBlock (

		Name (MAT1, Buffer (0x28)
		{

• 		/* 0000 */    0x0B, 0x28, 0x00, 0x00, 0x00, 0x00, 0x00, 0x02,
  

• 		/* 0008 */    0x00, 0x00, 0x00, 0x02, 0x00, 0x00, 0x00, 0x00,
  

• 		/* 0000 */    0x0B, 0x28, 0x00, 0x00, 0x02, 0x00, 0x00, 0x00,
  

• 		/* 0008 */    0x02, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00,
  	/* 0010 */    0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00,
  	/* 0018 */    0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00,
  	/* 0020 */    0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00
  

@@ -188,8 +189,8 @@ DefinitionBlock (

		Name (MAT0, Buffer (0x28)
		{

• 		/* 0000 */    0x0B, 0x28, 0x00, 0x00, 0x00, 0x00, 0x00, 0x03,
  

• 		/* 0008 */    0x00, 0x00, 0x00, 0x03, 0x00, 0x00, 0x00, 0x01,
  

• 		/* 0000 */    0x0B, 0x28, 0x00, 0x00, 0x03, 0x00, 0x00, 0x00,
  

• 		/* 0008 */    0x03, 0x00, 0x00, 0x00, 0x01, 0x00, 0x00, 0x00,
  	/* 0010 */    0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00,
  	/* 0018 */    0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00,
  	/* 0020 */    0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00
  

@@ -197,8 +198,8 @@ DefinitionBlock (

		Name (MAT1, Buffer (0x28)
		{

• 		/* 0000 */    0x0B, 0x28, 0x00, 0x00, 0x00, 0x00, 0x00, 0x03,
  

• 		/* 0008 */    0x00, 0x00, 0x00, 0x03, 0x00, 0x00, 0x00, 0x00,
  

• 		/* 0000 */    0x0B, 0x28, 0x00, 0x00, 0x03, 0x00, 0x00, 0x00,
  

• 		/* 0008 */    0x03, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00,
  	/* 0010 */    0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00,
  	/* 0018 */    0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00,
  	/* 0020 */    0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00
  
  

Acked-by: Al Stone al.stone@linaro.org

-- ciao, al

---

Al Stone Software Engineer Linaro Enterprise Group al.stone@linaro.org

---

---

Linaro-acpi mailing list Linaro-acpi@lists.linaro.org http://lists.linaro.org/mailman/listinfo/linaro-acpi