On 09/02/2013 06:59 AM, Tomasz Nowicki wrote:
W dniu 02.09.2013 08:53, Hanjun Guo pisze:
Hi Tomasz,
On 2013-8-29 17:41, Tomasz Nowicki wrote:
This is re-use existing patch submitted by Huang Ying ying.huang@intel.com with one small modification (see commits). The first idea was to use just printk to inform about any errors that were not consumed by OS.
Errors listed in HEST table should point to the same "Error status block" ESB structures as BERT does. OS handling errors should clear errors status bit in ESB for given error at the end of error recovery procedure. Case where error appeared to be too serious OS can reset machine immediately without clearing bit in ESB. During boot, kernel examine each error status bit from ESB list (pointed from BERT) and see if there are any unhandled errors.
BERT table was tested along with HEST and EINJ driver, in the following way:
- Fill in ESB using EINJ hacked driver and do not clear erros status
in ESB, this way unhandler error is simulated and BERT table could be used later: root@localhost:~# echo 1 > /sys/kernel/debug/apei/einj/error_inject 2. Reboot machin and check whether BERT driver notice injected error: ... [ 2.518179] [Hardware Error]: Error record from previous boot: [ 2.523342] [Hardware Error]: APEI generic hardware error status [ 2.548457] [Hardware Error]: severity: 1, fatal [ 2.574705] [Hardware Error]: section: 0, severity: 0, recoverable [ 2.584010] [Hardware Error]: flags: 0x00 [ 2.587937] [Hardware Error]: section_type: memory error ... 3. Kernel clear status bit so next boot would not print it again.
Why is there no summary of this patch set? such as Al's patch set:
Al Stone (6): ACPI: ARM: arndale: remove GPZ GPIO definition from DT so it can be in ACPI ACPI: ARM: arndale: whitelist the samsung-pinctrl driver for ACPI ACPI: make an error message a little clearer ACPI: improve acpi_extract_package() utility ACPI: ARM: arndale: enable ACPI in the Samsung pinctrl driver ACPI: ARM: arndale: add CONFIG_ACPI ifdef's to pinctrl driver
arch/arm/boot/dts/exynos5250-pinctrl.dtsi | 2 + arch/arm/boot/dts/exynos5250.dtsi | 6 +- drivers/acpi/acpi_platform.c | 3 + drivers/acpi/osl.c | 2 +- drivers/acpi/utils.c | 17 +- drivers/pinctrl/pinctrl-samsung.c | 517 +++++++++++++++++++++++++++++- drivers/pinctrl/pinctrl-samsung.h | 3 + 7 files changed, 536 insertions(+), 14 deletions(-)
did you delete them?
Yes, commit logs are mail titles so it makes cover letter bigger unnecessarily.
Hey, Tomasz. Did you get sufficient ack's for these patches? Did they get committed? It would not surprise if all this was taken care of a long time ago and I just lost the IRQ for it :).
If, not, this is my ACK. This looks like a good starting point for this functionality; we'll have to convert it to UEFI calls at some point in the future, and we should note that it a JIRA card or bug report some place, but this does put the basic framework in place regardless.
Acked-by: Al Stone al.stone@linaro.org