Re: [Linaro-acpi] [RFC PATCH 5/5] ACPI: use Linux as ACPI_OS_NAME for _OS on ARM64

On Wednesday 14 January 2015 18:16:19 al.stone@linaro.org wrote:

From: Al Stone ahs3@redhat.com

ACPI_OS_NAME is globally defined as "Microsoft Windows NT" for now. That doesn't make much sense in the ARM context, so set it to "Linux" when CONFIG_ARM64.

So do we expect Microsoft to identify WindowsRT as "Linux" on these machines?

diff --git a/drivers/acpi/Kconfig b/drivers/acpi/Kconfig index 3e3bd35..024c5f0 100644 --- a/drivers/acpi/Kconfig +++ b/drivers/acpi/Kconfig @@ -369,6 +369,14 @@ config ACPI_REDUCED_HARDWARE_ONLY If you are unsure what to do, do not enable this option. +config ACPI_OS_NAME_LINUX

•   bool "Using Linux for _OS method" if EXPERT
  

•   def_bool n
  

•     When used, this option makes sure the _OS method returns
  

•     the value "Linux".
  

•     If you are unsure what to do, do not enable this option.
  

source "drivers/acpi/apei/Kconfig" config ACPI_EXTLOG

With this Kconfig statement, expert users on x86 can choose between the two strings, but while expert users on arm64 will see an option they cannot disable, and non-expert users cannot change the default.

Is that what you intended?

I would see more value in a boot-time option than a compile-time option: If you have a broken BIOS that depends on a particular string, you shouldn't have to rebuild the kernel.

Arnd