Re: [Linaro-acpi] [PATCH v2 4/6] Watchdog: introdouce ARM SBSA watchdog driver (1)use linux kernel watchdog framework (2)work with FDT (3)support pretimeout, for now in first timeout(WS0), do panic to save system context.

Hi Guenter,

np, take them out

On 8 May 2015 at 21:38, Guenter Roeck linux@roeck-us.net wrote:

On 05/08/2015 06:28 AM, Fu Wei wrote:

...

Hi Guenter,

On 8 May 2015 at 21:05, Guenter Roeck <linux@roeck-us.net mailto: linux@roeck-us.net> wrote:

On 05/07/2015 11:36 PM, Fu Wei wrote:

    Hi Guenter,

    I have another thought:
    dose it makes sense to put this kind of check into
    -------
    #if SBSA_GWDT_DEBUG

    #endif
    -------
    just for development and debugging resean?

    just a suggestion, let me know if that is OK  :-)

#ifdef in code is discouraged.

#if defined(DEBUG) status = sbsa_gwdt_cf_read(SBSA_GWDT_WCS, wdd); /* Check if the watchdog was disabled */ if (status & SBSA_GWDT_WCS_EN) return -EIO; #endif

that isn't OK for you?

No. Same thing.

Guenter