Hi Timur,
Sorry, how do you trigger a panic if WS1 ties to reset ?? don't know what is your question
could you make it simple:
1) calling panic() on pre-timeout (WS0????) 2) calling panic() on timeout (WS1????)
in "first version" , I just print the timeleft for WS1 or panic when WS0 occurs.
On 25 May 2015 at 00:13, Timur Tabi timur@codeaurora.org wrote:
Fu Wei wrote:
in the first timeout, just panic() maybe not enough, in [RFC] version of my patchset, I offer some option as "preaction" to use, but for simplifying the first version of driver, I have deleted them. but at least, panic() is far more useful than a simple reset. at least, it can provide the context of the crashed system to admin.
My point is that there is very little difference between
- calling panic() on pre-timeout
- calling panic() on timeout
In both cases, the system will panic. The watchdog API says that the system should reset when a timeout occurs, so you cannot call panic() before the timeout expires.
If you want to warn user space, that will make driver more complicated, I don't think that is a good choose for a first version. but we can find a way to improve this later
In my opinion, this "first version" is not useful. I would like to see a pre-timeout feature that does not panic or reset when a pre-timeout occurs.
-- Sent by an employee of the Qualcomm Innovation Center, Inc. The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum, hosted by The Linux Foundation.