On 11/17/2013 03:26 PM, Rafael J. Wysocki wrote:
On Saturday, November 09, 2013 06:36:21 PM al.stone@linaro.org wrote:
From: Al Stone ahs3@redhat.com
I'm reading the patch as "the timer resolution in HW reduced mode is always 32-bit". Is my reading correct?
Whups, I see what I did. You are reading the patch correctly.
However, what the code should ultimately do is ignore the ACPI_FADT_32BIT_TIMER flag completely. Let me look at where the timer_resolution field is being used also since it is not immediately clear what value it should have, or if it should even be used, when in reduced HW mode.
Signed-off-by: Al Stone al.stone@linaro.org
drivers/acpi/acpica/utxface.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/acpi/acpica/utxface.c b/drivers/acpi/acpica/utxface.c index be322c8..fe94b3e 100644 --- a/drivers/acpi/acpica/utxface.c +++ b/drivers/acpi/acpica/utxface.c @@ -187,7 +187,8 @@ acpi_status acpi_get_system_info(struct acpi_buffer * out_buffer)
/* Timer resolution - 24 or 32 bits */
- if (acpi_gbl_FADT.flags & ACPI_FADT_32BIT_TIMER) {
- if (!acpi_gbl_reduced_hardware &&
(acpi_gbl_FADT.flags & ACPI_FADT_32BIT_TIMER)) {