Re: [Linaro-acpi] [PATCH 4/5] PROTO: ACPI: DSDT: add an i2c device for the exynos5250

On Tue, May 28, 2013 at 05:07:55PM +0200, Andrea Gallo wrote:

On 27 May 2013 17:40, Graeme Gregory graeme.gregory@linaro.org wrote:

...

From: Graeme Gregory graeme.gregory@linaro.org

For prototype add information for s3c24xx-i2c probing from DSDT

Signed-off-by: Graeme Gregory graeme.gregory@linaro.org

arch/arm/boot/asl/exynos5250-arndale.acpi/dsdt.asl | 46 ++++++++++++++------ 1 file changed, 33 insertions(+), 13 deletions(-)

diff --git a/arch/arm/boot/asl/exynos5250-arndale.acpi/dsdt.asl b/arch/arm/boot/asl/exynos5250-arndale.acpi/dsdt.asl index ed99d6e..165f283 100644 --- a/arch/arm/boot/asl/exynos5250-arndale.acpi/dsdt.asl +++ b/arch/arm/boot/asl/exynos5250-arndale.acpi/dsdt.asl @@ -1,23 +1,43 @@ /*

• Copyright (c) 2013, Al Stone ahs3@redhat.com

• • [DSDT] Description of the Arndale board (exynos5250)
  • This source is released under the terms of the GPLv2.
  */

DefinitionBlock (

•    "dsdt.aml",             // output filename
  

•    "DSDT",                 // table signature
  

•    1,                      // DSDT compliance revision
  

•    "REDHAT",               // OEM ID
  

•    "ARNDALE ",             // table ID
  

•    0x00000002)             // OEM revision
  

•   "dsdt.aml",             // output filename
  

•   "DSDT",                 // table signature
  

•   1,                      // DSDT compliance revision
  

•   "REDHAT",               // OEM ID
  

•   "ARNDALE ",             // table ID
  

•   0x00000002)             // OEM revision
  

[AG] why REDHAT as OEM ID? is this referring to the board manufacturer or the author of the table?

If the former, then OEM should be Samsung. If the latter, I guess it should be then LINARO instead of REDHAT, if this refers to the work done by Al under his Linaro assignment.

Hope Masters-Jon-Masters does not get mad at me :-)

These were set by Al, they should not actually have been in my patch but I think my editor settings have changed the whitespacing to be kernel compliant and I did not notice when I commited.

Graeme

...

{

• Scope (_PR)
• {

•    Processor (CPU0, 0x01, 0x00000410, 0x06) {}
  

•    Processor (CPU1, 0x02, 0x00000410, 0x06) {}
  

• }

-}

•   Scope (\_PR)
  

•   {
  

•           Processor (CPU0, 0x01, 0x00000410, 0x06) {}
  

•           Processor (CPU1, 0x02, 0x00000410, 0x06) {}
  

•   }
  

•   Scope (\_SB)
  

•   {
  

•           Device (GPB3) {
  

•           }
  
  

•           Device (I2C) {
  

•                   Name (_HID, "LINA0001")
  

•                   Name (_UID, 0)
  

•                   Method (_CRS, 0x0, NotSerialized) {
  

•                           Name (RBUF, ResourceTemplate ()
  

•                           {
  

•                                   Memory32Fixed (ReadWrite, 0x12C60000, 0x00000100)
  

•                                   Interrupt (ResourceConsumer, Level, ActiveLow, Exclusive, , , ) {0x58}
  

•                                   GpioIo (Exclusive, PullDefault, , , , "\\_SB.GPB3") {0x2A, 0x2B}
  

•                           })
  

•                   Return (RBUF)
  

•                   }
  

•           }
  

•   }
  

+}

1.7.10.4