Re: [Linaro-acpi] [PATCH 03/11] irqchip / GIC: Add GIC version support in ACPI MADT

On Mon, 18 May 2015, Hanjun Guo wrote:

diff --git a/drivers/acpi/irq.c b/drivers/acpi/irq.c index 65d6b93..855ead9 100644 --- a/drivers/acpi/irq.c +++ b/drivers/acpi/irq.c @@ -32,6 +32,9 @@ void __init acpi_irqchip_init(void) if (acpi_disabled) return;

• if (acpi_gic_version_init())

• return;
  

This looks just wrong. acpi_irqchip_init() is a generic ACPI function and now you stick a GIC specific callback into it?

What calls acpi_irqchip_init?

Thanks,

tglx