On 2013-11-15 6:11, Al Stone wrote:
On 11/13/2013 02:28 AM, Hanjun Guo wrote:
On 2013-11-13 11:16, al.stone@linaro.org wrote:
From: Al Stone ahs3@redhat.com
Signed-off-by: Al Stone al.stone@linaro.org
drivers/acpi/bus.c | 3 ++- drivers/acpi/osl.c | 10 ++++++---- drivers/acpi/pci_link.c | 14 ++++++++------ 3 files changed, 16 insertions(+), 11 deletions(-)
diff --git a/drivers/acpi/bus.c b/drivers/acpi/bus.c index 439c369..7fcbc6a 100644 --- a/drivers/acpi/bus.c +++ b/drivers/acpi/bus.c @@ -543,7 +543,8 @@ void __init acpi_early_init(void) goto error0; }
-#ifdef CONFIG_X86 +#if (!CONFIG_ACPI_REDUCED_HARDWARE)
CONFIG_X86 is definitely *not* reduced hardware, why should we change it here?
The reasoning is: x86 is not yet reduced HW; there are rumors that such chips are either out there or coming. In that case, there could be an x86 machine that _is_ reduced hardware and I do not want to preclude that case.
Does that make sense?
Thanks for the clarify, I agree.
It is not *rumors*, they are working on it now, just have a look at the patch sent from intel, they fix some issues on reduced hardware platform:
Date: Thu, 21 Nov 2013 11:20:23 +0100 Message-ID: 87d2lu83a0.fsf@tldlab276.tl.intel.com MIME-Version: 1.0 Content-Type: text/plain --text follows this line-- Hi,
*When executing on a ACPI Hardware reduced hardware*, all the ACPI tables are not exposed in sysfs due to the fact that FACS is silently ignored by the kernel in ACPI hardware reduced and, moreover, the acpi_tables_sysfs_init ACPI table walk is buggy and stop too soon.
The acpi_tables_sysfs_init function should to rely on the appropriate acpi_status return values to decide or not to stop the iteration. This way, when running on a ACPI Reduced Harware environment where the FACS table is silently ignored by the kernel or some ACPI table are not correctly memory mapped or have a bad checksum it would not stop the iteration.
Signed-off-by: Jeremy Compostella jeremy.compostella@intel.com
--- drivers/acpi/sysfs.c | 52 ++++++++++++++++++++++++++------------------------ 1 file changed, 27 insertions(+), 25 deletions(-)
diff --git a/drivers/acpi/sysfs.c b/drivers/acpi/sysfs.c index fcae5fa..72a3250 100644