On 2015年05月27日 00:35, Timur Tabi wrote:
On 05/26/2015 03:28 AM, Hanjun Guo wrote:
early_acpi_os_unmap_memory((char *)table, tbl_size);}
please add
#ifdef CONFIG_ARM_SBSA_WATCHDOG (acpi gtdt code) #endif
I don't agree with this. The GTDT should be parsed even if there's no watchdog driver compiled for this kernel. There are no other #ifdefs in this file.
So what's the point of parse GTDT and alloc memories for it if there is no watchdog driver compiled for the kernel? will the module insmod later even if the CONFIG_ARM_SBSA_WATCHDOG=n?
* Add a platform device named "sbsa-gwdt" to match the platformdriver.
* "sbsa-gwdt": SBSA(Server Base System Architecture) GenericWatchdog
* The platform driver can get device info below by matching thisname.
- The platform driver (drivers/watchdog/sbsa_gwdt.c) can get device info
below by matching this name.
Adding the file name which will help for review and maintain in my opinion.
Except it will cause problems if the driver is renamed or moved. I don't think this is a good idea, either (sorry!)
OK, that's good point. but what I proposed is some hint to which driver will use the data prepared in this file, we can easily understand it in this patchset, but if just review the code in this fiel, I think people will be confused without detail comments.
Thanks Hanjun