On 2015年02月20日 20:12, Sudeep Holla wrote:
On 18/02/15 13:53, Hanjun Guo wrote:
When MADT is parsed, print GIC information to make the boot log look pretty:
ACPI: GICC (acpi_id[0x0000] address[00000000e112f000] MPIDR[0x0] enabled) ACPI: GICC (acpi_id[0x0001] address[00000000e112f000] MPIDR[0x1] enabled) ... ACPI: GICC (acpi_id[0x0201] address[00000000e112f000] MPIDR[0x201] enabled)
These information will be very helpful to bring up early systems to see if acpi_id and MPIDR are matched or not as spec defined.
IMO this patch can go independent to ARM64 related changes if required.
CC: Rafael J. Wysocki rjw@rjwysocki.net Tested-by: Suravee Suthikulpanit Suravee.Suthikulpanit@amd.com Tested-by: Yijing Wang wangyijing@huawei.com Tested-by: Mark Langsdorf mlangsdo@redhat.com Tested-by: Jon Masters jcm@redhat.com Tested-by: Timur Tabi timur@codeaurora.org Tested-by: Robert Richter rrichter@cavium.com Acked-by: Robert Richter rrichter@cavium.com Signed-off-by: Hanjun Guo hanjun.guo@linaro.org Signed-off-by: Tomasz Nowicki tomasz.nowicki@linaro.org
drivers/acpi/tables.c | 43 +++++++++++++++++++++++++++++++++++++++++++ 1 file changed, 43 insertions(+)
diff --git a/drivers/acpi/tables.c b/drivers/acpi/tables.c index 93b8152..a85aeeb 100644 --- a/drivers/acpi/tables.c +++ b/drivers/acpi/tables.c @@ -183,6 +183,49 @@ void acpi_table_print_madt_entry(struct acpi_subtable_header *header) } break;
- case ACPI_MADT_TYPE_GENERIC_INTERRUPT:
{struct acpi_madt_generic_interrupt *p =(struct acpi_madt_generic_interrupt *)header;pr_info("GICC (acpi_id[0x%04x] address[%p] MPIDR[0x%llx]%s)\n",
p->uid, (void *)(unsigned long)p->base_address,p->arm_mpidr,(p->flags & ACPI_MADT_ENABLED) ? "enabled" :"disabled");
Just curious to know if this will not be considered too noisy on large systems ? E.g. Cavium Thunder88xx with 96 CPUs
Actually on big x86 machines such as with more than 500 CPUs, those information will be pretty noise, how about using pr_debug() instead of pr_info()?
Otherwise the change looks fine: Acked-by: Sudeep Holla sudeep.holla@arm.com
Thanks!
Hanjun