On Fri, Jun 13, 2014 at 03:10:51PM +0200, Robert Richter wrote:
On 13.06.14 13:02:58, Tomasz Nowicki wrote:
@@ -811,6 +819,8 @@ static int ghes_notify_nmi(unsigned int cmd, struct pt_regs *regs) int sev, sev_global = -1; int ret = NMI_DONE;
- BUG_ON(!IS_ENABLED(ARCH_HAS_ACPI_APEI_NMI));
Now that we have the ARCH_HAS_ACPI_APEI_NMI option, group nmi code, put it in an #ifdef ... and make function stubs for the !nmi case where necessary. That code should moved to patch #2. If an arch does not support nmi code, we don't want to compile it into the kernel.
Also this patch is quit a bit large and should further split into moving functional code into separate functions and the introduction of the notifier setup. This makes review much easier.
I did not yet took a deep look into your notifier framework, but I don't really see a reason for the dynamic collection of function pointers in ghes_notify_tab. See below.
Ok, I'll wait out with further review after you've integrated Robert's comments.
Thanks.