On 12 May 2015 at 18:37, Fu Wei fu.wei@linaro.org wrote:
Hi Timur,
yes, I am not 100% sure that is good, but I just learned it from other Kconfigs, they are doing this and I didn't see the bad side of it. because if we want to debug WDT , we may just debug one module ,and we wouldn't turn on it in production :-)
but just let watchdog maintainer decide it. for this patchset ,it is just a side-product :-)
With this statement you answered the question, this is completely independent of your patchset and should go upstream separately.
Graeme
Thanks
On 13 May 2015 at 01:25, Timur Tabi timur@codeaurora.org wrote:
But the only thing that this Kconfig option does is add the -DDEBUG command-line parameter. If every driver did that, the Kconfigs would be a mess. And then, all that does is enable a bunch of pr_debugs in your driver.
The watchdog maintainer should decide, of course, but I think this kind of Kconfig option sets a bad precedent.
On 05/12/2015 10:03 AM, Fu Wei wrote:
Hi Timur,
thanks , I just feel it's convenient if we have that, it is a option, it can be ignore or merge, :-)
see if people like it :-)
On 12 May 2015 at 22:40, Timur Tabi <timur@codeaurora.org mailto:timur@codeaurora.org> wrote:
fu.wei@linaro.org <mailto:fu.wei@linaro.org> wrote: +config WATCHDOG_DEBUG + bool "Debug support for WATCHDOG drivers" + depends on DEBUG_KERNEL + help + Say "yes" to enable debug messaging (like dev_dbg and pr_debug), + sysfs, and debugfs support in WatchDog controller and protocol drivers. + I personally don't like Kconfig debugging options like that. If I want to debug a driver, I'll just add "#define DEBUG" to the top of the file and rebuild. -- Sent by an employee of the Qualcomm Innovation Center, Inc. The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum, hosted by The Linux Foundation.-- Best regards,
Fu Wei Software Engineer Red Hat Software (Beijing) Co.,Ltd.Shanghai Branch Ph: +86 21 61221326(direct) Ph: +86 186 2020 4684 (mobile) Room 1512, Regus One Corporate Avenue,Level 15, One Corporate Avenue,222 Hubin Road,Huangpu District, Shanghai,China 200021
-- Qualcomm Innovation Center, Inc. The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum, a Linux Foundation Collaborative Project.
-- Best regards,
Fu Wei Software Engineer Red Hat Software (Beijing) Co.,Ltd.Shanghai Branch Ph: +86 21 61221326(direct) Ph: +86 186 2020 4684 (mobile) Room 1512, Regus One Corporate Avenue,Level 15, One Corporate Avenue,222 Hubin Road,Huangpu District, Shanghai,China 200021