Hi Timur,
Thanks for your rapid feedback :-)
On 4 February 2016 at 01:27, Timur Tabi timur@codeaurora.org wrote:
fu.wei@linaro.org wrote:
+#ifdef CONFIG_ARM_SBSA_WATCHDOG_PANIC +static bool panic_enabled = true;
I think this should default to 'false', because IMHO, this seems like an odd
yes, It make sense to make it default to 'false'.
feature. I'm not crazy about the fact that there's a Kconfig option for it either, but I'm not going to NACK this patch.
I personally would prefer to drop this patch, and just wait for full-blown pre-timeout support. It feels like a debugging feature that doesn't really
sorry, are you saying : using pre-timeout instead of this half timeout?
But even we have pre-timeout support, pre-timeout == timeout / 2, it can not be configured without touch timeout.
if you want pre-timeout != timeout / 2, we have to modify WCV in the interrupt routine. (because of the explicit watchdog refresh mechanism)
Could you let me know why we need pre-timeout here ?? :-)
belong upstream. But like I said, it's just my opinion, and I won't complain if I'm outvoted.
I think this debugging feature is the purpose of the two-stage watchdog, if I understand correctly