Hi Al,
On 7 May 2014 15:04, Al Stone al.stone@linaro.org wrote:
On 05/06/2014 08:10 AM, Ashwin Chaugule wrote:
This series contains experimental patchwork for PCC and CPPC as defined in the current ACPI5.0a spec. The PCC patch was tested on an ARMv7 platform and on a hacked up PCC emulator. The CPPC part is only compile tested. Both are very much a WIP. Any feedback and help with testing would be highly appreciated!
Ashwin Chaugule (2): ACPI: Add support for Platform Communication Channel CPPC: Initial support for Collaborative Processor Performance Control
arch/arm64/Kconfig | 2 + drivers/acpi/Kconfig | 10 ++ drivers/acpi/Makefile | 2 +- drivers/acpi/pcc.c | 209 +++++++++++++++++++++++++++++ drivers/cpufreq/Kconfig | 11 +- drivers/cpufreq/Makefile | 1 + drivers/cpufreq/cppc-cpufreq.c | 298 +++++++++++++++++++++++++++++++++++++++++ 7 files changed, 531 insertions(+), 2 deletions(-) create mode 100644 drivers/acpi/pcc.c create mode 100644 drivers/cpufreq/cppc-cpufreq.c
I think I'm liking this patch set. There are a couple of minor things -- e.g., alignment of the comments in the definition of enum cppc_pcc_regs -- but for the most part, looks pretty good.
Thanks! I'll fix this in the next revision.
For upstreaming, I think it would be wise to provide a way to test this (as part of the patch set) so it can be demonstrated it works to most anyone that wants to try it. If that could be done in such a way so that it's arch-independent, that would be even cooler. Barring that, I think it's critical that others know how to reproduce what's been done, so at a minimum there needs to be detailed data on how to test this.
I started documenting this under "PCC driver testing" here - https://wiki.linaro.org/LEG/Engineering/Kernel/ACPI/PowerManagement/CPPC The links to the test code and emulator will be updated as soon as I resolve some git issues with my account on git.linaro.org.
Cheers, Ashwin