Re: [Linaro-acpi] [linaro-acpi PATCH v2 0/4] acpi-asl: DBG2 table template support

On 03/19/2014 04:30 AM, Naresh Bhat wrote:

On 19 March 2014 15:51, Graeme Gregory <graeme.gregory@linaro.org mailto:graeme.gregory@linaro.org> wrote:

On Wed, Mar 19, 2014 at 03:16:59PM +0530, Naresh Bhat wrote:
 >    Hi Graeme,
 >    Thanks for the comments. I will wait for Al Stone reply. My
comments
 >    are as below
 >    On 19 March 2014 14:38, Graeme Gregory
<[1]graeme.gregory@linaro.org <mailto:graeme.gregory@linaro.org>>
 >    wrote:
 >
 >      Hi Naresh,
 >      Why did we merge these when we decided DBG2 was not suitable
for use
 >      on arm? I am confused and I think it will also confuse
anyone using
 >      acpi-asl for reference!
 >
 >    I am not sure, Did I miss any discussion about DBG2 with-in
Linaro ACPI
 >    group.
 >    I have discussed regarding these patches with Al Stone
yesterday, we
 >    decided it is safe to support whether or not to use it for early
 >    console.
 >
No, you were present for them on the hangout and when you and I
discussed this on IRC.

It is also the reason why we closed the cards which you agreed to.

Argh. My bad. I've confused the issue.

I was operating under the assumption it would be safe to support this table since we don't use it. So, if iasl, mab, and other tools can process the table, that's fine -- but only if the kernel does not USE the table to do anything.

If we're also adding patches to the kernel to use DBG2, or include it in a set of tables for the kernel, then I was wrong -- let's not do that. If we're just adding patches to tools that manipulate tables, then I don't see any risks from that -- and that was what I thought we were doing.

My apologies for the confusion. I was not paying attention :(.

 >      In fact having looked at the tables they are invalid anyway
as they
 >      reference a device on PCI.
 >
 >    agreed. It's a template.
 >
But its not a template, you checked them in as valid tables for the
platforms in question.

This means if upstream kernel implements DBG2 suddenly platforms could
crash randomly.

This I beleive should be avoided.

Ok, If that's the case, I will remove those patches from repo.

Graeme

 >      Graeme
 >
 >    On Wed, Mar 19, 2014 at 02:07:30PM +0530, Naresh Bhat wrote:
 >    > Hi Al Stone,
 >    > Thanks. I have merged DBG2 template, compilation support
patches into
 >
 >      > acpi-asl git
 >      repo[1][2]https://git.linaro.org/leg/acpi/acpi-asl.git
 >      > Regards
 >      > -Naresh
 >      > On 10 January 2014 03:34, Al Stone
<[2][3]al.stone@linaro.org <mailto:al.stone@linaro.org>>
 >      wrote:
 >      >
 >      > On 12/16/2013 03:55 AM, [3][4]naresh.bhat@linaro.org
<mailto:naresh.bhat@linaro.org> wrote:
 >      >
 >      > From: Naresh Bhat <[4][5]naresh.bhat@linaro.org
<mailto:naresh.bhat@linaro.org>>
 >
 >    > The DBG2 table support in iASL compiler will be
 >    > available in the next release of acpica
 >
 >      >
 >
  [5][6]https://github.com/acpica/acpica/commit/278cbb119f090d3aad0480
 >      381
 >
 >    > 126c1ae8e59d66b
 >    > the following set of patches support the DBG2 table template in
 >    > acpi-asl tool.
 >    > Naresh Bhat (4):
 >    > ACPI / ASL: Add DBG2 table template
 >    > DBG2: Update platforms manifest
 >    > DBG2: Update xsdt entries across platforms
 >    > DBG2: Support DBG2 table compilation
 >    > platforms/exynos5250-arndale.acpi/dbg2.asl | 106
 >    > ++++++++++++++++++++
 >    > .../exynos5250-arndale.manifest | 1 +
 >    > platforms/exynos5250-arndale.acpi/xsdt.asl | 1 +
 >    > platforms/foundation-v8.acpi/dbg2.asl | 106 ++++++++++++++++++++
 >    > .../foundation-v8.acpi/foundation-v8.manifest | 1 +
 >    > platforms/foundation-v8.acpi/xsdt.asl | 1 +
 >    > platforms/rtsm_ve-aemv8a.acpi/dbg2.asl | 106
++++++++++++++++++++
 >    > .../rtsm_ve-aemv8a.acpi/rtsm_ve-aemv8a.manifest | 1 +
 >    > platforms/rtsm_ve-aemv8a.acpi/xsdt.asl | 1 +
 >    > tools/common/build_aml.c | 1 +
 >    > tools/common/check_aml.c | 1 +
 >    > tools/common/include/check_aml.h | 1 +
 >    > 12 files changed, 327 insertions(+)
 >    > create mode 100644 platforms/exynos5250-arndale.acpi/dbg2.asl
 >    > create mode 100644 platforms/foundation-v8.acpi/dbg2.asl
 >    > create mode 100644 platforms/rtsm_ve-aemv8a.acpi/dbg2.asl
 >    >
 >    > Now that DBG2 support has been accepted in ACPICA and published,
 >    > and that acpica-tools has been updated to the 20131215 version
 >    > that contains the fixes needed, these patches can be safely
 >    > merged in.
 >
 >      > Acked-by: Al Stone <[6][7]al.stone@linaro.org
<mailto:al.stone@linaro.org>>
 >
 >    > --
 >    > ciao,
 >    > al
 >    > -----------------------------------
 >    > Al Stone
 >    > Software Engineer
 >    > Linaro Enterprise Group
 >
 >      > [7][8]al.stone@linaro.org <mailto:al.stone@linaro.org>
 >      > -----------------------------------
 >      >
 >      > References
 >      >
 >      > 1. [9]https://git.linaro.org/leg/acpi/acpi-asl.git
 >      > 2. mailto:[10]al.stone@linaro.org <mailto:al.stone@linaro.org>
 >      > 3. mailto:[11]naresh.bhat@linaro.org
<mailto:naresh.bhat@linaro.org>
 >      > 4. mailto:[12]naresh.bhat@linaro.org
<mailto:naresh.bhat@linaro.org>
 >      > 5.
 >
  [13]https://github.com/acpica/acpica/commit/278cbb119f090d3aad048038
 >      1126c1ae8e59d66b
 >      > 6. mailto:[14]al.stone@linaro.org <mailto:al.stone@linaro.org>
 >      > 7. mailto:[15]al.stone@linaro.org <mailto:al.stone@linaro.org>
 >      > _______________________________________________
 >      > Linaro-acpi mailing list
 >      > [16]Linaro-acpi@lists.linaro.org
<mailto:Linaro-acpi@lists.linaro.org>
 >      > [17]http://lists.linaro.org/mailman/listinfo/linaro-acpi
 >
 > References
 >
 >    1. mailto:graeme.gregory@linaro.org
<mailto:graeme.gregory@linaro.org>
 >    2. https://git.linaro.org/leg/acpi/acpi-asl.git
 >    3. mailto:al.stone@linaro.org <mailto:al.stone@linaro.org>
 >    4. mailto:naresh.bhat@linaro.org <mailto:naresh.bhat@linaro.org>
 >    5. mailto:naresh.bhat@linaro.org <mailto:naresh.bhat@linaro.org>
 >    6.
https://github.com/acpica/acpica/commit/278cbb119f090d3aad0480381
 >    7. mailto:al.stone@linaro.org <mailto:al.stone@linaro.org>
 >    8. mailto:al.stone@linaro.org <mailto:al.stone@linaro.org>
 >    9. https://git.linaro.org/leg/acpi/acpi-asl.git
 >   10. mailto:al.stone@linaro.org <mailto:al.stone@linaro.org>
 >   11. mailto:naresh.bhat@linaro.org <mailto:naresh.bhat@linaro.org>
 >   12. mailto:naresh.bhat@linaro.org <mailto:naresh.bhat@linaro.org>
 >   13.
https://github.com/acpica/acpica/commit/278cbb119f090d3aad0480381126c1ae8e59d66b
 >   14. mailto:al.stone@linaro.org <mailto:al.stone@linaro.org>
 >   15. mailto:al.stone@linaro.org <mailto:al.stone@linaro.org>
 >   16. mailto:Linaro-acpi@lists.linaro.org
<mailto:Linaro-acpi@lists.linaro.org>
 >   17. http://lists.linaro.org/mailman/listinfo/linaro-acpi