On 4 February 2016 at 02:26, Timur Tabi timur@codeaurora.org wrote:
Fu Wei wrote:
Actually, the SBSA watchdog driver should support only half-timeout for panic the user cannot configure the length of "panic time", He can only enable it, and it is automatically set to 1/2 timeout.
we don't need pre-timeout here.
Hope I understand you correctly:-) sorry for your confusion
So when pre-timeout occurs, the interrupt handler calls panic() or whatever it's supposed to do.
Actually, So when 1/2 timeout occurs, the interrupt handler calls panic() or whatever it's supposed to do.
I understand all that. What I'm saying is that, in the future, when pre-timeout support is added to the watchdog layer, I think it makes sense to modify this driver to use pre-timeout support.
As you know I have made the pre-timeout support patch, If people like it, i am happy to go on upstream it separately.
If we want to use pre-timeout here, user only can use get_pretimeout and disable panic by setting pretimeout to 0 but user can not really set pretimeout, because "pre-timeout == timeout / 2 (always)". if user want to change pretimeout, he/she has to set_time instead.