Re: [Linaro-acpi] [PATCH v2 4/6] Watchdog: introdouce ARM SBSA watchdog driver (1)use linux kernel watchdog framework (2)work with FDT (3)support pretimeout, for now in first timeout(WS0), do panic to save system context.

On 05/07/2015 09:42 PM, Fu Wei wrote:

Hi Guenter, At least I never got this error, I borrow this from another WDT driver in mainline kernel, I think it's good to check if our operation is executed well.

Not really. If it is unnecessary, it increases kernel size for no good reason. And I really dislike the argument that "others did it as well". Maybe they had a reason.

I have seen an embedded system so cluttered with unnecessary checks that it ended up literally twice as large as it had to, and it had severe performance problems on top of that. So far Linux avoided that fate. I would prefer to keep it that way.

Thanks, Guenter