On 05/24/2015 09:44 AM, Timur Tabi wrote:
Guenter Roeck wrote:
The current watchdog API suggests that the pretimeout "allows Linux to record useful information (like panic information and kernel coredumps) before it resets". The call to panic() would be the means to make this happen.
Now that I think about it, that does make sense.
However, if a pre-timeout is not set, then the driver should never call panic(). That means that the interrupt handler should only be registered if sbsa_gwdt_set_pretimeout() is called.
This is a matter of opinion. Some watchdogs have two (or even more) levels of timeouts without explicit pretimeout. The iTCO watchdog in Intel systems is an example, but there are several others.
For such systems, there may be an initial interrupt followed by a hard reset a little later. In such cases it does make sense to wire up the interrupt and have it call panic(). If the system gets stuck, the second timeout will reset it.
Guenter