Re: [Linaro-acpi] [PATCH 09/12] ACPI: add clarifying comment about processor throttling in HW reduced mode

On Saturday, November 09, 2013 06:36:19 PM al.stone@linaro.org wrote:

From: Al Stone ahs3@redhat.com

Signed-off-by: Al Stone al.stone@linaro.org

drivers/acpi/processor_throttling.c | 8 ++++++++ 1 file changed, 8 insertions(+)

diff --git a/drivers/acpi/processor_throttling.c b/drivers/acpi/processor_throttling.c index e7dd2c1..200738e 100644 --- a/drivers/acpi/processor_throttling.c +++ b/drivers/acpi/processor_throttling.c @@ -942,6 +942,10 @@ static int acpi_processor_get_fadt_info(struct acpi_processor *pr) return -EINVAL; }

• /*

• * NB: in HW reduced mode, duty_width is always zero
  

• * so this count may not be what is wanted.
  

• */
  

  pr->throttling.state_count = 1 << acpi_gbl_FADT.duty_width;

/* @@ -991,6 +995,10 @@ static int acpi_processor_set_throttling_fadt(struct acpi_processor *pr, /* Used to clear all duty_value bits */ duty_mask = pr->throttling.state_count - 1;

• /*
  

•  * NB: in HW reduced mode, duty_offset is always zero
  

•  * so this mask may not be what is wanted.
  

•  */
  

  duty_mask <<= acpi_gbl_FADT.duty_offset; duty_mask = ~duty_mask; }

I'm not sure how these comments help to be honest. It looks like pr->throttling.state_count should be 0 in HW reduced mode, shouldn't it?