Hi Borislav,
On 10 August 2016 at 18:45, Borislav Petkov bp@suse.de wrote:
On Wed, Aug 10, 2016 at 06:40:53PM +0800, Fu Wei wrote:
But the reason for a separate hest_ia32_init() is: For now(ACPI 6.1), we have three IA-32 Architecture-specific error source structures, maybe we will parse them later. So I made this hest_ia32_init() for all these structures. maybe we can do :
So I'd make it as simple as possible now and cross that bridge only when we get there, i.e., only when you are adding support for those and not earlier.
OK, got your point. Sorry for sending v13 before checking this with you.
so I will do :
@@ -232,8 +243,9 @@ void __init acpi_hest_init(void) goto err; }
- if (!acpi_disable_cmcff) - apei_hest_parse(hest_parse_cmc, NULL); + rc =apei_hest_parse(hest_parse_cmc, NULL); + if (rc) + goto err;
if (!ghes_disable) { rc = apei_hest_parse(hest_parse_ghes_count, &ghes_count);
Do you have other suggestion? then I can post v14 to fix it :-)
-- Regards/Gruss, Boris.
ECO tip #101: Trim your mails when you reply.
SUSE Linux GmbH, GF: Felix Imendörffer, Jane Smithard, Graham Norton, HRB 21284 (AG Nürnberg)