On 06/10/2015 04:43 PM, Y Vo wrote:
On Wed, Jun 10, 2015 at 2:33 PM, Hanjun Guo hanjun.guo@linaro.org wrote:
On 06/10/2015 02:23 AM, Mark Brown wrote:
On Tue, Jun 09, 2015 at 07:09:47PM +0100, Build bot for Mark Brown wrote:
arm64-allmodconfigERROR: "acpi_gpiochip_request_interrupts" [drivers/gpio/gpio-xgene-sb.ko] undefined! ERROR: "acpi_gpiochip_free_interrupts" [drivers/gpio/gpio-xgene-sb.ko] undefined!
Today's -next fails to build an arm64 allmodconfig due to commit 733cf014f02040b3ad (gpio: xgene: add ACPI support for APM X-Gene GPIO standby driver) which adds ACPI support to the X-Gene standby driver without either adding a dependency on ACPI or there being stubs in the ACPI headers for the above functions in !ACPI configurations. My instinct is that the stubs are going to be nicer since it'll save on ifdefs in drivers which seems nicer.
It seems that acpi_gpiochip_request_interrupts didn't export so there will be a compile error when xgene-sb compiled as a ko, I prepared a patch below:
Coud you help to submit this patch ?
No problem, will do it right now.
Thanks Hanjun