On Sun, Nov 17, 2013 at 04:17:55PM -0700, al.stone@linaro.org wrote:
From: Al Stone ahs3@redhat.com
This code will be handled in a different manner (either PSCI or other kernel code) so is not needed for ARMv7/v8 systems.
Signed-off-by: Al Stone al.stone@linaro.org
arch/arm/include/asm/acpi.h | 7 ------- arch/arm64/include/asm/acpi.h | 7 ------- drivers/acpi/sleep.c | 2 ++ 3 files changed, 2 insertions(+), 14 deletions(-)
diff --git a/arch/arm/include/asm/acpi.h b/arch/arm/include/asm/acpi.h index a6989d8..7907c81 100644 --- a/arch/arm/include/asm/acpi.h +++ b/arch/arm/include/asm/acpi.h @@ -118,13 +118,6 @@ extern int acpi_suspend_lowlevel(void); extern void prefill_possible_map(void); -/* Physical address to resume after wakeup */ -/* BOZO: was... -#define acpi_wakeup_address ((unsigned long)(real_mode_header->wakeup_start)) -*/ -#define acpi_wakeup_address (0)
static inline void disable_acpi(void) { acpi_disabled = 1; diff --git a/arch/arm64/include/asm/acpi.h b/arch/arm64/include/asm/acpi.h index c1dc30d..0409796 100644 --- a/arch/arm64/include/asm/acpi.h +++ b/arch/arm64/include/asm/acpi.h @@ -96,13 +96,6 @@ extern int acpi_suspend_lowlevel(void); extern void prefill_possible_map(void); -/* Physical address to resume after wakeup */ -/* BOZO: was... -#define acpi_wakeup_address ((unsigned long)(real_mode_header->wakeup_start)) -*/ -#define acpi_wakeup_address (0)
static inline void disable_acpi(void) { acpi_disabled = 1; diff --git a/drivers/acpi/sleep.c b/drivers/acpi/sleep.c index 721e949..0847fd6 100644 --- a/drivers/acpi/sleep.c +++ b/drivers/acpi/sleep.c @@ -58,6 +58,7 @@ static struct notifier_block tts_notifier = { static int acpi_sleep_prepare(u32 acpi_state) { +#if !(defined(CONFIG_ARM) || defined(CONFIG_ARM64)) #ifdef CONFIG_ACPI_SLEEP /* do we have a wakeup address for S2 and S3? */ if (acpi_state == ACPI_STATE_S3) { @@ -68,6 +69,7 @@ static int acpi_sleep_prepare(u32 acpi_state) } ACPI_FLUSH_CPU_CACHE(); #endif +#endif
Im not sure this is needed, all this ends up doing is setting
acpi_gbl_FACS->firmware_waking_vector
to the address passed. I think we can probably just use a dummy value here on arm to save the clumsy #if defined() stuff.
It is only used in arch/x86/kernel/tboot.c so should not affect arm at all.
Graeme