From: Naresh Bhat naresh.bhat@linaro.org
The patch set will add the DBG2 table, compilation support. I have just added only one sample SER0 device. If DBG2 table fields, values looks ok. Then I will add 3 more devices (SER1 to SER3), Since there are 4 UART devices in foundation-v8 model.
Signed-off-by: Naresh Bhat naresh.bhat@linaro.org
Naresh Bhat (2): dbg2: Add dbg2 table Add support to compile dbg2 table
platforms/foundation-v8.acpi/dbg2.asl | 47 ++++++++++++++++++++ .../foundation-v8.acpi/foundation-v8.manifest | 1 + platforms/foundation-v8.acpi/xsdt.asl | 1 + tools/common/build_aml.c | 1 + tools/common/check_aml.c | 1 + tools/common/include/check_aml.h | 1 + 6 files changed, 52 insertions(+) create mode 100644 platforms/foundation-v8.acpi/dbg2.asl
From: Naresh Bhat naresh.bhat@linaro.org
Add the dbg2 table.
Signed-off-by: Naresh Bhat naresh.bhat@linaro.org --- platforms/foundation-v8.acpi/dbg2.asl | 47 ++++++++++++++++++++ .../foundation-v8.acpi/foundation-v8.manifest | 1 + 2 files changed, 48 insertions(+) create mode 100644 platforms/foundation-v8.acpi/dbg2.asl
diff --git a/platforms/foundation-v8.acpi/dbg2.asl b/platforms/foundation-v8.acpi/dbg2.asl new file mode 100644 index 0000000..49d437f --- /dev/null +++ b/platforms/foundation-v8.acpi/dbg2.asl @@ -0,0 +1,47 @@ +/* + * Intel ACPI Component Architecture + * iASL Compiler/Disassembler version 20130117-64 [Jan 31 2013] + * Copyright (c) 2000 - 2013 Intel Corporation + * + * Template for [DBG2] ACPI Table + * Format: [ByteLength] FieldName : HexFieldValue + */ + +[0004] Signature : "DBG2" [Debug Port table 2] +[0004] Table Length : 00000034 +[0001] Revision : 01 +[0001] Checksum : 00 +[0006] Oem ID : "LINARO" +[0008] Oem Table ID : "TEMPLATE" +[0004] Oem Revision : 00000001 +[0004] Asl Compiler ID : "INTL" +[0004] Asl Compiler Revision : 20130927 + + +[0004] Info Offset : 00000044 [First DDIS entry] +[0004] Info Count : 00000001 [Number of DDIS entries] + +[0001] Subtable Type : 00 [Debug Device Information Structure] +[0001] Revision : 00 +[0002] Length : 26 [len of DDIS + Namepath + OEM Data] +[0001] Register Count : 01 [Number of GAS register] +[0001] Namepath Length : 21 [Namepath len + null] +[0001] Namepath Offset : 37 [len from beginning of this structure to Namepath] +[0002] OEM Data Length : 00 [OEM data block len] +[0002] OEM Data Offset : 00 [value is 0 if no OEM data present] +[0002] Port Type : 0x8000 [Serial] +[0002] Port Subtype : 0x0000 [Fully 16550-compatible] +[0002] Reserved : 00 [must be 0] +[0002] Base Address Offset : 21 [len from beginning of this structure to GAS] +[0002] Address Size Offset : 33 [len from beginning of this structure to AddressSize] + +[0012] Base Address Register : [Generic Address Structure] +[0001] Space ID : 00 [SystemMemory] +[0001] Bit Width : 08 +[0001] Bit Offset : 00 +[0001] Encoded Access Width : 00 [Undefined/Legacy] +[0008] Address : 000000000C090000 + +[0004] Address Size : 0x1000 [corresponding to each generic address above] +[0001] Namepath : "_SB_.SMB_.FPGA.SER0" [Null terminated ASCII string uniquely indetify device] +[0001] OEM Data : 00 [Optional, variable-length OEM specific data] diff --git a/platforms/foundation-v8.acpi/foundation-v8.manifest b/platforms/foundation-v8.acpi/foundation-v8.manifest index 6b3a743..bd6c5a7 100644 --- a/platforms/foundation-v8.acpi/foundation-v8.manifest +++ b/platforms/foundation-v8.acpi/foundation-v8.manifest @@ -31,4 +31,5 @@ erst: erst.asl fpdt: fpdt.asl mchi: mchi.asl msct: msct.asl +dbg2: dbg2.asl
From: Naresh Bhat naresh.bhat@linaro.org
Add support to compile DBG2 table.
Signed-off-by: Naresh Bhat naresh.bhat@linaro.org --- platforms/foundation-v8.acpi/xsdt.asl | 1 + tools/common/build_aml.c | 1 + tools/common/check_aml.c | 1 + tools/common/include/check_aml.h | 1 + 4 files changed, 4 insertions(+)
diff --git a/platforms/foundation-v8.acpi/xsdt.asl b/platforms/foundation-v8.acpi/xsdt.asl index 3145d2b..43fc588 100644 --- a/platforms/foundation-v8.acpi/xsdt.asl +++ b/platforms/foundation-v8.acpi/xsdt.asl @@ -37,3 +37,4 @@ [0008] ACPI Table Address 0 : 0000000000000120 [0008] ACPI Table Address 0 : 0000000000000130 [0008] ACPI Table Address 0 : 0000000000000140 +[0008] ACPI Table Address 0 : 0000000000000150 diff --git a/tools/common/build_aml.c b/tools/common/build_aml.c index 34cdfe4..4e70348 100644 --- a/tools/common/build_aml.c +++ b/tools/common/build_aml.c @@ -41,6 +41,7 @@ char *known_sigs[] = { "ssdt", "uefi", "xsdt", + "dbg2", NULL };
diff --git a/tools/common/check_aml.c b/tools/common/check_aml.c index 9e5b0c2..7117825 100644 --- a/tools/common/check_aml.c +++ b/tools/common/check_aml.c @@ -45,6 +45,7 @@ struct known_table_info known_info[] = { { SIG_SSDT, 2 }, { SIG_UEFI, 1 }, { SIG_XSDT, 1 }, + { SIG_DBG2, 1 }, { NULL, 0 } };
diff --git a/tools/common/include/check_aml.h b/tools/common/include/check_aml.h index 59e0c23..94f2446 100644 --- a/tools/common/include/check_aml.h +++ b/tools/common/include/check_aml.h @@ -66,6 +66,7 @@ #define SIG_SSDT "SSDT" #define SIG_UEFI "UEFI" #define SIG_XSDT "XSDT" +#define SIG_DBG2 "DBG2"
struct known_table_info { char *signature; /* table signature */
On 10/10/2013 05:30 AM, naresh.bhat@linaro.org wrote:
From: Naresh Bhat naresh.bhat@linaro.org
Add support to compile DBG2 table.
Signed-off-by: Naresh Bhat naresh.bhat@linaro.org
platforms/foundation-v8.acpi/xsdt.asl | 1 + tools/common/build_aml.c | 1 + tools/common/check_aml.c | 1 + tools/common/include/check_aml.h | 1 + 4 files changed, 4 insertions(+)
diff --git a/platforms/foundation-v8.acpi/xsdt.asl b/platforms/foundation-v8.acpi/xsdt.asl index 3145d2b..43fc588 100644 --- a/platforms/foundation-v8.acpi/xsdt.asl +++ b/platforms/foundation-v8.acpi/xsdt.asl @@ -37,3 +37,4 @@ [0008] ACPI Table Address 0 : 0000000000000120 [0008] ACPI Table Address 0 : 0000000000000130 [0008] ACPI Table Address 0 : 0000000000000140 +[0008] ACPI Table Address 0 : 0000000000000150
Please move this patch to xsdt.asl to either a separate patch or make it part of 1/2 that adds the DBG2 table.
diff --git a/tools/common/build_aml.c b/tools/common/build_aml.c index 34cdfe4..4e70348 100644 --- a/tools/common/build_aml.c +++ b/tools/common/build_aml.c @@ -41,6 +41,7 @@ char *known_sigs[] = { "ssdt", "uefi", "xsdt",
- "dbg2", NULL };
diff --git a/tools/common/check_aml.c b/tools/common/check_aml.c index 9e5b0c2..7117825 100644 --- a/tools/common/check_aml.c +++ b/tools/common/check_aml.c @@ -45,6 +45,7 @@ struct known_table_info known_info[] = { { SIG_SSDT, 2 }, { SIG_UEFI, 1 }, { SIG_XSDT, 1 },
- { SIG_DBG2, 1 }, { NULL, 0 } };
diff --git a/tools/common/include/check_aml.h b/tools/common/include/check_aml.h index 59e0c23..94f2446 100644 --- a/tools/common/include/check_aml.h +++ b/tools/common/include/check_aml.h @@ -66,6 +66,7 @@ #define SIG_SSDT "SSDT" #define SIG_UEFI "UEFI" #define SIG_XSDT "XSDT" +#define SIG_DBG2 "DBG2"
struct known_table_info { char *signature; /* table signature */
On 11 October 2013 05:17, Al Stone al.stone@linaro.org wrote:
On 10/10/2013 05:30 AM, naresh.bhat@linaro.org wrote:
From: Naresh Bhat naresh.bhat@linaro.org
Add support to compile DBG2 table.
Signed-off-by: Naresh Bhat naresh.bhat@linaro.org
platforms/foundation-v8.acpi/xsdt.asl | 1 + tools/common/build_aml.c | 1 + tools/common/check_aml.c | 1 + tools/common/include/check_aml.h | 1 + 4 files changed, 4 insertions(+)
diff --git a/platforms/foundation-v8.acpi/xsdt.asl b/platforms/foundation-v8.acpi/xsdt.asl index 3145d2b..43fc588 100644 --- a/platforms/foundation-v8.acpi/xsdt.asl +++ b/platforms/foundation-v8.acpi/xsdt.asl @@ -37,3 +37,4 @@ [0008] ACPI Table Address 0 : 0000000000000120 [0008] ACPI Table Address 0 : 0000000000000130 [0008] ACPI Table Address 0 : 0000000000000140 +[0008] ACPI Table Address 0 : 0000000000000150
Please move this patch to xsdt.asl to either a separate patch or make it part of 1/2 that adds the DBG2 table
. Thanks I will re-work on it and post it for review.
Regards -Naresh
-
Al Stone -
Naresh Bhat -
naresh.bhat＠linaro.org