From: Al Stone ahs3@redhat.com
This is complete reorganization of what used to be "Various fix-ups and additions to mab" patches 3 and 4 (5 has been completely rethought as a seperate series to appear later).
What this patch does is add in a change log that should have been there all along, and comment the versioning a little better. The more substantial bug fix is that code that checked whether there was enough room in the XSDT for all the tables being added would only do so when verbose mode was being used. This error check now occurs under all conditions as it should have.
Al Stone (3): mab: add in a Changelog to improve documentation mab: report an XSDT error regardless of whether we're verbose or not mab: update version number (and comment it better)
tools/mab/Changelog | 9 +++++++++ tools/mab/mab.c | 19 +++++++++++-------- tools/mab/mab.h | 3 ++- 3 files changed, 22 insertions(+), 9 deletions(-) create mode 100644 tools/mab/Changelog
From: Al Stone ahs3@redhat.com
Signed-off-by: Al Stone al.stone@linaro.org --- tools/mab/Changelog | 9 +++++++++ 1 file changed, 9 insertions(+) create mode 100644 tools/mab/Changelog
diff --git a/tools/mab/Changelog b/tools/mab/Changelog new file mode 100644 index 0000000..599eda3 --- /dev/null +++ b/tools/mab/Changelog @@ -0,0 +1,9 @@ +0.27.3 -- 2013-07-13 + -- Bug fix: add in a Changelog + -- Bug fix: if the XSDT was too small, it was only reported + when providing verbose output; make sure it always gets + reported when it happens + -- Bug fix: add missing comment to describe versioning + +0.27.2 -- 2013-07-11 + -- Original source before having a Changelog
From: Al Stone ahs3@redhat.com
Signed-off-by: Al Stone al.stone@linaro.org --- tools/mab/mab.c | 19 +++++++++++-------- 1 file changed, 11 insertions(+), 8 deletions(-)
diff --git a/tools/mab/mab.c b/tools/mab/mab.c index f906efb..3107088 100644 --- a/tools/mab/mab.c +++ b/tools/mab/mab.c @@ -579,16 +579,19 @@ int main(int argc, char *argv[]) /* all done, so write out the blob */ write_blob(homedir, acpi_blob_name, blob, offset + BLOB_HEADER_SIZE);
+ /* make sure we had room for all of the tables */ + LIST_FOREACH(np, &thead, tables) { + if (np->offset < 0) { + for (jj = 0; jj < SIG_LENGTH; jj++) + sig[jj] = toupper(np->signature[jj]); + printf("? no room in XSDT for %s (%4s)\n", + basename(np->asl_name), sig); + err = 2; /* anything non-zero, really... */ + } + } + if (!quiet) { printf("%s %s\n", PROGNAME, VERSION); - LIST_FOREACH(np, &thead, tables) { - if (np->offset < 0) { - for (jj = 0; jj < SIG_LENGTH; jj++) - sig[jj] = toupper(np->signature[jj]); - printf("? no room in XSDT for %s (%4s)\n", - basename(np->asl_name), sig); - } - } ii = 0; LIST_FOREACH(np, &thead, tables) { printf("[%03d] %4s : %s (%d bytes @ 0x%08x)\n", ii,
From: Al Stone ahs3@redhat.com
Signed-off-by: Al Stone al.stone@linaro.org --- tools/mab/mab.h | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/tools/mab/mab.h b/tools/mab/mab.h index 2af20a4..e722ffd 100644 --- a/tools/mab/mab.h +++ b/tools/mab/mab.h @@ -26,7 +26,8 @@ #define REQUIRED 1 #define SIG_LENGTH 4
-const char VERSION[] = { "0.27.2" }; +/* VERSION a.b.c = <public release>.<functionality changes>.<bug fixes> */ +const char VERSION[] = { "0.27.3" }; const char PROGNAME[] = { "mab" };
char *known_sigs[] = {
On 13/08/13 22:39, al.stone@linaro.org wrote:
From: Al Stone ahs3@redhat.com
This is complete reorganization of what used to be "Various fix-ups and additions to mab" patches 3 and 4 (5 has been completely rethought as a seperate series to appear later).
What this patch does is add in a change log that should have been there all along, and comment the versioning a little better. The more substantial bug fix is that code that checked whether there was enough room in the XSDT for all the tables being added would only do so when verbose mode was being used. This error check now occurs under all conditions as it should have.
Al Stone (3): mab: add in a Changelog to improve documentation mab: report an XSDT error regardless of whether we're verbose or not mab: update version number (and comment it better)
tools/mab/Changelog | 9 +++++++++ tools/mab/mab.c | 19 +++++++++++-------- tools/mab/mab.h | 3 ++- 3 files changed, 22 insertions(+), 9 deletions(-) create mode 100644 tools/mab/Changelog
All look good to me, Acked and applied.
Thanks
Graeme
-
al.stone＠linaro.org -
Graeme Gregory