From: Al Stone ahs3@redhat.com
Initialize pwr_btn_status as disabled which (a) makes sure it is in a proper state to start, and (b) cleans up a compiler warning about an uninitialized variable.
Signed-off-by: Al Stone al.stone@linaro.org --- drivers/acpi/sleep.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/acpi/sleep.c b/drivers/acpi/sleep.c index 14df305..721e949 100644 --- a/drivers/acpi/sleep.c +++ b/drivers/acpi/sleep.c @@ -525,7 +525,7 @@ static int acpi_suspend_enter(suspend_state_t pm_state) * generate wakeup events. */ if (ACPI_SUCCESS(status) && (acpi_state == ACPI_STATE_S3)) { - acpi_event_status pwr_btn_status; + acpi_event_status pwr_btn_status = ACPI_EVENT_FLAG_DISABLED;
acpi_get_event_status(ACPI_EVENT_POWER_BUTTON, &pwr_btn_status);
On Wednesday, November 20, 2013 03:45:51 PM al.stone@linaro.org wrote:
From: Al Stone ahs3@redhat.com
Initialize pwr_btn_status as disabled which (a) makes sure it is in a proper state to start, and (b) cleans up a compiler warning about an uninitialized variable.
Signed-off-by: Al Stone al.stone@linaro.org
Queued up for the next ACPI pull request, thanks!
drivers/acpi/sleep.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/acpi/sleep.c b/drivers/acpi/sleep.c index 14df305..721e949 100644 --- a/drivers/acpi/sleep.c +++ b/drivers/acpi/sleep.c @@ -525,7 +525,7 @@ static int acpi_suspend_enter(suspend_state_t pm_state) * generate wakeup events. */ if (ACPI_SUCCESS(status) && (acpi_state == ACPI_STATE_S3)) {
acpi_event_status pwr_btn_status;
acpi_event_status pwr_btn_status = ACPI_EVENT_FLAG_DISABLED;acpi_get_event_status(ACPI_EVENT_POWER_BUTTON, &pwr_btn_status);
On Thursday, November 21, 2013 01:34:37 AM Rafael J. Wysocki wrote:
On Wednesday, November 20, 2013 03:45:51 PM al.stone@linaro.org wrote:
From: Al Stone ahs3@redhat.com
BTW, is it your intention to use different addresses for From: and Signed-off-by?
I don't think it is formally invalid, but it certainly *is* confusing.
Initialize pwr_btn_status as disabled which (a) makes sure it is in a proper state to start, and (b) cleans up a compiler warning about an uninitialized variable.
Signed-off-by: Al Stone al.stone@linaro.org
Queued up for the next ACPI pull request, thanks!
drivers/acpi/sleep.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/acpi/sleep.c b/drivers/acpi/sleep.c index 14df305..721e949 100644 --- a/drivers/acpi/sleep.c +++ b/drivers/acpi/sleep.c @@ -525,7 +525,7 @@ static int acpi_suspend_enter(suspend_state_t pm_state) * generate wakeup events. */ if (ACPI_SUCCESS(status) && (acpi_state == ACPI_STATE_S3)) {
acpi_event_status pwr_btn_status;
acpi_event_status pwr_btn_status = ACPI_EVENT_FLAG_DISABLED;acpi_get_event_status(ACPI_EVENT_POWER_BUTTON, &pwr_btn_status);
On 11/20/2013 05:43 PM, Rafael J. Wysocki wrote:
On Thursday, November 21, 2013 01:34:37 AM Rafael J. Wysocki wrote:
On Wednesday, November 20, 2013 03:45:51 PM al.stone@linaro.org wrote:
From: Al Stone ahs3@redhat.com
BTW, is it your intention to use different addresses for From: and Signed-off-by?
I don't think it is formally invalid, but it certainly *is* confusing.
Ah, no, that was not the intent. I'll fix my config problem.
Initialize pwr_btn_status as disabled which (a) makes sure it is in a proper state to start, and (b) cleans up a compiler warning about an uninitialized variable.
Signed-off-by: Al Stone al.stone@linaro.org
Queued up for the next ACPI pull request, thanks!
drivers/acpi/sleep.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/acpi/sleep.c b/drivers/acpi/sleep.c index 14df305..721e949 100644 --- a/drivers/acpi/sleep.c +++ b/drivers/acpi/sleep.c @@ -525,7 +525,7 @@ static int acpi_suspend_enter(suspend_state_t pm_state) * generate wakeup events. */ if (ACPI_SUCCESS(status) && (acpi_state == ACPI_STATE_S3)) {
acpi_event_status pwr_btn_status;
acpi_event_status pwr_btn_status = ACPI_EVENT_FLAG_DISABLED;acpi_get_event_status(ACPI_EVENT_POWER_BUTTON, &pwr_btn_status);
-
Al Stone -
al.stone＠linaro.org -
Rafael J. Wysocki