From: "Jonathan (Zhixiong) Zhang" zjzhang@codeaurora.org
On a platform with APEI (ACPI Platform Error Interface) enabled, firmware updates a memory region with hardware error record using nocache attribute. When OS reads the region, since it maps the region with cacahed attribute even though EFI memory map defines this region as uncached, OS gets stale data and errorneously reports there is no new HW error.
When ghes driver maps the memory region, it uses the cache attribute according to EFI memory map, if EFI memory map feature is enabled at runtime.
Since both arch/x86 and arch/ia64 implemented architecture agnostic EFI memory map attribue lookup function efi_memattributes(), the code is moved from arch/x86 into EFI subsystem and is declared as __weak; archs other than ia64 should not override the default implementation.
V9: 1. Rebased to arm64-upstream-14543 of arm64/master. 2. Match strict MM type in arch_apei_get_mem_attribute(). V8: 1. For x86, always return PAGE_KERNEL for arch_apei_get_mem_attribute(). The rational is explained in comment. 2. Rebased to arm64-upstream-14201 of arm64/master, next-20150724 of linux-next/master. V7: 1. Added PROT_DEVICE_nGnRnE and PROT_NORMAL_WT to support all possible UEFI memory types for arm64. V6: 1. Implemented arch_apei_get_mem_attributes() for arm64 as inline function. 2. Rebased to efi-next-14364 of efi/next, pm+acpi-4.2-rc3 of linux-pm/master, arm64-upstream-13521 of arm64/master, next-20150720 of linux-next/master. V5: 1. Rebased to next-20150713 of linux-next/master, efi-next-14359 of efi/next, pm+acpi-4.2-rc2 of linux-pm/master, arm64-fixes-1215 of arm64/master. 2. Added comment for efi_mem_attributes(), explained why it is marked as __weak at the function definition site. V4: 1. Introduced arch_apei_get_mem_attributes() to allow arch specific implementation of getting pgprot_t appropriate for a physical address. 2. Implemented arch_apei_get_mem_attributes() for x86 and for arm64. V3: 1. Rebased to v4.1-rc7. 2. Moved efi_mem_attributes() from arch/x86 to drivers/firmware/efi and declared it as __weak. 3. Introduced ARCH_APEI_PAGE_KERNEL_UC to allow arch specific page protection type for UC. 4. Removed efi_ioremap(). It can not be used for GHES memory region mapping purpose since ioremap can not be used in atomic context. V2: 1. Rebased to v4.1-rc5. 2. Split removal of efi_mem_attributes() and creation of efi_ioremap() into two patches. Jonathan (Zhixiong) Zhang (5): efi: x86: rearrange efi_mem_attributes() x86: acpi: implement arch_apei_get_mem_attributes() arm64: mm: add PROT_DEVICE_nGnRnE and PROT_NORMAL_WT arm64: apei: implement arch_apei_get_mem_attributes() acpi, apei: use appropriate pgprot_t to map GHES memory
arch/arm64/include/asm/acpi.h | 26 ++++++++++++++++++++++++++ arch/arm64/include/asm/memory.h | 1 + arch/arm64/include/asm/pgtable.h | 2 ++ arch/arm64/mm/proc.S | 4 +++- arch/x86/kernel/acpi/apei.c | 19 +++++++++++++++++++ arch/x86/platform/efi/efi.c | 18 ------------------ drivers/acpi/apei/ghes.c | 6 ++++-- drivers/firmware/efi/efi.c | 31 +++++++++++++++++++++++++++++++ include/acpi/apei.h | 1 + 9 files changed, 87 insertions(+), 21 deletions(-)
From: "Jonathan (Zhixiong) Zhang" zjzhang@codeaurora.org
x86 and ia64 implement efi_mem_attributes() differently. This function needs to be available for other arch (such as arm64) as well, such as for the purpose of ACPI/APEI.
ia64 efi does not setup memmap variable and does not set EFI_MEMMAP flag, so it needs to have its unique implementation of efi_mem_attributes().
Move efi_mem_attributes() implementation from x86 to efi, and declare it with __weak. It is recommended that other archs should not override the default implementation.
Reviewed-by: Matt Fleming matt.fleming@intel.com Signed-off-by: Jonathan (Zhixiong) Zhang zjzhang@codeaurora.org --- arch/x86/platform/efi/efi.c | 18 ------------------ drivers/firmware/efi/efi.c | 31 +++++++++++++++++++++++++++++++ 2 files changed, 31 insertions(+), 18 deletions(-)
diff --git a/arch/x86/platform/efi/efi.c b/arch/x86/platform/efi/efi.c index dbc8627a5cdf..88b3ebaeb72f 100644 --- a/arch/x86/platform/efi/efi.c +++ b/arch/x86/platform/efi/efi.c @@ -917,24 +917,6 @@ u32 efi_mem_type(unsigned long phys_addr) return 0; }
-u64 efi_mem_attributes(unsigned long phys_addr) -{ - efi_memory_desc_t *md; - void *p; - - if (!efi_enabled(EFI_MEMMAP)) - return 0; - - for (p = memmap.map; p < memmap.map_end; p += memmap.desc_size) { - md = p; - if ((md->phys_addr <= phys_addr) && - (phys_addr < (md->phys_addr + - (md->num_pages << EFI_PAGE_SHIFT)))) - return md->attribute; - } - return 0; -} - static int __init arch_parse_efi_cmdline(char *str) { if (parse_option_str(str, "old_map")) diff --git a/drivers/firmware/efi/efi.c b/drivers/firmware/efi/efi.c index 3061bb8629dc..bf4190a4f3f5 100644 --- a/drivers/firmware/efi/efi.c +++ b/drivers/firmware/efi/efi.c @@ -517,3 +517,34 @@ char * __init efi_md_typeattr_format(char *buf, size_t size, attr & EFI_MEMORY_UC ? "UC" : ""); return buf; } + +/* + * efi_mem_attributes - lookup memmap attributes for physical address + * @phys_addr: the physical address to lookup + * + * Search in the EFI memory map for the region covering + * @phys_addr. Returns the EFI memory attributes if the region + * was found in the memory map, 0 otherwise. + * + * Despite being marked __weak, most architectures should *not* + * override this function. It is __weak solely for the benefit + * of ia64 which has a funky EFI memory map that doesn't work + * the same way as other architectures. + */ +u64 __weak efi_mem_attributes(unsigned long phys_addr) +{ + efi_memory_desc_t *md; + void *p; + + if (!efi_enabled(EFI_MEMMAP)) + return 0; + + for (p = memmap.map; p < memmap.map_end; p += memmap.desc_size) { + md = p; + if ((md->phys_addr <= phys_addr) && + (phys_addr < (md->phys_addr + + (md->num_pages << EFI_PAGE_SHIFT)))) + return md->attribute; + } + return 0; +}
From: "Jonathan (Zhixiong) Zhang" zjzhang@codeaurora.org
... to allow arch specific implementation of getting page protection type associated with a physical address.
On x86, we currently have no way to lookup the EFI memory map attributes for a region in a consistent way because the memmap is discarded after efi_free_boot_services(). So if you call efi_mem_attributes() during boot and at runtime, you could theoretically see different attributes.
Since we are yet to see any x86 platforms that require anything other than PAGE_KERNEL (some arm64 platforms require the equivalent of PAGE_KERNEL_NOCACHE), return that until we know differently.
Signed-off-by: Jonathan (Zhixiong) Zhang zjzhang@codeaurora.org --- arch/x86/kernel/acpi/apei.c | 19 +++++++++++++++++++ include/acpi/apei.h | 1 + 2 files changed, 20 insertions(+)
diff --git a/arch/x86/kernel/acpi/apei.c b/arch/x86/kernel/acpi/apei.c index c280df6b2aa2..675bd46c4e17 100644 --- a/arch/x86/kernel/acpi/apei.c +++ b/arch/x86/kernel/acpi/apei.c @@ -60,3 +60,22 @@ void arch_apei_flush_tlb_one(unsigned long addr) { __flush_tlb_one(addr); } + +static inline pgprot_t arch_apei_get_mem_attribute(phys_addr_t addr) +{ + + /* + * We currently have no way to lookup the EFI memory map + * attributes for a region in a consistent way because the + * memmap is discarded after efi_free_boot_services(). So if + * you call efi_mem_attributes() during boot and at runtime, + * you could theoretically see different attributes. + * + * Since we are yet to see any x86 platforms that require + * anything other than PAGE_KERNEL (some arm64 platforms + * require the equivalent of PAGE_KERNEL_NOCACHE), return that + * until we know differently. + */ + + return __pgprot(PAGE_KERNEL); +} diff --git a/include/acpi/apei.h b/include/acpi/apei.h index 284801ac7042..64a12ce9880b 100644 --- a/include/acpi/apei.h +++ b/include/acpi/apei.h @@ -46,6 +46,7 @@ int erst_clear(u64 record_id); int arch_apei_enable_cmcff(struct acpi_hest_header *hest_hdr, void *data); void arch_apei_report_mem_error(int sev, struct cper_sec_mem_err *mem_err); void arch_apei_flush_tlb_one(unsigned long addr); +pgprot_t arch_apei_get_mem_attribute(phys_addr_t addr);
#endif #endif
On Thu, 30 Jul, at 02:35:06PM, Jonathan (Zhixiong) Zhang wrote:
From: "Jonathan (Zhixiong) Zhang" zjzhang@codeaurora.org
... to allow arch specific implementation of getting page protection type associated with a physical address.
On x86, we currently have no way to lookup the EFI memory map attributes for a region in a consistent way because the memmap is discarded after efi_free_boot_services(). So if you call efi_mem_attributes() during boot and at runtime, you could theoretically see different attributes.
Since we are yet to see any x86 platforms that require anything other than PAGE_KERNEL (some arm64 platforms require the equivalent of PAGE_KERNEL_NOCACHE), return that until we know differently.
Signed-off-by: Jonathan (Zhixiong) Zhang zjzhang@codeaurora.org
arch/x86/kernel/acpi/apei.c | 19 +++++++++++++++++++ include/acpi/apei.h | 1 + 2 files changed, 20 insertions(+)
diff --git a/arch/x86/kernel/acpi/apei.c b/arch/x86/kernel/acpi/apei.c index c280df6b2aa2..675bd46c4e17 100644 --- a/arch/x86/kernel/acpi/apei.c +++ b/arch/x86/kernel/acpi/apei.c @@ -60,3 +60,22 @@ void arch_apei_flush_tlb_one(unsigned long addr) { __flush_tlb_one(addr); }
+static inline pgprot_t arch_apei_get_mem_attribute(phys_addr_t addr) +{
- /*
* We currently have no way to lookup the EFI memory map* attributes for a region in a consistent way because the* memmap is discarded after efi_free_boot_services(). So if* you call efi_mem_attributes() during boot and at runtime,* you could theoretically see different attributes.** Since we are yet to see any x86 platforms that require* anything other than PAGE_KERNEL (some arm64 platforms* require the equivalent of PAGE_KERNEL_NOCACHE), return that* until we know differently.*/- return __pgprot(PAGE_KERNEL);
+} diff --git a/include/acpi/apei.h b/include/acpi/apei.h index 284801ac7042..64a12ce9880b 100644 --- a/include/acpi/apei.h +++ b/include/acpi/apei.h @@ -46,6 +46,7 @@ int erst_clear(u64 record_id); int arch_apei_enable_cmcff(struct acpi_hest_header *hest_hdr, void *data); void arch_apei_report_mem_error(int sev, struct cper_sec_mem_err *mem_err); void arch_apei_flush_tlb_one(unsigned long addr); +pgprot_t arch_apei_get_mem_attribute(phys_addr_t addr); #endif #endif
This doesn't compile :(
/home/matt/src/kernels/efi/arch/x86/kernel/acpi/apei.c:64:24: error: static declaration of ‘arch_apei_get_mem_attribute’ follows non-static declaration static inline pgprot_t arch_apei_get_mem_attribute(phys_addr_t addr) ^ In file included from /home/matt/src/kernels/efi/arch/x86/kernel/acpi/apei.c:15:0: /home/matt/src/kernels/efi/include/acpi/apei.h:48:10: note: previous declaration of ‘arch_apei_get_mem_attribute’ was here pgprot_t arch_apei_get_mem_attribute(phys_addr_t addr); ^ /home/matt/src/kernels/efi/arch/x86/kernel/acpi/apei.c: In function ‘arch_apei_get_mem_attribute’: /home/matt/src/kernels/efi/arch/x86/kernel/acpi/apei.c:80:2: error: incompatible types when initializing type ‘long unsigned int’ using type ‘pgprot_t’ return __pgprot(PAGE_KERNEL);
From: "Jonathan (Zhixiong) Zhang" zjzhang@codeaurora.org
UEFI spec 2.5 section 2.3.6.1 defines that EFI_MEMORY_[UC|WC|WT|WB] are possible EFI memory types for AArch64. Each of those EFI memory types is mapped to a corresponding AArch64 memory type. So we need to define PROT_DEVICE_nGnRnE and PROT_NORMWL_WT additionaly.
MT_NORMAL_WT is defined, and its encoding is added to MAIR_EL1 when initializing cpu.
Reviewed-by: Catalin Marinas catalin.marinas@arm.com Signed-off-by: Jonathan (Zhixiong) Zhang zjzhang@codeaurora.org --- arch/arm64/include/asm/memory.h | 1 + arch/arm64/include/asm/pgtable.h | 2 ++ arch/arm64/mm/proc.S | 4 +++- 3 files changed, 6 insertions(+), 1 deletion(-)
diff --git a/arch/arm64/include/asm/memory.h b/arch/arm64/include/asm/memory.h index f800d45ea226..4112b3d7468e 100644 --- a/arch/arm64/include/asm/memory.h +++ b/arch/arm64/include/asm/memory.h @@ -100,6 +100,7 @@ #define MT_DEVICE_GRE 2 #define MT_NORMAL_NC 3 #define MT_NORMAL 4 +#define MT_NORMAL_WT 5
/* * Memory types for Stage-2 translation diff --git a/arch/arm64/include/asm/pgtable.h b/arch/arm64/include/asm/pgtable.h index 800ec0e87ed9..5c108ad13558 100644 --- a/arch/arm64/include/asm/pgtable.h +++ b/arch/arm64/include/asm/pgtable.h @@ -61,8 +61,10 @@ extern void __pgd_error(const char *file, int line, unsigned long val); #define PROT_SECT_DEFAULT (PMD_TYPE_SECT | PMD_SECT_AF) #endif
+#define PROT_DEVICE_nGnRnE (PROT_DEFAULT | PTE_PXN | PTE_UXN | PTE_ATTRINDX(MT_DEVICE_nGnRnE)) #define PROT_DEVICE_nGnRE (PROT_DEFAULT | PTE_PXN | PTE_UXN | PTE_ATTRINDX(MT_DEVICE_nGnRE)) #define PROT_NORMAL_NC (PROT_DEFAULT | PTE_PXN | PTE_UXN | PTE_ATTRINDX(MT_NORMAL_NC)) +#define PROT_NORMAL_WT (PROT_DEFAULT | PTE_PXN | PTE_UXN | PTE_ATTRINDX(MT_NORMAL_WT)) #define PROT_NORMAL (PROT_DEFAULT | PTE_PXN | PTE_UXN | PTE_ATTRINDX(MT_NORMAL))
#define PROT_SECT_DEVICE_nGnRE (PROT_SECT_DEFAULT | PMD_SECT_PXN | PMD_SECT_UXN | PMD_ATTRINDX(MT_DEVICE_nGnRE)) diff --git a/arch/arm64/mm/proc.S b/arch/arm64/mm/proc.S index 838266f5b056..dfcc05804665 100644 --- a/arch/arm64/mm/proc.S +++ b/arch/arm64/mm/proc.S @@ -303,12 +303,14 @@ ENTRY(__cpu_setup) * DEVICE_GRE 010 00001100 * NORMAL_NC 011 01000100 * NORMAL 100 11111111 + * NORMAL_WT 101 10111011 */ ldr x5, =MAIR(0x00, MT_DEVICE_nGnRnE) | \ MAIR(0x04, MT_DEVICE_nGnRE) | \ MAIR(0x0c, MT_DEVICE_GRE) | \ MAIR(0x44, MT_NORMAL_NC) | \ - MAIR(0xff, MT_NORMAL) + MAIR(0xff, MT_NORMAL) | \ + MAIR(0xbb, MT_NORMAL_WT) msr mair_el1, x5 /* * Prepare SCTLR
From: "Jonathan (Zhixiong) Zhang" zjzhang@codeaurora.org
Table 8 of UEFI 2.5 section 2.3.6.1 defines mappings from EFI memory types to MAIR attribute encodings for arm64.
If the physical address has memory attributes defined by EFI memmap as EFI_MEMORY_[UC|WC|WT], return approprate page protection type according to the UEFI spec. Otherwise, return PAGE_KERNEL.
Reviewed-by: Catalin Marinas catalin.marinas@arm.com Acked-by: Hanjun Guo hanjun.guo@linaro.org Signed-off-by: Jonathan (Zhixiong) Zhang zjzhang@codeaurora.org --- arch/arm64/include/asm/acpi.h | 26 ++++++++++++++++++++++++++ 1 file changed, 26 insertions(+)
diff --git a/arch/arm64/include/asm/acpi.h b/arch/arm64/include/asm/acpi.h index 1ff9e6eb5e02..1025d0401016 100644 --- a/arch/arm64/include/asm/acpi.h +++ b/arch/arm64/include/asm/acpi.h @@ -19,6 +19,11 @@ #include <asm/psci.h> #include <asm/smp_plat.h>
+#ifdef CONFIG_ACPI_APEI +#include <linux/efi.h> +#include <asm/pgtable.h> +#endif + /* Macros for consistency checks of the GICC subtable of MADT */ #define ACPI_MADT_GICC_LENGTH \ (acpi_gbl_FADT.header.revision < 6 ? 76 : 80) @@ -91,4 +95,26 @@ static inline const char *acpi_get_enable_method(int cpu) { return acpi_psci_present() ? "psci" : NULL; } + +#ifdef CONFIG_ACPI_APEI +/* + * According to "Table 8 Map: EFI memory types to AArch64 memory types" + * of UEFI 2.5 section 2.3.6.1, each EFI memory type is mapped to + * corresponding MAIR attribute encoding. + */ +static inline pgprot_t arch_apei_get_mem_attribute(phys_addr_t addr) +{ + u64 attr; + + attr = efi_mem_attributes(addr); + if (attr & EFI_MEMORY_UC) + return __pgprot(PROT_DEVICE_nGnRnE); + if (attr & EFI_MEMORY_WC) + return __pgprot(PROT_NORMAL_NC); + if (attr & EFI_MEMORY_WT) + return __pgprot(PROT_NORMAL_WT); + return __pgprot(PAGE_KERNEL); +} +#endif + #endif /*_ASM_ACPI_H*/
From: "Jonathan (Zhixiong) Zhang" zjzhang@codeaurora.org
With ACPI APEI firmware first handling, generic hardware error record is updated by firmware in GHES memory region. On an arm64 platform, firmware updates GHES memory region with uncached access attribute, and then Linux reads stale data from cache.
GHES memory region should be mapped with page protection type according to what is returned from arch_apei_get_mem_attribute(), instead of always with PAGE_KERNEL (eg. cached attribute).
Signed-off-by: Jonathan (Zhixiong) Zhang zjzhang@codeaurora.org --- drivers/acpi/apei/ghes.c | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-)
diff --git a/drivers/acpi/apei/ghes.c b/drivers/acpi/apei/ghes.c index b979b5dbe5bc..98609b404dae 100644 --- a/drivers/acpi/apei/ghes.c +++ b/drivers/acpi/apei/ghes.c @@ -173,8 +173,10 @@ static void __iomem *ghes_ioremap_pfn_irq(u64 pfn) unsigned long vaddr;
vaddr = (unsigned long)GHES_IOREMAP_IRQ_PAGE(ghes_ioremap_area->addr); - ioremap_page_range(vaddr, vaddr + PAGE_SIZE, - pfn << PAGE_SHIFT, PAGE_KERNEL); + ioremap_page_range(vaddr, + vaddr + PAGE_SIZE, + pfn << PAGE_SHIFT, + arch_apei_get_mem_attribute(pfn << PAGE_SHIFT));
return (void __iomem *)vaddr; }
Hi Jonathan,
On Thu, Jul 30, 2015 at 10:35:04PM +0100, Jonathan (Zhixiong) Zhang wrote:
From: "Jonathan (Zhixiong) Zhang" zjzhang@codeaurora.org
On a platform with APEI (ACPI Platform Error Interface) enabled, firmware updates a memory region with hardware error record using nocache attribute. When OS reads the region, since it maps the region with cacahed attribute even though EFI memory map defines this region as uncached, OS gets stale data and errorneously reports there is no new HW error.
When ghes driver maps the memory region, it uses the cache attribute according to EFI memory map, if EFI memory map feature is enabled at runtime.
Since both arch/x86 and arch/ia64 implemented architecture agnostic EFI memory map attribue lookup function efi_memattributes(), the code is moved from arch/x86 into EFI subsystem and is declared as __weak; archs other than ia64 should not override the default implementation.
V9:
- Rebased to arm64-upstream-14543 of arm64/master.
- Match strict MM type in arch_apei_get_mem_attribute().
I guess this is all going via Matt's tree? I'm happy to take the new memory type in arch/arm64/ if there's nothing currently queued, but I suspect it makes more sense for it to stay together.
Will
On Mon, 03 Aug, at 12:26:58PM, Will Deacon wrote:
I guess this is all going via Matt's tree? I'm happy to take the new memory type in arch/arm64/ if there's nothing currently queued, but I suspect it makes more sense for it to stay together.
Right, it probably does make sense to take this through a single tree.
I'm still waiting for the ACPI folks to chime in on whether this series makes sense, and in particular I'd like to hear from people that have touched ghes.c in the past.
Rafael, Boris?
On Mon, Aug 03, 2015 at 05:23:54PM +0100, Matt Fleming wrote:
Rafael, Boris?
The ghes.c change looks fine I guess. The whole patchset makes sense now, with the arch bits extracted. So
Acked-by: Borislav Petkov bp@suse.de
However, we probably should work towards adhering to EFI memory attributes on x86, long term, as we talked. But that's a future thing.
Thanks.
On 8/3/2015 9:25 PM, Borislav Petkov wrote:
On Mon, Aug 03, 2015 at 05:23:54PM +0100, Matt Fleming wrote:
Rafael, Boris?
The ghes.c change looks fine I guess. The whole patchset makes sense now, with the arch bits extracted. So
Acked-by: Borislav Petkov bp@suse.de
Thank you Boris/Matt/Will for the support.
However, we probably should work towards adhering to EFI memory attributes on x86, long term, as we talked. But that's a future thing.
Thanks.
On Tue, 04 Aug, at 08:41:36AM, Zhang, Jonathan Zhixiong wrote:
On 8/3/2015 9:25 PM, Borislav Petkov wrote:
On Mon, Aug 03, 2015 at 05:23:54PM +0100, Matt Fleming wrote:
Rafael, Boris?
The ghes.c change looks fine I guess. The whole patchset makes sense now, with the arch bits extracted. So
Acked-by: Borislav Petkov bp@suse.de
Thank you Boris/Matt/Will for the support.
Jonathan, if you fixup the compiler error in PATCH 2 I'll take this series through the EFI tree.
On 8/5/2015 2:21 AM, Matt Fleming wrote:
On Tue, 04 Aug, at 08:41:36AM, Zhang, Jonathan Zhixiong wrote:
On 8/3/2015 9:25 PM, Borislav Petkov wrote:
On Mon, Aug 03, 2015 at 05:23:54PM +0100, Matt Fleming wrote:
Rafael, Boris?
The ghes.c change looks fine I guess. The whole patchset makes sense now, with the arch bits extracted. So
Acked-by: Borislav Petkov bp@suse.de
Thank you Boris/Matt/Will for the support.
Jonathan, if you fixup the compiler error in PATCH 2 I'll take this series through the EFI tree.
Yes, absolutely. It has been in my mind, sorry I was tied up in the last few days. I wonder what I may missed, I certainly do x86 build test with versions of the patch set.
I will try today and report back.
On Wed, 05 Aug, at 08:58:52AM, Zhang, Jonathan Zhixiong wrote:
Yes, absolutely. It has been in my mind, sorry I was tied up in the last few days. I wonder what I may missed, I certainly do x86 build test with versions of the patch set.
I will try today and report back.
No problem.
I'd suggest moving the implementation into include/acpi/apei.h and leaving it as static inline instead of implementing it out of line in arch/x86/kernel/acpi/apei.c.
On Wed, 05 Aug, at 05:10:00PM, Matt Fleming wrote:
On Wed, 05 Aug, at 08:58:52AM, Zhang, Jonathan Zhixiong wrote:
Yes, absolutely. It has been in my mind, sorry I was tied up in the last few days. I wonder what I may missed, I certainly do x86 build test with versions of the patch set.
I will try today and report back.
No problem.
I'd suggest moving the implementation into include/acpi/apei.h and leaving it as static inline instead of implementing it out of line in arch/x86/kernel/acpi/apei.c.
Yeah, I didn't mean include/acpi/apei.h but the architecture-specific equivalent.
On 8/5/2015 9:13 AM, Matt Fleming wrote:
On Wed, 05 Aug, at 05:10:00PM, Matt Fleming wrote:
On Wed, 05 Aug, at 08:58:52AM, Zhang, Jonathan Zhixiong wrote:
Yes, absolutely. It has been in my mind, sorry I was tied up in the last few days. I wonder what I may missed, I certainly do x86 build test with versions of the patch set.
I will try today and report back.
No problem.
I'd suggest moving the implementation into include/acpi/apei.h and leaving it as static inline instead of implementing it out of line in arch/x86/kernel/acpi/apei.c.
Yeah, I didn't mean include/acpi/apei.h but the architecture-specific equivalent.
Thank you Matt. It builds well on x86 with default configuration, but not if APEI feature is turned on. This is my fault. I just sent a new version of the patch set out.
On Tue, 04 Aug, at 06:25:52AM, Borislav Petkov wrote:
On Mon, Aug 03, 2015 at 05:23:54PM +0100, Matt Fleming wrote:
Rafael, Boris?
The ghes.c change looks fine I guess. The whole patchset makes sense now, with the arch bits extracted. So
Acked-by: Borislav Petkov bp@suse.de
Thanks Boris.
However, we probably should work towards adhering to EFI memory attributes on x86, long term, as we talked. But that's a future thing.
Yeah, it's on my TODO list.
-
Borislav Petkov -
Jonathan (Zhixiong) Zhang -
Matt Fleming -
Will Deacon -
Zhang, Jonathan Zhixiong