From: Naresh Bhat naresh.bhat@linaro.org
Add the HID as we have listed on linaro ACPI registry https://wiki.linaro.org/LEG/Engineering/Kernel/ACPI/ACPILinaroRegistry
The logs on v8 as below
root@genericarmv8:/sys# find . -name LINA000A* ./bus/acpi/devices/LINA000A:00 ./bus/acpi/devices/LINA000A:01 ./bus/acpi/devices/LINA000A:02 ./bus/acpi/devices/LINA000A:03 ./bus/amba/devices/LINA000A:00 ./bus/amba/devices/LINA000A:01 ./bus/amba/devices/LINA000A:02 ./bus/amba/devices/LINA000A:03 ./bus/amba/drivers/uart-pl011/LINA000A:00 ./bus/amba/drivers/uart-pl011/LINA000A:01 ./bus/amba/drivers/uart-pl011/LINA000A:02 ./bus/amba/drivers/uart-pl011/LINA000A:03 ./devices/platform/LINA000A:00 ./devices/platform/LINA000A:01 ./devices/platform/LINA000A:02 ./devices/platform/LINA000A:03 ./devices/LNXSYSTM:00/device:00/AMBA0000:00/LINA000A:00 ./devices/LNXSYSTM:00/device:00/AMBA0000:00/LINA000A:01 ./devices/LNXSYSTM:00/device:00/AMBA0000:00/LINA000A:02 ./devices/LNXSYSTM:00/device:00/AMBA0000:00/LINA000A:03 root@genericarmv8:/sys#
Naresh Bhat (1): foundation-v8: Add HID for UART devices
platforms/foundation-v8.acpi/dsdt.asl | 4 ++++ 1 file changed, 4 insertions(+)
From: Naresh Bhat naresh.bhat@linaro.org
Add _HID for pl011-uart devices.
Signed-off-by: Naresh Bhat naresh.bhat@linaro.org --- platforms/foundation-v8.acpi/dsdt.asl | 4 ++++ 1 file changed, 4 insertions(+)
diff --git a/platforms/foundation-v8.acpi/dsdt.asl b/platforms/foundation-v8.acpi/dsdt.asl index 5c3225a..0d323a5 100644 --- a/platforms/foundation-v8.acpi/dsdt.asl +++ b/platforms/foundation-v8.acpi/dsdt.asl @@ -395,6 +395,7 @@ DefinitionBlock ( Name (_UID, 0)
Device (SER0) { + Name (_HID, "LINA000A") Name (_ADR, 0x1c090000) Name (_UID, 0)
@@ -408,6 +409,7 @@ DefinitionBlock ( }
Device (SER1) { + Name (_HID, "LINA000A") Name (_ADR, 0x1c0a0000) Name (_UID, 1)
@@ -421,6 +423,7 @@ DefinitionBlock ( }
Device (SER2) { + Name (_HID, "LINA000A") Name (_ADR, 0x1c0b0000) Name (_UID, 2)
@@ -434,6 +437,7 @@ DefinitionBlock ( }
Device (SER3) { + Name (_HID, "LINA000A") Name (_ADR, 0x1c0c0000) Name (_UID, 3)
Naresh, If we are going to use my AMBA bus ACPI patch, it is not necessary to use the _HID of LINA0009 for the UART, since the pl011 driver is not probed directly but instead by the AMBA bus connector using the top-level _HID of AMBA0000.
Is this required for the DBG2 table you are working on?
Brandon
-----Original Message----- From: linaro-acpi-bounces@lists.linaro.org [mailto:linaro-acpi-bounces@lists.linaro.org] On Behalf Of naresh.bhat@linaro.org Sent: Wednesday, October 23, 2013 5:17 AM To: linaro-acpi@lists.linaro.org Subject: [Linaro-acpi] [RFC PATCH] foundation-v8: Add HID for UART devices
From: Naresh Bhat naresh.bhat@linaro.org
Add _HID for pl011-uart devices.
Signed-off-by: Naresh Bhat naresh.bhat@linaro.org --- platforms/foundation-v8.acpi/dsdt.asl | 4 ++++ 1 file changed, 4 insertions(+)
diff --git a/platforms/foundation-v8.acpi/dsdt.asl b/platforms/foundation-v8.acpi/dsdt.asl index 5c3225a..0d323a5 100644 --- a/platforms/foundation-v8.acpi/dsdt.asl +++ b/platforms/foundation-v8.acpi/dsdt.asl @@ -395,6 +395,7 @@ DefinitionBlock ( Name (_UID, 0)
Device (SER0) { + Name (_HID, "LINA000A") Name (_ADR, 0x1c090000) Name (_UID, 0)
@@ -408,6 +409,7 @@ DefinitionBlock ( }
Device (SER1) { + Name (_HID, "LINA000A") Name (_ADR, 0x1c0a0000) Name (_UID, 1)
@@ -421,6 +423,7 @@ DefinitionBlock ( }
Device (SER2) { + Name (_HID, "LINA000A") Name (_ADR, 0x1c0b0000) Name (_UID, 2)
@@ -434,6 +437,7 @@ DefinitionBlock ( }
Device (SER3) { + Name (_HID, "LINA000A") Name (_ADR, 0x1c0c0000) Name (_UID, 3)
I do understand and agree with you. Here the HID is just for the sake of name/identifier of the device enumeration. I assume Its more related human readable format.
-Naresh
On 23 October 2013 20:44, Anderson, Brandon Brandon.Anderson@amd.com wrote:
Naresh, If we are going to use my AMBA bus ACPI patch, it is not necessary to use the _HID of LINA0009 for the UART, since the pl011 driver is not probed directly but instead by the AMBA bus connector using the top-level _HID of AMBA0000.
Is this required for the DBG2 table you are working on?
Brandon
-----Original Message----- From: linaro-acpi-bounces@lists.linaro.org [mailto:linaro-acpi-bounces@lists.linaro.org] On Behalf Of naresh.bhat@linaro.org Sent: Wednesday, October 23, 2013 5:17 AM To: linaro-acpi@lists.linaro.org Subject: [Linaro-acpi] [RFC PATCH] foundation-v8: Add HID for UART devices
From: Naresh Bhat naresh.bhat@linaro.org
Add _HID for pl011-uart devices.
Signed-off-by: Naresh Bhat naresh.bhat@linaro.org
platforms/foundation-v8.acpi/dsdt.asl | 4 ++++ 1 file changed, 4 insertions(+)
diff --git a/platforms/foundation-v8.acpi/dsdt.asl b/platforms/foundation-v8.acpi/dsdt.asl index 5c3225a..0d323a5 100644 --- a/platforms/foundation-v8.acpi/dsdt.asl +++ b/platforms/foundation-v8.acpi/dsdt.asl @@ -395,6 +395,7 @@ DefinitionBlock ( Name (_UID, 0)
Device (SER0) {
Name (_HID, "LINA000A") Name (_ADR, 0x1c090000) Name (_UID, 0)
@@ -408,6 +409,7 @@ DefinitionBlock ( }
Device (SER1) {
Name (_HID, "LINA000A") Name (_ADR, 0x1c0a0000) Name (_UID, 1)
@@ -421,6 +423,7 @@ DefinitionBlock ( }
Device (SER2) {
Name (_HID, "LINA000A") Name (_ADR, 0x1c0b0000) Name (_UID, 2)
@@ -434,6 +437,7 @@ DefinitionBlock ( }
Device (SER3) {
Name (_HID, "LINA000A") Name (_ADR, 0x1c0c0000) Name (_UID, 3)
-- 1.7.9.5
Linaro-acpi mailing list Linaro-acpi@lists.linaro.org http://lists.linaro.org/mailman/listinfo/linaro-acpi
Pardon me, I meant to say that 'LINA000A' is not necessary for UART. I incorrectly reference 'LINA0009', which is for the vexpress-sysreg.
Brandon
-----Original Message----- From: Anderson, Brandon Sent: Wednesday, October 23, 2013 10:15 AM To: 'naresh.bhat@linaro.org'; linaro-acpi@lists.linaro.org Subject: RE: [Linaro-acpi] [RFC PATCH] foundation-v8: Add HID for UART devices
Naresh, If we are going to use my AMBA bus ACPI patch, it is not necessary to use the _HID of LINA0009 for the UART, since the pl011 driver is not probed directly but instead by the AMBA bus connector using the top-level _HID of AMBA0000.
Is this required for the DBG2 table you are working on?
Brandon
-----Original Message----- From: linaro-acpi-bounces@lists.linaro.org [mailto:linaro-acpi-bounces@lists.linaro.org] On Behalf Of naresh.bhat@linaro.org Sent: Wednesday, October 23, 2013 5:17 AM To: linaro-acpi@lists.linaro.org Subject: [Linaro-acpi] [RFC PATCH] foundation-v8: Add HID for UART devices
From: Naresh Bhat naresh.bhat@linaro.org
Add _HID for pl011-uart devices.
Signed-off-by: Naresh Bhat naresh.bhat@linaro.org --- platforms/foundation-v8.acpi/dsdt.asl | 4 ++++ 1 file changed, 4 insertions(+)
diff --git a/platforms/foundation-v8.acpi/dsdt.asl b/platforms/foundation-v8.acpi/dsdt.asl index 5c3225a..0d323a5 100644 --- a/platforms/foundation-v8.acpi/dsdt.asl +++ b/platforms/foundation-v8.acpi/dsdt.asl @@ -395,6 +395,7 @@ DefinitionBlock ( Name (_UID, 0)
Device (SER0) { + Name (_HID, "LINA000A") Name (_ADR, 0x1c090000) Name (_UID, 0)
@@ -408,6 +409,7 @@ DefinitionBlock ( }
Device (SER1) { + Name (_HID, "LINA000A") Name (_ADR, 0x1c0a0000) Name (_UID, 1)
@@ -421,6 +423,7 @@ DefinitionBlock ( }
Device (SER2) { + Name (_HID, "LINA000A") Name (_ADR, 0x1c0b0000) Name (_UID, 2)
@@ -434,6 +437,7 @@ DefinitionBlock ( }
Device (SER3) { + Name (_HID, "LINA000A") Name (_ADR, 0x1c0c0000) Name (_UID, 3)